Repository navigation
fix(relay): gate the systemd extension constant on unix - #5933
Conversation
EXTEND_USEC is only read under #[cfg(unix)], so Windows builds flag it as dead code and build.warnings fails the Windows platform gate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
|
Merge summary: gates the Windows-dead (Written by Claude Opus 5.5) |
Problem
EXTEND_USECinrs/moq-relay/src/acme.rsis only read under#[cfg(unix)](thesd_notifystart-timeout extension), so on Windows it is dead code andbuild.warningsturns the warning into an error. Since #5858, the merge queue's Windows platform gate fails for any PR that selectsmoq-relay, which dequeued #5913.Approach
Gate the constant with
#[cfg(unix)], matching its only use. Nothing else in the file is Unix-only dead code:EXTEND_INTERVALdrives an unconditional timer, and the othercfg(unix)blocks only set permissions on values used on every platform. The Windows job log reports only this warning.Impact
Alternatives
sd_notifycall would drop the doc link fromEXTEND_INTERVAL.#[cfg_attr(not(unix), allow(dead_code))]keeps a constant that does nothing on Windows.Follow-ups
acme::tests::failed_validations_stop_short_of_the_rate_limithit its 30 s wall-clock bound in the same queue run; out of scope here.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)