Skip to content

fix(relay): gate the systemd extension constant on unix - #5933

Merged
kixelated merged 1 commit into
mainfrom
fix/acme-windows-dead-code
Oct 19, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/acme-windows-dead-code

Conversation

@kixelated

@kixelated kixelated commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

EXTEND_USEC in rs/moq-relay/src/acme.rs is only read under #[cfg(unix)] (the sd_notify start-timeout extension), so on Windows it is dead code and build.warnings turns the warning into an error. Since #5858, the merge queue's Windows platform gate fails for any PR that selects moq-relay, which dequeued #5913.

Approach

Gate the constant with #[cfg(unix)], matching its only use. Nothing else in the file is Unix-only dead code: EXTEND_INTERVAL drives an unconditional timer, and the other cfg(unix) blocks only set permissions on values used on every platform. The Windows job log reports only this warning.

Impact

  • Public API: none.
  • Wire: none.

Alternatives

  • Moving the value inline into the sd_notify call would drop the doc link from EXTEND_INTERVAL.
  • #[cfg_attr(not(unix), allow(dead_code))] keeps a constant that does nothing on Windows.

Follow-ups

  • acme::tests::failed_validations_stop_short_of_the_rate_limit hit its 30 s wall-clock bound in the same queue run; out of scope here.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

EXTEND_USEC is only read under #[cfg(unix)], so Windows builds flag it as
dead code and build.warnings fails the Windows platform gate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T07:53:54.942960Z 4608eed PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f0659f9a-7d40-4c6b-8aed-9a4c0a010d35
📥 Commits

Reviewing files that changed from the base of the PR and between ad87ad3 and 4608eed.

📒 Files selected for processing: 1
  • rs/moq-relay/src/acme.rs

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

The EXTEND_USEC constant is now compiled only on Unix. The existing sd_notify use remains Unix-gated.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 4608e

The change aligns the timeout constant with its Unix-only use and addresses the reported Windows warning. No remaining merge risk is evident.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description clearly explains the Windows warning, the Unix-only use of EXTEND_USEC, the proposed fix, and the impact. It is directly related to the changeset.
Title check Passed The title is concise and accurately identifies the main change: gating the systemd extension constant on Unix.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.98.1)

Clippy execution timed out

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: gates the Windows-dead EXTEND_USEC constant in rs/moq-relay/src/acme.rs with #[cfg(unix)], matching its only use, so the Windows platform gate in the merge queue stops failing for PRs that select moq-relay. No public API or wire impact. Codex reviewed head 4608eed with no findings; CI is green. The acme rate-limit test timeout noted in the description stays a follow-up. Enqueuing.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 21e33dd Oct 19, 2026
11 checks passed
@kixelated
kixelated deleted the fix/acme-windows-dead-code branch October 19, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant