Repository navigation
quest: scope the redundant failover promise; give the startup PES drop its own reason - #5964
Merged
Merged
Conversation
…reason Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to moq-dev/moq#5963, carrying the two Codex findings on its head (d5d2c94), which merged before these could be pushed.
quest/m0/broadcast-epoch/distinct-importer-epochs.md: the goal no longer promises that every consumer follows a failover. Only consumers that follow restarts (announcement-following players,moq export ts --stitch) move to the survivor; the rest end, as on any restart. (finding)quest/m1/ts-reliability/pes-import.md: the startup drop of a PES seen before the first PCR keeps its behavior, but its reason was same-epoch agreement, which no longer applies. It now gives a single-importer reason: nothing is published before acquisition anyway, PCRs arrive at least every 100 ms, so the loss is small, and one placement rule is simpler than back-extrapolation. (finding)quest checkpasses. Quests only.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code