Skip to content

quest: scope the redundant failover promise; give the startup PES drop its own reason - #5964

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/distinct-importer-epochs-fixes
Oct 19, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/distinct-importer-epochs-fixes

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Follow-up to moq-dev/moq#5963, carrying the two Codex findings on its head (d5d2c94), which merged before these could be pushed.

  • quest/m0/broadcast-epoch/distinct-importer-epochs.md: the goal no longer promises that every consumer follows a failover. Only consumers that follow restarts (announcement-following players, moq export ts --stitch) move to the survivor; the rest end, as on any restart. (finding)
  • quest/m1/ts-reliability/pes-import.md: the startup drop of a PES seen before the first PCR keeps its behavior, but its reason was same-epoch agreement, which no longer applies. It now gives a single-importer reason: nothing is published before acquisition anyway, PCRs arrive at least every 100 ms, so the loss is small, and one placement rule is simpler than back-extrapolation. (finding)

quest check passes. Quests only.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

…reason

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T18:00:22.481097Z 23ca6f6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 5225acf Oct 19, 2026
6 checks passed
@kixelated
kixelated deleted the quest-plan/distinct-importer-epochs-fixes branch October 19, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant