Repository navigation
fix(nix): select wasm-bindgen CLI from Cargo.lock #6031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c966998
chore(quest): claim wasm-bindgen pin
kixelated fe4dfd2
fix(nix): select wasm-bindgen CLI from Cargo.lock
kixelated 9f041ef
Merge origin/main into quest/m0/ci/wasm-bindgen-pin
kixelated 4a320b8
Merge origin/main into quest/m0/ci/wasm-bindgen-pin
kixelated 87144a5
Merge remote-tracking branch 'origin/main' into quest/m0/ci/wasm-bind…
kixelated ed72c43
chore(quest): drop the completed wasm-bindgen pin link
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the root
Cargo.lockadvances to another wasm-bindgen version, this switches the shell's global CLI whilebench/ffi-gen/Cargo.lockremains independently pinned.bench/ffi-gen/run.shbuilds its UniFFI WASM artifact with that second lockfile and then invokes the globalwasm-bindgen, so the next root-only bump will make the benchmark fail with the same schema mismatch this change is intended to prevent. Either derive that build from the root lock too or add an explicit synchronization guard for the nested lockfile.Useful? React with 👍 / 👎.