Repository navigation
perf(net): finish the m0 performance audit and restore the nightly bench legs #6112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
92ec0ec
chore: claim performance audit
kixelated 602fae7
fix(bench): check JS failover ownership through the resumed front
kixelated b1ffa02
fix(bench): keep lite announce diagnostics out of the broadcasts CSV
kixelated d2a9a8a
ci(bench): run every JS bench nightly
kixelated 99c372d
fix(bench): give feed fetch setup its own sim polls
kixelated 3d332e0
chore(quest): record third performance audit checkpoint
kixelated a515930
Merge remote-tracking branch 'origin/main' into audit-perf-resume
kixelated cd13ed5
perf(net): resolve a subscriber's servable window once, off the heap
kixelated bdb9aec
chore(quest): record the instruction-count attribution of the Oct 20 …
kixelated 2c15434
chore(quest): finish the m0 performance audit and plan its m1 successor
kixelated 86a614d
Merge branch 'main' of github.com:moq-dev/moq into audit-perf-resume
kixelated c76a88c
chore(quest): fix the successor's open regressions in its own run's PR
kixelated 18672af
Merge remote-tracking branch 'origin/main' into merge-6112
kixelated e7695fc
Merge remote-tracking branch 'origin/main' into merge-6112
kixelated e0d3c6f
Merge remote-tracking branch 'origin/main' into merge-audit-perf
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the number or size of warnings regresses, the nightly report will not record either value as a measurement:
javascript_filerecognizes only timing headers, sowarningsandbytesbecome dimensions in the series name, such asgroups=16/warnings=15/bytes=300/catchup_ms. A warning-traffic change therefore creates a new catch-up series instead of producing a comparable warning or byte data point, defeating this benchmark's stated purpose and preventing the trend report from flagging that regression. Extend the report parser/unit convention and name these columns as measurements rather than dimensions.AGENTS.md reference: AGENTS.md:L55-L55
Useful? React with 👍 / 👎.