Repository navigation
quest: plan follow-ups from the 2026-10-20 handoff #6116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
77c8853
4339c82
e95c1d3
2409bf6
1efd7e0
1bde809
ff954a4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # [M] Playwright browsers from Nix | ||
|
|
||
| ## Goal | ||
|
|
||
| Every Playwright check runs in the root devShell, locally on NixOS and in CI, | ||
| against the Chromium build that Nix provides. No check needs a hand-set | ||
| `LD_LIBRARY_PATH` or a `playwright install`, and no contributor doc tells | ||
| anyone to run one. | ||
|
|
||
| Inventory on `main` (2026-10-21). Recheck with `git grep -n -i chromium` | ||
| outside `quest/` and `test/smoke/`, keeping the hits that install, download, or | ||
| say where Chromium comes from (comments included), and with every | ||
| `package.json` that depends on `playwright`: | ||
|
|
||
| - Packages: `test/interop/clients/js`, `test/video`, `test/p2p`, `test/wasm`, | ||
| `test/audio-quality/clients/js`, `bench/browser`. | ||
| - Scripts: `test/interop/interop.sh`, `test/portrait/run.sh` (run in CI as | ||
| `just test portrait`), `test/wasm/run.sh`, | ||
| `test/audio-quality/{run,record}.sh`, `bench/browser/run.sh`, and the | ||
| `test/justfile` recipes. | ||
| - Workflows: `interop.yml`, `video.yml`, `wasm.yml`, `nightly.yml`, including | ||
| their comments that the devShell lacks Chromium. | ||
| - Docs and comments: `test/interop/README.md` (says the devShell lacks | ||
| Chromium), `test/wasm/README.md` (says to run | ||
| `bunx playwright install chromium`), `rs/justfile`'s browser clock recipe | ||
| (says `wasm.yml` installs it), `js/justfile`'s fairness sweep ("requires | ||
| installed Chromium"), and `test/video/renderer.browser.ts` (says | ||
| `just test video` installs it). | ||
|
|
||
| Out of scope: the Firefox player row, whose `media-firefox` job in | ||
| `nightly.yml` keeps installing its engines with `--with-deps`, and | ||
| `test/smoke`, which keeps its own flake on purpose. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-20 with the maintainer: | ||
|
|
||
| - **Nix browsers, with npm pinned to match.** Today each package pins npm | ||
| `playwright ^1.64`, and the Chromium it downloads cannot load | ||
| `libglib-2.0.so.0` on NixOS (found while landing the browser rename check). | ||
| The root devShell exports `PLAYWRIGHT_BROWSERS_PATH` from | ||
| `playwright-driver.browsers`, `PLAYWRIGHT_VERSION` from | ||
| `playwright-driver.version`, and `PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS`, | ||
| as `test/smoke/flake.nix` already does; without the last, Playwright's host | ||
| check rejects the Nix browser on NixOS. Every | ||
| package pins npm `playwright` to exactly that version, even when this | ||
| downgrades it (1.64 to nixpkgs' 1.63 today). The alternatives were rejected: | ||
|
Comment on lines
+46
to
+47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When this deliberately downgrades the workspace from Playwright 1.64 to 1.63, AGENTS.md reference: AGENTS.md:L30-L31 Useful? React with 👍 / 👎. |
||
| supplying host libraries to a downloaded Chromium (nix-ld or an FHS env) | ||
| depends on the host's library compatibility, and building playwright 1.64 | ||
| in the repo's overlay is maintenance for a gap nixpkgs closes on its own. | ||
| - **CI switches too.** Every workflow, script, and recipe in the inventory | ||
| drops its Chromium install, so CI and local runs share one Chromium. | ||
| - **The pin is enforced.** A check in `just check` fails when any package's | ||
| npm `playwright` differs from `PLAYWRIGHT_VERSION`, like | ||
| `test/smoke/freshness.sh`, so a nixpkgs bump cannot silently drift. | ||
|
Comment on lines
+51
to
+55
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: set -eu
printf '%s\n' '--- PR diff for quest/m1/playwright-nix.md ---'
git diff --unified=80 4576bb12313087b0e1ff20bca0cbfc7c395b00fa 1efd7e020ddef2ef376fe8d371c856f472bb4496 -- quest/m1/playwright-nix.md
printf '%s\n' '--- frozen lockfile references ---'
rg -n -F --glob '!target/**' --glob '!node_modules/**' 'bun install --frozen-lockfile' . || test "$?" -eq 1
printf '%s\n' '--- Playwright/version/lockfile references ---'
rg -n --glob '!target/**' --glob '!node_modules/**' -e 'PLAYWRIGHT_VERSION' -e 'playwright' -e 'bun.lock' -e 'package-lock.json' -e 'yarn.lock' -e 'pnpm-lock.yaml' . | head -n 300
printf '%s\n' '--- relevant top-level files ---'
find . -maxdepth 3 -type f \( -name 'package.json' -o -name 'bun.lock' -o -name 'bun.lockb' -o -name 'playwright.config.*' -o -name '*.yml' -o -name '*.yaml' \) -print | sort | head -n 300Repository: moq-dev/moq Length of output: 17428 🏁 Script executed: set -eu
printf '%s\n' '--- root package/workspace declarations ---'
nl -ba package.json | sed -n '1,100p'
printf '%s\n' '--- affected package manifests ---'
for f in test/p2p/package.json test/interop/clients/js/package.json test/video/package.json test/audio-quality/clients/js/package.json test/wasm/package.json bench/browser/package.json; do
printf '%s\n' "--- $f ---"
nl -ba "$f" | sed -n '1,45p'
done
printf '%s\n' '--- root lockfile playwright entries ---'
nl -ba bun.lock | sed -n '20,45p;410,435p;438,455p;465,485p;485,515p;1558,1572p'
printf '%s\n' '--- frozen install callers ---'
for f in test/interop/interop.sh test/wasm/run.sh test/justfile test/audio-quality/run.sh test/audio-quality/record.sh bench/browser/run.sh; do
printf '%s\n' "--- $f ---"
rg -n -C 3 -F 'bun install --frozen-lockfile' "$f" || test "$?" -eq 1
done
printf '%s\n' '--- plan lines ---'
nl -ba quest/m1/playwright-nix.md | sed -n '38,56p'
printf '%s\n' '--- lockfile tracking ---'
git ls-files --stage bun.lockRepository: moq-dev/moq Length of output: 15856 Include the root Bun lockfile in the pinning plan. When the package manifests change from Suggested plan update package pins npm `playwright` to exactly that version, even when this
downgrades it (1.64 to nixpkgs' 1.63 today). The alternatives were rejected:
+ Update the tracked root `bun.lock` with the same workspace and
+ `playwright`/`playwright-core` versions.🤖 Prompt for AI Agents |
||
| - The docs and comments in the inventory say the devShell provides Chromium. | ||
| No new user-facing docs: this changes only contributor tooling. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: moq-dev/moq
Length of output: 17090
State the
test/smokeexception in the goal.test/smokecontains Playwright checks. The current goal says every Playwright check uses the root devShell, but the scope excludestest/smokeand retains its separate flake. Scope the goal to checks outsidetest/smoke, or include the smoke flake in this migration.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents