Repository navigation
fix(moq-net): a subscriber reads only the frames its ranges cover #6129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dbcffd3
quest: claim m1/subscribe-ranges/frame-bounds
kixelated 1df6084
fix(moq-net): a subscriber reads only the frames its ranges cover
kixelated 9976a86
Merge remote-tracking branch 'origin/main' into frame-bounds-iterate
kixelated 33c5e00
style(moq-net): format the time-end frames case
kixelated ea6eb50
fix(moq-net): judge a datagram against one range at a time
kixelated 64e789f
fix(moq-net): bound a peeked group by the ranges at handout
kixelated f370a04
Merge remote-tracking branch 'origin/main' into frame-bounds-iterate
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When two requested ranges cover disjoint portions of the same group, collapsing them to their hull returns frames that neither range requested. For example, ranges
[group 4 frame 1, frame 2)and[group 4 frame 5, frame 6)produce bounds1..6, leaking frames 2 through 4 through both arrival and ordered reads. Preserve the disjoint intervals or filter individual frame reads instead of widening them to a hull.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining. A group is handed out once, as one run of frames, so a reader can't skip frames 2 through 4 inside it without a per-frame filter on
group::Consumerthat nothing else needs. The wire has the same shape: a lite group stream is one contiguous run, so a relay serving these two ranges sends the hull too, and the model matches what a remote subscriber would get. Two ranges splitting one group with a hole is also not a decodable request for media, where frames depend on earlier ones. Theframesdoc now says why it reads the hull. Datagrams, which carry their own Object ID, are now judged per range (see the other thread), so they do honor the hole.(Written by Claude Opus 5.5)