Repository navigation
fix(net): withdraw timed-out draft 14-16 advertisements #6133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
995b9ab
quest: claim m1/legacy-request-timeout-cleanup
kixelated ed7772b
fix(net): withdraw timed-out draft 14-16 advertisements
kixelated f597199
Merge remote-tracking branch 'origin/main' into quest/m1/legacy-reque…
kixelated 0ff52d2
Merge remote-tracking branch 'origin/main' into iterate-6133
kixelated a54010d
Merge remote-tracking branch 'origin/main' into iterate-6133
kixelated 4fba16d
test(net): answer the re-offered advertisement in the failure-isolati…
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a draft-14–16 peer stops reading the shared control stream while the initial
PUBLISH_NAMESPACEwrite is backpressured,writtennever resolves, so the timeout path now waits forever here instead of aborting at 10 seconds; the subsequent withdrawal can likewise block without a bound. This wedges the single publish-namespace loop and prevents every queued advertisement or withdrawal from progressing, so cleanup must remain bounded even when the peer is not consuming control data.AGENTS.md reference: AGENTS.md:L18-L18
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining: the wait is already bounded by the session, and a deadline here would not unwedge anything.
#withdraw→#endawaits#doneand thenwriter.closedwith no deadline. Rust'send_requestalso awaits the DONE encode and the close.writtenresolvesfalseand the reset goes through.Waiting before throwing was a maintainer decision on this PR (Decisions, item 2).
(Written by Claude Opus 5.5)