Repository navigation
quest: plan the release shutdown backport #6134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1daa956
quest: plan the release shutdown backport
kixelated 864e7bc
Merge remote-tracking branch 'origin/main' into quest/m0/ffi-shutdown…
kixelated 4e8c845
quest: cover every FFI binding and publication in the shutdown backport
kixelated 2005051
quest: gate the stream-limit backport on qmux 0.5.3
kixelated f05a2fe
Merge remote-tracking branch 'origin/main' into quest/m0/ffi-shutdown…
kixelated 7bdc885
quest: qualify the drain guarantee and publish the wrappers
kixelated 0528c3a
Merge remote-tracking branch 'origin/main' into quest/m0/ffi-shutdown…
kixelated 0128af2
quest: leave the Go wrapper version to CI
kixelated 3acc33d
Merge origin/main into quest/m0/ffi-shutdown-backport
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # [S] Backport draining shutdown and the qmux stream limit to release | ||
|
|
||
| ## Goal | ||
|
|
||
| The `release` line publishes a non-breaking moq-ffi 0.4.x (wheel, Swift, and | ||
| Kotlin) and moq-tokio whose sessions can drain before closing and whose qmux | ||
| sessions accept the QUIC stream limit: | ||
|
|
||
| - An async `MoqSession.drain()` drains finished tracks within one second | ||
| and returns any delivery error, as `main`'s async `shutdown()` does | ||
| (7bbac3272, with 03fb0d1c1, f9de31167, and #5558's explicit Lite 07 test). | ||
| Explicit `moq-lite-07-wip` waits for the peer to receive the tail; older | ||
| Lite versions, including the default lite-06, and IETF wait only for | ||
| transport ACKs. The sync `shutdown()` stays `cancel(0)`. | ||
| - qmux sessions get the QUIC stream limit (#5609) instead of the 100-stream | ||
| default. | ||
|
|
||
| Check: release-plz publishes the release commits, and the newest moq-ffi on | ||
| PyPI, the Swift package, and Maven Central contains both. Swift and Kotlin | ||
| publish from their own tag workflows, so check each. The newest hand-written | ||
| wrappers (`moq-rs`, the Swift and Kotlin libraries, and the other wrappers | ||
| that gain `drain()`) expose it too. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-20 (maintainer): additive `drain()` on `release` rather than | ||
| backporting async `shutdown()` as-is. Why: making `shutdown()` async breaks | ||
| the 0.4.x Python, Swift, and Kotlin bindings. `main` keeps async `shutdown()` | ||
| and gains no `drain()`; callers move to it at the next breaking cut. | ||
|
|
||
| Decided 2026-10-20 (maintainer): keep #5609 in the backport, on a qmux | ||
| 0.5.3 published from web-transport's `qmux-v0.5.x`. Why: `release` locks | ||
| qmux 0.5.2, which lacks the builder session config #5609 uses, and | ||
| moq-dev/web-transport#427 already carries that config for 0.5. | ||
|
|
||
| Follow the backport workflow. #5609 moves `release` to qmux 0.5.3 and takes | ||
| its builder session config instead of 0.6.3's. The drain backport | ||
| adapts 7bbac3272's session close to the `release` line's moq-net and keeps | ||
| its tests, renamed to `drain()`. Follow the Cross-Package Sync row for | ||
| `rs/moq-ffi`: every binding and its docs gain `drain()`, or the PR says why | ||
| one has none. Wrapper workflows skip versions already published, so bump | ||
| each changed wrapper's human-owned version (CONTRIBUTING's Versions). Leave | ||
| `go/wrapper/VERSION` alone: CI derives Go's patch, and `drain()` is | ||
| additive. Run each binding's tests and `just test interop --all`. The | ||
| qmux credit fix is out of scope: it arrives with | ||
| [qmux on the QUIC stream state machine](/quest/m1/quic-qmux.md). | ||
|
|
||
| Public API: additive (`MoqSession.drain()` and its binding wrappers). Wire: | ||
| none. | ||
|
|
||
| ## Required | ||
|
|
||
| - [qmux 0.5.3](/quest/m0/qmux-0.5.3.md) - crates.io publishes qmux 0.5.3 with the builder session config #5609 needs | ||
|
|
||
| ## Related | ||
|
|
||
| - [Release builds link](/quest/m0/release-link.md) - the release binaries | ||
| must link for the cut that publishes this | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # [XS] Publish qmux 0.5.3 | ||
|
|
||
| ## Goal | ||
|
|
||
| crates.io carries qmux 0.5.3 with moq-dev/web-transport#427, the builder | ||
| session config the `release` line needs to port #5609. A maintainer | ||
| publishes it; delete this quest once it is on crates.io. | ||
|
|
||
| Check: `cargo info qmux@0.5.3` resolves, and the `qmux-v0.5.3` tag on | ||
| moq-dev/web-transport contains #427's merge. | ||
|
|
||
| ## Plan | ||
|
|
||
| Waiting on a maintainer. #427 merged on web-transport's `qmux-v0.5.x`, which | ||
| has no release-plz, so the publish is manual: one commit bumps qmux to 0.5.3 | ||
| with a CHANGELOG entry, then `cargo publish -p qmux` and push the | ||
| `qmux-v0.5.3` tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.