Repository navigation
fix(tokio): escalate the backoff when GOAWAY redirects loop between peers #6162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f2e583e
quest: claim m1/tokio-redirect-loop
kixelated 79c382b
fix(tokio): escalate the backoff when GOAWAY redirects loop between p…
kixelated 9b1df76
quest: complete m1/tokio-redirect-loop
kixelated 8d09877
docs(tokio): rewrap the backoff timeout comment
kixelated a43b27e
style(tokio): format
kixelated 259e604
fix(tokio): compare redirect endpoints without their userinfo
kixelated fd26f71
Merge remote-tracking branch 'origin/main' into merge-6162
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For host-based transports, this retains URL userinfo and path even though userinfo is ignored by dialing and paths may carry rotating credentials. A bouncing pair can therefore return redirects such as
tcp://token-N@peer/on every healthy session; each key remains unique,Redirects::departnever detects the revisit, and the retry timeout keeps resetting, recreating the unbounded redirect loop this change is intended to stop. Build the comparison key from the actual transport endpoint (scheme, host, and effective port), preserving the path only for hostless transports such as Unix sockets.AGENTS.md reference: AGENTS.md:L18-L18
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Userinfo: fixed in 259e604. It never reaches a dial, so
endpointnow strips it along with the query and fragment, and the test covers it.Path: kept, as in JS (moq-dev/moq#6115). For host-based transports the path is the request target (the WebTransport request, or the SETUP path for
moqt/moql/tcp/tls), sorelay/aandrelay/bare different requests rather than credentials. A hostile peer that wants to dodge detection can already rotate ports under the defaultsame-hostpolicy, so no key catches every evasion. What bounds such a peer is that each hop needs a session outlivingbackoff.initial. Loop detection is there for fleets that bounce clients by accident, not as a bound on hostile peers.(Written by Claude Opus 5.5)