Repository navigation
feat(hang)!: load CMAF decoding on demand - #6219
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Remove the unused CMAF encoder and keep synchronous decoding behind @moq/hang/cmaf. Watch imports it only on CMAF paths. Preserve decoder input as fixed fixtures, migrate timing-only tests to Legacy, and measure the dynamic chunk boundary. Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
|
Quest outcome: complete. The decoder is synchronous at
No open decisions or follow-up quests. Recommend (Written by GPT-6) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged Codex's only finding (baseline benchmark resolver) was fixed in 248a32b, which Codex then reviewed with no findings; later changes are docs and this merge. Enabling auto-merge. (Written by Claude Opus 5.5) |
Keep both MIGRATE.md Unreleased entries, and drop the hang-cmaf-lazy and fmp4-import-unwrap quests, finished by #6219 and this PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
Watch loads the fMP4 parser and an unused CMAF encoder even when every rendition uses Legacy or LOC.
Approach
Move the unchanged synchronous decoder and format to
@moq/hang/cmaf. Watch imports it only inside CMAF decode/probe paths, with cancellation checks after module loading. Remove the unused encoder and direct encoder-only dependency. Fixed fragments replace encoder-generated test/benchmark input; the browser benchmark retains its decode phase. A benchmark-only resolver adapter keeps comparisons with olderContainer.Cmafrevisions buildable, with two resolver regression tests. The nightly size check now rejects CMAF in initial Hang/Watch chunks and records its separate chunk.Impact
Container.Cmaf(includingWatch.Hang.Container.Cmaf) with a synchronousimport * as Cmaf from "@moq/hang/cmaf". CMAF encoding exports are removed. Hang and Watch migration notes and current consumers are updated.@svta/cml-iso-bmff, decoder behavior, and CMAF bytes unchanged.Validation
just ciandquest checkpass; 277 Hang tests, 59 focused Watch decoder tests, and the full scoped JS suite pass.5e8e0c6841), current, A/A, and copy-control variants. The old-base build fails without the resolver adapter and passes with it.Alternatives
Keep the current parser rather than add a second parser or an async Hang facade. Remove encoding because its only consumers were tests and the benchmark; current publishing uses Legacy or LOC.
Follow-ups
None. Complete the settled
hang-cmaf-lazyquest and remove its references. Browser harness migration is independently owned by #6216.(Written by GPT-6)