Repository navigation
quest: plan the main-vs-release performance regressions #6225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f22df58
28bed4e
31b1945
41e01a2
3df8374
6042ebb
fa13b78
d146314
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # [S] Release resubscribe hang | ||
|
|
||
| ## Goal | ||
|
|
||
| It is settled whether `release` has a moq-lite-06 bug where a subscription that | ||
| is closed and reopened never reaches the relay. If the bug is real, a fix with | ||
| a regression test is backported to `release`, which moq.pro runs. If it is a | ||
| harness artifact, the reason is recorded and this quest is deleted. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found while backporting main's benches to `release` in | ||
| [#6103](https://github.com/moq-dev/moq/pull/6103): `session_churn_*/moq-lite-06` | ||
| hangs on `release`. After one subscription opens and closes, the reopened | ||
| subscription never reaches the relay. The same bench passes on main. | ||
|
|
||
| 1. Reproduce it on `origin/release` as a session test (one subscriber; open, | ||
| close, and reopen the same track through a relay). Mock time, not sleeps. | ||
| 2. If it hangs, find the cause. Land the test on main first, per the | ||
| main-first backport rule in `CONTRIBUTING.md`, then port it to `release` | ||
| in a separate PR. If main fixed the bug, bisect for that fix and port it | ||
| with the test. If main never had it (the code diverged), the `release` PR | ||
| carries the minimal fix for code that no longer exists on main. | ||
| 3. If the test passes on `release`, the bench harness's backport is at fault | ||
| (release's `tests/support` mock differs from main's). Record that in the PR | ||
| and delete this quest. | ||
|
Comment on lines
+24
to
+26
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: sed -n '1,80p' quest/m0/release-resubscribe-hang.md
printf '\n--- cited benchmark ---\n'
sed -n '930,1085p' rs/moq-net/benches/session.rs
printf '\n--- churn references and test support ---\n'
rg -n -i -C 5 'session_churn|moq-lite-06|resub|reopen|tests/support|mock' rs quest 2>/dev/nullRepository: moq-dev/moq Length of output: 45665 🏁 Script executed: set -o pipefail
printf '%s\n' '--- quest ---'
nl -ba quest/m0/release-resubscribe-hang.md | sed -n '1,32p'
printf '%s\n' '--- benchmark churn definitions and call sites ---'
nl -ba rs/moq-net/benches/session.rs | sed -n '850,1070p'
rg -n -F -- 'churn(' rs/moq-net/benches/session.rs
rg -n -F -- 'Churn {' rs/moq-net/benches/session.rs
printf '%s\n' '--- support files ---'
rg --files rs/moq-net | rg '(^|/)(tests/support|support)(/|\.|$)|harness'
printf '%s\n' '--- support mock references ---'
rg -n -F --glob '*.rs' -e 'struct Mock' -e 'MockPair' -e 'connect_mock' -e 'moq_clock' rs/moq-net/tests rs/moq-net/benches | sed -n '1,240p'
printf '%s\n' '--- revision availability ---'
for rev in d146314ed5bdefe9ee5fea82fac5ec3e631b50eb bce217e063bcb98919e9b4f8bb5122cf1a62e805 release main 0c56e5b4e 8b0d9952f; do
if git rev-parse --verify "$rev^{commit}" >/dev/null 2>&1; then
printf '%s: %s\n' "$rev" "$(git rev-parse "$rev^{commit}")"
else
printf '%s: unavailable\n' "$rev"
fi
done
printf '%s\n' '--- support diff if release/main refs are available ---'
if git rev-parse --verify release^{commit} >/dev/null 2>&1 && git rev-parse --verify main^{commit} >/dev/null 2>&1; then
git diff --no-ext-diff --unified=30 release:rs/moq-net/tests/support main:rs/moq-net/tests/support || true
else
printf '%s\n' 'release or main ref unavailable'
fiRepository: moq-dev/moq Length of output: 33846 Do not delete the quest after a one-subscriber pass. The planned test covers one subscriber and no held subscriptions. The cited benchmark also runs multiple sessions and keeps held subscriptions open. A passing narrower test cannot establish that the harness is at fault. Require the failing benchmark workload, or compare the 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| # Main is no slower than release | ||
|
|
||
| ## Goal | ||
|
|
||
| Before the next release cut, every benchmark where `main` is slower than | ||
| `release` is either fixed or accepted with a recorded reason. Accidental cost | ||
| is fixed. Cost that pays for a feature `main` deliberately added is accepted, | ||
| and the reason is written here. | ||
|
|
||
| This epic's own work: once every child has landed, run the full main against | ||
| release comparison again with `just bench origin/release`, and confirm nothing | ||
| new regressed. Then add a release-baseline step to the recurring | ||
| [performance audit](/quest/m1/audit-perf.md), so every later cut | ||
| repeats this comparison. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-21, when planning from a paired comparison of `release` | ||
| (`0c56e5b4e`, which included the bench backport | ||
| [#6103](https://github.com/moq-dev/moq/pull/6103)) against `main` | ||
| (`8b0d9952f`). The run used 811 paired Criterion cases, three alternating | ||
| confirmation rounds for the largest moves, JS on bun, and the relay load | ||
| harness. It ran on a shared 8-core host, so a small wall-time change may be | ||
| noise. | ||
|
|
||
| - The epic gates the cut through the [m1 milestone](/quest/m1/README.md), | ||
| because `main` must not ship slower than `release` without a decision. | ||
| - In scope: the five cases that held through confirmation, plus the large | ||
| screen-only moves. The screen-only moves are re-measured with callgrind | ||
| instruction counts, and any that hold are fixed. | ||
| - Only accidental cost is fixed. Cost from an intended feature is accepted, | ||
| and the reason is recorded here. | ||
| - The IETF `/fetch` rows of `session_delivery_group_cost` are accepted and | ||
| dropped from release pairing. They measure different work on each branch: | ||
| release's bare track handle opened a live SUBSCRIBE, while main sends a real | ||
| FETCH per viewer ([#5820](https://github.com/moq-dev/moq/pull/5820) made | ||
| handles lazy, and [#4974](https://github.com/moq-dev/moq/pull/4974) added | ||
| fetch-only demand). The lite `/fetch` cost is different: it is real, and | ||
| [FETCH fan-out](/quest/m1/release-perf/fetch-fanout.md) owns it. | ||
| - `stats/session-report` is accepted at O(live sessions), after a cheap fix. | ||
| Per-label payload bytes ([#5731](https://github.com/moq-dev/moq/pull/5731)) | ||
| match payload billing per label, such as per signing key. The drain runs | ||
| once a second, using under 0.01% of a core at 10,000 sessions. Deleting | ||
| those bytes was rejected. | ||
|
|
||
| ### Release as a baseline | ||
|
|
||
| `release` lacks many of the features the backported benches exercise: | ||
| per-reader delivery records, wall-clock aging, the gap ledger, rewind checks, | ||
| and epochs. So a ratio against `release` shows where to look, not what to fix. | ||
| Main's own sweeps over a size parameter are the better regression signal: a | ||
| cost that grows with the sweep is accidental, while a flat per-operation cost | ||
| usually pays for a feature. | ||
|
|
||
| ### Confirmed (three rounds, ratio is main / release) | ||
|
|
||
| | Bench | release | main | Ratio | Owner | | ||
| |---|---|---|---|---| | ||
| | `track_gap_flush/4096` | 5.7 us | 551 us | 96x | [Sparse gaps](/quest/m1/release-perf/sparse-gaps.md) | | ||
| | `track_gap_flush/512` | 1.8 us | 48 us | 27x | same | | ||
| | `track_gap_flush/64` | 1.5 us | 6.2 us | 4.1x | same | | ||
| | `stats/session-report/1000x10` | 11.0 us | 86.8 us | 7.9x | [Stats report](/quest/m1/release-perf/stats-report.md) | | ||
| | `track_gc/idle/16384` | 11.6 ns | 73.7 ns | 6.3x | [Idle GC](/quest/m1/release-perf/gc-idle.md) | | ||
| | `origin/resume_overlap/sequence/1r_64g_32c` | 93 us | 426 us | 4.6x | [Resume duplicates](/quest/m1/release-perf/resume-duplicates.md) | | ||
| | `session_delivery_group_cost/moq-transport-22/.../viewers=64/.../fetch` | 1.19 ms | 3.86 ms | 3.2x | accepted (above) | | ||
| | `group_write_frames/single/8192` | 424 us | 486 us | 1.17x | [Re-check](/quest/m1/release-perf/recheck.md) | | ||
|
|
||
| Main is much faster on subscriber churn, joins, range demand, and idle | ||
| sessions (by 100x to 3000x). The relay load test used 21% less CPU on video | ||
| and 12% less on fanout, with the same delivery. | ||
|
|
||
| ### Screen only (one run, unconfirmed) | ||
|
|
||
| - moq-mux: `container-export/ts/4x1` 4.7x and `mkv/4x1` 3.9x (median 1.41x | ||
| over 27 cases); `annexb-import-{bytes,frames}` median 2.1x (up to 3.6x). | ||
| - moq-net track: `track_stamp_groups` median 2.7x (4.7x at `sparse/4096`), | ||
| `track_sparse_read/timed/4096` 4.3x, `track_datagram_subscriber_join` | ||
| median 2.3x, `track_parallel_write` 1.6x, `track_fanout_frame` 1.42x, | ||
| `track_empty_run` median 1.36x. | ||
| - moq-net origin and session: `origin/announce_duplicate/30d_1s` 4.3x, | ||
| `session_delivery_relays` median 1.56x, `paced` 1.45x, `scale` 1.43x. | ||
| - moq-stats `aggregate` at live=16, departed=4096: 2.1x. The other rows were | ||
| 1.0 to 1.3x, so this one is probably noise. | ||
| - kio `contended_notify` and `contended_log` at 16 threads: 4 to 5x. These | ||
| are contention benches on a busy host, so they are likely noise. | ||
| - JS `net/bench/frames.ts` on bun: lite rows 1.2 to 1.3x, IETF rows 1.3 to | ||
| 2.2x ([JS frames](/quest/m1/release-perf/js-frames.md)). | ||
|
|
||
| The raw report lived in a scratch directory that has since been removed. The | ||
| [comparison harness](/quest/m1/release-perf/compare-harness.md) keeps the next | ||
| one. | ||
|
|
||
| ## Required | ||
|
|
||
| - [FETCH fan-out](/quest/m1/release-perf/fetch-fanout.md) - a relay serves later viewers' lite FETCHes of a group from its cache, so per-viewer cost falls with viewers again | ||
| - [Sparse gaps](/quest/m1/release-perf/sparse-gaps.md) - an arrival and a gap flush cost O(log gaps), not O(gaps) | ||
| - [Resume duplicates](/quest/m1/release-perf/resume-duplicates.md) - an ordered resume skips copies of an already-delivered group without consuming them | ||
| - [Idle GC](/quest/m1/release-perf/gc-idle.md) - an idle track GC skips the wall-clock pass when nothing is due | ||
| - [Stats report](/quest/m1/release-perf/stats-report.md) - the stats drain locks each row once and its bench counts the wire walk; per-label bytes stay, at an accepted O(live sessions) | ||
| - [Re-check](/quest/m1/release-perf/recheck.md) - the screen-only moves are re-measured with instruction counts, and the ones that hold are fixed or accepted | ||
| - [JS frames](/quest/m1/release-perf/js-frames.md) - the js/net frame path is no slower than release in a browser, or the gap is accepted | ||
| - [Comparison harness](/quest/m1/release-perf/compare-harness.md) - `just bench <base>` pairs full Criterion IDs and keeps its report | ||
|
|
||
| ## Related | ||
|
|
||
| - [Performance audit](/quest/m1/audit-perf.md) - compares nightly to nightly; this epic compares main to release | ||
| - [Benchmark regressions in CI](/quest/m2/bench-ci.md) - PR-time comparison against the base branch |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # [S] Comparison harness | ||
|
|
||
| ## Goal | ||
|
|
||
| `just bench <base>` (`bench/run.sh`) pairs every Criterion case by its full | ||
| ID, and writes its report somewhere that survives the worktree. The | ||
| [epic](/quest/m1/release-perf/README.md)'s final main against release run | ||
| uses it without hand-written joins. | ||
|
|
||
| ## Plan | ||
|
|
||
| `bench/run.sh` discovers cases from `cargo bench -- --list`, which truncates | ||
| display titles at 100 characters. That loses long `session_*` IDs. The | ||
| 2026-10-21 run worked around it by joining the saved `benchmark.json` | ||
| `full_id` values instead (`run.sh` already reads them after the run). Discover | ||
| and pair cases from those full IDs. | ||
|
|
||
| The same run kept its report in another worktree's `.scratch/`, and lost it | ||
| when that worktree was removed. Write the report under a path the caller | ||
| chooses. Default to the current worktree's `.scratch/`, and print its path at | ||
| the end. A durable copy belongs with the epic's final run, not in the repo. | ||
|
Comment on lines
+18
to
+21
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: sed -n '1,140p' quest/m1/release-perf/compare-harness.md
printf '\n--- epic requirements ---\n'
sed -n '1,130p' quest/m1/release-perf/README.md
printf '\n--- durability/report references ---\n'
rg -n -i -C 5 'scratch|durab|worktree|report|final run|paired run|caller|path' quest/m1 quest/m2 2>/dev/nullRepository: moq-dev/moq Length of output: 45655 Make the default report path durable. The harness goal applies to every Suggested wording-Write the report under a path the caller chooses. Default to the current
-worktree's `.scratch/`, and print its path at the end. A durable copy belongs
-with the epic's final run, not in the repo.
+Write the report under a path the caller chooses. Default to a durable path
+outside the current worktree, and print its path at the end. The epic's final
+run must retain its report outside the repository.🤖 Prompt for AI Agents |
||
| Extend `bench/compare.test.py` to cover a case ID longer than 100 characters. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # [M] FETCH fan-out | ||
|
|
||
| ## Goal | ||
|
|
||
| When many viewers FETCH the same group through a relay over moq-lite, the | ||
| relay fetches it upstream once and serves later viewers from its cache. Cost | ||
| per viewer falls as viewers grow, as it does on `release`. | ||
|
|
||
| ## Plan | ||
|
|
||
| Measured 2026-10-21 (`session_delivery_group_cost/.../fetch` on lite-06, | ||
| cost per viewer): | ||
|
|
||
| | Viewers | release | main nightly | | ||
| |---|---|---| | ||
| | 1 | 57 us | 67 us | | ||
| | 16 | n/a | 61 us | | ||
| | 64 | 16.5 us | 59 us | | ||
|
|
||
| Main's non-fetch path still amortizes (55 us down to 34 us), so on main every | ||
| viewer's FETCH appears to cost as much as the first. The relay seems to go | ||
| upstream or rebuild state for each fetch. Lite's `IDLE_LINGER` should keep | ||
| the relay's copy and cache, so a simple "the track was dropped" explanation is | ||
| not enough. | ||
|
|
||
| 1. Reproduce first. Count the upstream FETCHes the publisher session sees in | ||
| each round. One per group means the cache works and the cost is elsewhere. | ||
| One per viewer means the cache is bypassed. | ||
| 2. If it is bypassed, compare callgrind instruction counts at the parents of | ||
| the suspects. The likely fix is for the relay's FETCH serve to resolve its | ||
| track once and reuse the lingering copy. Suspects: | ||
| [#5820](https://github.com/moq-dev/moq/pull/5820) (the relay's FETCH serve | ||
| resolves `broadcast.track(..).fetch_group` per request), | ||
| [#5809](https://github.com/moq-dev/moq/pull/5809) (a fetch keeps its track | ||
| read), [#5680](https://github.com/moq-dev/moq/pull/5680) (fetch age | ||
| budgets; the bench advances the cache clock 1 s per round), and | ||
| [#6020](https://github.com/moq-dev/moq/pull/6020) (one writer per group). | ||
| 3. Land a regression test that asserts one upstream FETCH per group across | ||
| many viewers. Also check that the `session_delivery_group_cost` lite | ||
| `/fetch` sweep over viewers slopes down again. | ||
|
|
||
| A relay that fetches upstream once per viewer turns N viewers into N upstream | ||
| requests. If step 1 confirms that, raise the priority with the maintainer, | ||
| since m0 bounds what a peer can make the relay do. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # [S] Idle GC | ||
|
|
||
| ## Goal | ||
|
|
||
| `track::Pool::advance` with nothing due does no clock read, lock, or waker | ||
| registration. `track_gc/idle` returns to a few nanoseconds. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found by reading code on 2026-10-21 (11.6 ns to 74 ns, flat across sizes, | ||
| confirmed). [#5548](https://github.com/moq-dev/moq/pull/5548) (wall-clock | ||
| aging of superseded groups) added the following to every `advance` in | ||
| `rs/moq-net/src/model/cache.rs`: | ||
|
|
||
| - the `wall_epoch` `OnceLock` and a `wall_micros.fetch_max`; | ||
| - `release_due(self.now_wall(), driver)`, which reads `moq_clock::now()`; | ||
| - the `inner.wall` lock and `driver.register`. | ||
|
|
||
| Part of the cost is the bench itself: it builds a fresh `kio::Waiter::noop()` | ||
| on every iteration, so each `register` allocates and frees an `Arc<Waker>`. A | ||
| real driver reuses its waiter. Hoist the waiter out of `b.iter` first, and | ||
| measure what remains. | ||
|
|
||
| Fix: keep the earliest wall deadline in an atomic, as `expiry.rs` already | ||
| does with `earliest`. Read `now_wall()` and take the lock only when that | ||
| deadline has passed. Time decisions use `max(wall, pts)`; keep that behavior. | ||
|
Comment on lines
+24
to
+26
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚀 Performance & Scalability | 🟡 Minor | ⚡ Quick win Make the fast-path goal match the proposed algorithm. The Goal says idle 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # [M] JS frames | ||
|
|
||
| ## Goal | ||
|
|
||
| The js/net frame path (`js/net/bench/frames.ts`) is no slower than | ||
| `release` when measured in a browser, or the gap is accepted with a reason | ||
| recorded in the [epic](/quest/m1/release-perf/README.md). | ||
|
|
||
| ## Plan | ||
|
|
||
| On bun (2026-10-21), the lite rows were 1.2 to 1.3x slower and the IETF rows | ||
| 1.3 to 2.2x. JS perf is judged in a browser, so measure there first, against | ||
| `release` (the bench file is the same on both branches). | ||
|
|
||
| Leads from reading code: | ||
|
|
||
| - Lite and IETF: [#4226](https://github.com/moq-dev/moq/pull/4226) turned | ||
| `Signal.race` into the lazy `Changed` class. Each wait allocates a `Changed`, | ||
| the `then` getter builds an extra Promise, and `#finish` adds a microtask | ||
| hop. Every reader wake in `group.ts` `#changed()` pays for all of that. | ||
| Resolve listeners synchronously when the winner is not a thenable, and add a | ||
| race-heavy case to `js/signals/bench/effect.ts`. | ||
| - IETF: per-group `track.writeGroup` to `ordered.nextGroup` cost. Candidates | ||
| are [#5803](https://github.com/moq-dev/moq/pull/5803), | ||
| [#5725](https://github.com/moq-dev/moq/pull/5725), | ||
| [#5836](https://github.com/moq-dev/moq/pull/5836), | ||
| [#5930](https://github.com/moq-dev/moq/pull/5930), and the eager `new Error()` | ||
| plus `FinalizationRegistry` per `Effect` from | ||
| [#4876](https://github.com/moq-dev/moq/pull/4876), if a path creates | ||
| Effects per group. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # [M] Re-check | ||
|
|
||
| ## Goal | ||
|
|
||
| Every screen-only move in the [epic](/quest/m1/release-perf/README.md) is | ||
| re-measured with instruction counts. Each one that holds is fixed in this | ||
| quest's PR, one commit per fix, or accepted with a reason recorded in the | ||
|
Comment on lines
+6
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When several screen-only regressions hold, this requires fixing all of them in one PR even though the candidates span unrelated moq-mux, moq-net, moq-stats, and kio paths. Keeping one commit per fix does not preserve review focus, especially because main PRs are squash-merged; create a focused quest/PR for each independently landable cause instead. AGENTS.md reference: AGENTS.md:L22-L24 Useful? React with 👍 / 👎. |
||
| epic. | ||
|
|
||
| ## Plan | ||
|
|
||
| Use the instruction-count method from the [performance audit](/quest/m1/audit-perf.md). | ||
| Wall time on a shared host can't tell these apart. Build each bench at | ||
| `origin/release` and at main, and compare instructions per iteration. A | ||
| change that needs a maintainer decision, or is too large to review alongside | ||
| the rest, becomes a follow-up through `/quest-plan`. | ||
|
|
||
| Leads from reading code on 2026-10-21, strongest first: | ||
|
|
||
| 1. moq-mux `container-export/{ts,mkv}/4x1` (4.7x, 3.9x). The worst ratio is at | ||
| one frame per track, so look for a fixed cost per export or per track. The | ||
| reap cost from [#5942](https://github.com/moq-dev/moq/pull/5942) that the | ||
| audit found grows with buffered groups instead. Suspects: every export now | ||
| goes through `jitter::Buffer` | ||
| ([#4645](https://github.com/moq-dev/moq/pull/4645), | ||
| [#5309](https://github.com/moq-dev/moq/pull/5309)), and `container/source.rs` | ||
| start-up ([#5947](https://github.com/moq-dev/moq/pull/5947), | ||
| [#5854](https://github.com/moq-dev/moq/pull/5854)). If the jitter path | ||
| dominates, skip it when the delay is zero. | ||
| 2. `annexb-import` (median 2.1x). Check `group_*` and `append_group` first. If | ||
| they regressed by the same factor, the cost is per group in moq-net | ||
| ([#5803](https://github.com/moq-dev/moq/pull/5803) rewind check, | ||
| [#5725](https://github.com/moq-dev/moq/pull/5725) largest notifications, | ||
| [#6020](https://github.com/moq-dev/moq/pull/6020)), not in the importer. | ||
| 3. `track_stamp_groups` (median 2.7x). The first frame on a timed track now | ||
| takes the track lock and `bounds`, `starts`, and `sequence` mutexes | ||
| ([#5803](https://github.com/moq-dev/moq/pull/5803), | ||
| [#6074](https://github.com/moq-dev/moq/pull/6074)). Pass the checked start | ||
| into `first_frame`, merge `bounds` and `starts` under one lock, and skip | ||
| `advance_largest`'s write and wake when nothing changed. | ||
| 4. `track_datagram_subscriber_join` (median 2.3x). `Cursor::new` scans the | ||
| datagram ring twice ([#5195](https://github.com/moq-dev/moq/pull/5195)). | ||
| Track the newest datagram timestamp on push. The window's construction cost | ||
| from [#5929](https://github.com/moq-dev/moq/pull/5929) was cut in | ||
| [#6112](https://github.com/moq-dev/moq/pull/6112), and the rest belongs to | ||
| [Allocation-free single-range subscriber window](/quest/m1/window-alloc.md). | ||
| 5. `track_parallel_write`, `track_fanout_frame`, `track_empty_run`, | ||
| `group_write_frames` (1.2 to 1.6x). This is constant per-group and | ||
| per-frame cost from several features. Resolve `now` once per poll in | ||
| `Drift`, and skip no-op `advance_largest` writes. Accept the rest. | ||
| 6. `origin/announce_duplicate/30d_1s` (4.3x). Compare against `1d_1s`, to | ||
| tell a constant cost per change from a cost per duplicate. Leads: an | ||
| epochless winner switch is now a `Restart` | ||
| ([#5087](https://github.com/moq-dev/moq/pull/5087), | ||
| [#5443](https://github.com/moq-dev/moq/pull/5443), | ||
| [#4942](https://github.com/moq-dev/moq/pull/4942), | ||
| [#5144](https://github.com/moq-dev/moq/pull/5144)). | ||
| 7. `session_delivery_{relays,paced,scale}` (1.4 to 1.6x). Expected to be the | ||
| per-group cost above plus the flow-controlled mock transport | ||
| ([#5530](https://github.com/moq-dev/moq/pull/5530)). Re-measure after the | ||
| fixes above, and accept what remains. | ||
| 8. moq-stats `aggregate` at live=16, departed=4096, and kio | ||
| `contended_{notify,log}` at 16 threads: confirm they are noise. If the | ||
| aggregate row holds, suspect [#4874](https://github.com/moq-dev/moq/pull/4874) | ||
| and [#4904](https://github.com/moq-dev/moq/pull/4904). | ||
|
|
||
| Add a bench sweep wherever a fix removes a slope, so the slope stays visible. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: moq-dev/moq
Length of output: 45665
🏁 Script executed:
Repository: moq-dev/moq
Length of output: 14548
Clarify the exception to the main-first backport rule.
CONTRIBUTING.mdrequires every serious fix, including a fix reported againstrelease, to land onmainbefore a separate backport. The quest instead permits a release-only fix when the code diverged. The surrounding release guidance preserves release-only commits but does not define an exception to this rule. Explain how the main-first step applies, or document an approved exception before directing the release-only fix.🤖 Prompt for AI Agents