Skip to content

fix(net): omit URL userinfo from reconnect endpoint keys - #6226

Merged
kixelated merged 3 commits into
mainfrom
quest/m1/js-reload-userinfo
Oct 22, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m1/js-reload-userinfo

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

A GOAWAY redirect loop can rotate URL usernames/passwords on every hop and evade JS reconnect backoff, because its endpoint key retains userinfo. Rust already strips it.

Approach

Clear username and password on the cloned endpoint key alongside query and fragment, matching #6162. Keep scheme, host, port, and path. Actual dial URLs retain their credentials. Complete the quest and remove its reference.

Impact

  • Consumer: @moq/net reconnecting connections that follow GOAWAY redirects with userinfo.
  • No public API, CLI, catalog, or wire-format change. Only private endpoint identity changes.

Validation

  • Both new regressions fail without the fix: stored keys contain credentials, and the second credential-rotating return skips its expected backoff.
  • All 14 migration tests pass with mocked time, including userinfo rotation, query rotation, and unchanged dial URLs.
  • quest check and full scoped just ci pass.

Alternatives

Retain the existing constant-memory loop detector and normalize its keys; no new URL policy or credential handling is needed.

Follow-ups

None. The clock API migration in #6222 is separate; these tests use the current main clock API.

(Written by GPT-6)

kixelated and others added 2 commits October 21, 2026 16:47
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 21, 2026 23:52
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 30673db3-a67f-42c9-85c7-baccaf49a918
📥 Commits

Reviewing files that changed from the base of the PR and between f2c0950 and 58d549a.

📒 Files selected for processing: 4
  • js/net/src/connection/migrate.test.ts
  • js/net/src/connection/reload.ts
  • quest/m1/README.md
  • quest/m1/js-reload-userinfo.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T08:30:40.309726Z 58d549a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Quest outcome: complete. Reconnect endpoint keys now omit URL userinfo, matching Rust, while the actual dial URLs retain their credentials. No public API or wire change.

Both regressions fail without the fix. All 14 mocked-time migration tests, quest check, and full scoped just ci pass. Codex reviewed head b3dc773891 with no findings and a thumbs-up; CodeRabbit was rate-limited and does not count. The remote Rust CodeQL analysis is still running.

No open decisions or suggested follow-up quests. Recommend /quest-merge once the remaining remote check finishes. Nothing has been merged or enqueued.

(Written by GPT-6)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging. endpoint() now clears URL userinfo along with the query and fragment, matching the Rust redirect-key rule from #6162. Dial URLs keep their credentials. The quest file and its m1 reference are removed.

Codex reviewed head b3dc773891a3d00d3b003f9f4ef5e0c4ebd67388 with no findings and a thumbs-up. CodeRabbit was rate-limited. All PR checks pass; the merge queue runs CI. No open decisions or follow-ups.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 22, 2026
…erinfo

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated enabled auto-merge October 22, 2026 08:28
@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit b15af4a Oct 22, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m1/js-reload-userinfo branch October 22, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant