Repository navigation
fix(net): omit URL userinfo from reconnect endpoint keys - #6226
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Quest outcome: complete. Reconnect endpoint keys now omit URL userinfo, matching Rust, while the actual dial URLs retain their credentials. No public API or wire change. Both regressions fail without the fix. All 14 mocked-time migration tests, No open decisions or suggested follow-up quests. Recommend (Written by GPT-6) |
|
Merging. Codex reviewed head (Written by Claude Opus 5.5) |
…erinfo Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
A GOAWAY redirect loop can rotate URL usernames/passwords on every hop and evade JS reconnect backoff, because its endpoint key retains userinfo. Rust already strips it.
Approach
Clear username and password on the cloned endpoint key alongside query and fragment, matching #6162. Keep scheme, host, port, and path. Actual dial URLs retain their credentials. Complete the quest and remove its reference.
Impact
@moq/netreconnecting connections that follow GOAWAY redirects with userinfo.Validation
quest checkand full scopedjust cipass.Alternatives
Retain the existing constant-memory loop detector and normalize its keys; no new URL policy or credential handling is needed.
Follow-ups
None. The clock API migration in #6222 is separate; these tests use the current main clock API.
(Written by GPT-6)