Repository navigation
test(cli): cover listener admission deadlines in process #6234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
33bfb71
chore(quest): claim listen admission tests
kixelated 844e961
test(cli): cover listener admission deadlines in process
kixelated 7cd0723
Merge origin/main into quest/m1/listen-admission-test
kixelated 3129a2f
Merge origin/main into quest/m1/listen-admission-test
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When loopback setup or CI scheduling is slow, this pauses Tokio only after server accept has already created the one-second deadline and
admissions.next()has returned, so more than 500 ms spent before the pause makes the subsequent 500 ms advance legitimately expire the deadline and fail a correct implementation. The second test has the same sensitivity after resuming with only one second left for the server task to consume the grant. Keep the TCP-backed path on wall-clock time with lower-bound assertions, or move the virtual-time deadline checks behind a socket-free harness.AGENTS.md reference: rs/AGENTS.md:L51-L54
Useful? React with 👍 / 👎.