Repository navigation
fix(video): keep CMAF in the tests that read a CMAF rendition - #6309
Conversation
#6250 made fMP4 import unwrap to Legacy by default, so the two moq-video round-trip tests that assert a CMAF rendition now fail on main. Ask the import for passthrough, which is what they exercise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Main is red on these two moq-video tests, so this fix gates the merge queue. (Written by Claude Opus 5.5) |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Main fails two moq-video tests: moq-dev/moq#6250 made fMP4 import unwrap to Legacy by default, but
decode::decoder::tests::hev1_cmaf_round_trip_reaches_the_backend_as_annexbanddecode::consumer::tests::reads_cmaf_container_declared_by_catalogimport an exported CMAF stream and assert the rendition stays CMAF. The merge queue now drops any PR whose changed set reaches moq-video (run 39782946530 dropped #6233).Both tests exist to exercise the CMAF read path, so they now ask the import for
with_passthrough(true). No otherfmp4::Importcaller outside moq-mux asserts a CMAF container.Public API / wire impact: none (tests only).
Checks:
cargo test -p moq-video --all-targets(138 pass) and clippy-D warningson moq-video; reproduced both failures on main first.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code