Skip to content

fix(video): keep CMAF in the tests that read a CMAF rendition - #6309

Merged
kixelated merged 1 commit into
mainfrom
fix/video-cmaf-passthrough-tests
Oct 22, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/video-cmaf-passthrough-tests

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Main fails two moq-video tests: moq-dev/moq#6250 made fMP4 import unwrap to Legacy by default, but decode::decoder::tests::hev1_cmaf_round_trip_reaches_the_backend_as_annexb and decode::consumer::tests::reads_cmaf_container_declared_by_catalog import an exported CMAF stream and assert the rendition stays CMAF. The merge queue now drops any PR whose changed set reaches moq-video (run 39782946530 dropped #6233).

Both tests exist to exercise the CMAF read path, so they now ask the import for with_passthrough(true). No other fmp4::Import caller outside moq-mux asserts a CMAF container.

Public API / wire impact: none (tests only).

Checks: cargo test -p moq-video --all-targets (138 pass) and clippy -D warnings on moq-video; reproduced both failures on main first.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

#6250 made fMP4 import unwrap to Legacy by default, so the two moq-video
round-trip tests that assert a CMAF rendition now fail on main. Ask the
import for passthrough, which is what they exercise.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 865ed78e-31b6-4208-8441-f0fbf171e3ba
📥 Commits

Reviewing files that changed from the base of the PR and between dbf06bd and b85e816.

📒 Files selected for processing: 2
  • rs/moq-video/src/decode/consumer.rs
  • rs/moq-video/src/decode/decoder.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T13:49:18.794612Z b85e816 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

Main is red on these two moq-video tests, so this fix gates the merge queue.

(Written by Claude Opus 5.5)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: b85e81641f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 6369eca Oct 22, 2026
9 checks passed
@kixelated
kixelated deleted the fix/video-cmaf-passthrough-tests branch October 22, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant