Skip to content

quest: plan focused release backports - #6331

Merged
kixelated merged 3 commits into
mainfrom
codex/plan-release-backports
Oct 22, 2026
Merged

kixelated merged 3 commits into
mainfrom
codex/plan-release-backports

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Release lacks selected security and cancellation fixes already on main. These should be available as compatible patch backports before the breaking cut.

Approach

Add an m0 epic with three independently landable quests: targeted WebPKI dependencies, bounded JS certificate/path parsing, and paired FFI read/accept cancellation fixes. Record that the fixed-delay backport moq-dev/moq#6217 merged during planning and narrow its existing quest to release deployment verification. Link the existing QPACK and draining-shutdown owners.

These are source-backed plans; implementation quests require release-side reproduction and relevant validation. The resubscribe investigation reports a benchmark artifact. Broader release-audit findings retain their existing owners.

Impact

  • Public API and wire: none in this planning PR; planned fixes preserve published signatures and wire compatibility.
  • Package versions: unchanged. Existing consumers are TLS clients/relays, browser connections, and foreign-language readers/servers.

Alternatives

A broader stabilization audit was declined. Exclude unrelated dependency upgrades and main's transport/API rewrites.

The publishing-workflow backport is unnecessary: workflow_run uses the default-branch workflow, which already carries the protection. Release push/dispatch paths use github.sha. This review correction removes work with no behavioral consumer.

Decisions

Proposed goal: ship serious security, data-loss, and playback fixes on the current release line while the breaking release is prepared. Which scope should be planned?

  • ✅ Focused backports (recommended): the TLS, parser/publishing, FFI cancellation, and fixed-delay shortlist, coordinated with existing release quests. Maintainer selected option 1 on 2026-10-22. Review established that publishing needs no backport; fixed delay has since merged.
  • Broader stabilization: also inventory lower-severity correctness and operational fixes.

Validation

  • quest check --base origin/main: passes; final tree has 447 documents.
  • nix develop --command just ci origin/main: passed after the review correction.
  • git diff --check: passed.

Follow-ups

Execute the three children under quest/m0/release-backports/. QPACK and draining shutdown keep their independent upstream blockers. This plan adds no gate to the breaking-cut quest.

(Written by GPT-6)

Co-Authored-By: GPT-6 <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e4d7732c-58d5-41ab-987d-f2970d4e91a7
📥 Commits

Reviewing files that changed from the base of the PR and between d44813c and 95a4747.

📒 Files selected for processing: 6
  • quest/m0/README.md
  • quest/m0/release-backports/README.md
  • quest/m0/release-backports/ffi-cancellation.md
  • quest/m0/release-backports/parsing.md
  • quest/m0/release-backports/tls.md
  • quest/m0/release-fixed-delay.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T16:09:06.886600Z 95a4747 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 492fb1ed61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kixelated and others added 2 commits October 22, 2026 09:04
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit ae24311 Oct 22, 2026
10 checks passed
@kixelated
kixelated deleted the codex/plan-release-backports branch October 22, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant