Skip to content

quest: complete release-fixed-delay - #6333

Closed
kixelated wants to merge 3 commits into
mainfrom
quest/m0/release-fixed-delay-done
Closed

kixelated wants to merge 3 commits into
mainfrom
quest/m0/release-fixed-delay-done

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes quest/m0/release-fixed-delay.md and its m0 README entry. The fix landed on release in moq-dev/moq#6217. moq.dev only picks it up from npm.

No code, public API, or wire impact. quest check passes.

Decisions needed

This waits on the maintainer deploying moq.dev (just deploy live). moq-dev/moq.dev#195 merged @moq/watch ^0.6.6, which contains the fix, but moq.dev only deploys by hand. After the deploy, check that the bundle moq.dev serves uses a numeric delay as-is, then mark this ready (current evidence).

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

The fix landed on release in #6217.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6d7623b4-981b-46d8-a5d8-fbfe382f2ed7
📥 Commits

Reviewing files that changed from the base of the PR and between 52ed4cb and a2f876f.

📒 Files selected for processing: 3
  • quest/m0/README.md
  • quest/m0/release-backports/README.md
  • quest/m0/release-fixed-delay.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T20:42:15.625930Z a2f876f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Keep the quest deletion over main's verification rewrite, and drop the
release-backports references to it so quest check passes once it merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as draft October 22, 2026 20:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2f876f50f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines -13 to -14
[moq-dev/moq#6217](https://github.com/moq-dev/moq/pull/6217). Verify its release
deploy reaches moq.dev, then retire this quest; no duplicate backport is

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the quest until the moq.dev rollout is verified

When #6217 is only merged to release and the deploy is still pending, as the commit message states, deleting this quest marks its Goal complete even though it explicitly requires verifying the deployed revision and numeric-delay behavior. This removes the only tracked follow-up for validating the known production regression; retain the quest until the release reaches moq.dev and the live check passes.

AGENTS.md reference: AGENTS.md:L47-L47

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, and this PR is gated on exactly that. It stays a draft until moq.dev serves a bundle with the fix. As of now it does not (evidence), so the remaining steps are listed under ## Decisions needed in the description.

(Written by Claude Opus 5.5)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Deploy check (2026-10-22): moq.dev does not serve the fix from moq-dev/moq#6217 yet, and no automatic deploy will bring it.

  • moq.dev consumes @moq/watch from npm, not from release. Its bun.lock pins @moq/watch@0.6.2 (moq-dev/moq.dev package.json has ^0.6.2).
  • npm latest is @moq/watch@0.6.3, published 2026-10-17, before fix(watch): honor fixed playback delay on release #6217 merged on 2026-10-22. Its src/sync.ts (from the published source map) still has the old #runDelay with no numeric short-circuit.
  • release still has js/watch at 0.6.3, so Release JS on the merge commit fd26b8ffe and later runs logged @moq/watch@0.6.3 already published, skipping (run).
  • The served bundle https://moq.dev/_astro/element.gftmzwNG.js has the pre-fix delay effect: let s=e.get(this.in.delay)==="instant"?u.zero:u.add(i,n);this.#t.delay.set(s), with no typeof ... == "number" early return.

To unblock:

  1. Bump js/watch to 0.6.4 on release so Release JS publishes the fix.
  2. Bump moq.dev's lockfile to @moq/watch@0.6.4 (Dependabot's bun group is weekly with a 7-day cooldown, so a manual bun update @moq/watch is faster) and deploy.

Then this PR can be marked ready.

(Written by Claude Opus 5.5)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Fixed-delay rollout status (2026-10-23 16:05 UTC)

  • npm has the fix. In the published @moq/watch@0.6.5 tarball, Sync's delay effect in player-DVWG4_Zd.js returns the configured number before it reads any jitter, which is moq-dev/moq#6217:
    let t = e.get(this.in.delay);
    if (typeof t == "number") { this.#e.delay.set(t); return; }
    sync.d.ts also says a Time.Milli "fixes the total delay at that number, ignoring rendition delay and jitter". @moq/watch@0.6.6 was published at 16:01 UTC by Release JS, built from later release history.
  • moq.dev does not serve it yet. https://moq.dev/watch/ loads /_astro/element.gftmzwNG.js, and its delay effect still adds jitter to a numeric delay:
    let s=e.get(this.in.delay)==="instant"?u.zero:u.add(i,n);this.#t.delay.set(s)
  • The bump PR already exists. moq-dev/moq.dev#195 moves moq.dev to @moq/watch ^0.6.5. Its CI is green and the Codex and CodeRabbit reviews are clean, so I did not open a duplicate.
  • Deploying is manual. Merging does not deploy moq.dev: pr.yml is its only workflow, and main has no deployments. A deploy is just deploy live with Cloudflare credentials, and moq.dev's AGENTS.md needs your explicit go-ahead for each one.

(Written by Claude Opus 5.5)

Main already retired the release-backports epic and the resubscribe-hang
quest; keep this PR's deletion of the fixed-delay quest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #6592, which has merged.

(Written by Claude Opus 5.5)

@kixelated kixelated closed this Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant