Repository navigation
quest: plan the API audit of main against release - #6340
Conversation
Audit release (36f392f) against main (d44813c) and plan the fixes: a new m1 epic, quest/m1/api-audit, with 27 children that remove unconsumed surfaces, collapse overlapping operations, mirror names across Rust, JS, and the bindings, and fill MIGRATE gaps. Two bug quests (NixOS cluster variable, Wayland display id), an m2 binding-durations quest, and updates to av-clock, ffi-poll-protocol, and the rate quests that the plan touches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31d051e310
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary: plans the release API audit as the m1 epic (Written by Claude Opus 5.5) |
Summary
Plans the fixes from an extensive API audit of
release(36f392f) againstmain(d44813c) ahead of the next cut. Seven read-only audits covered Rust moq-net,@moq/net, the media crates, the bindings,@moq/watch/@moq/publish, the native/relay/transport crates, and the gateway/misc crates. Consumers were checked in this repo, moq.pro (excluding its vendored checkout), and moq.dev. A prior external audit was verified and folded in.quest/m1/api-audit/with 27 children, ranked by priority.quest/m1/nix-cluster-connect.md(NixOS leaf setsMOQ_CLUSTER_ROOT, which nothing reads) andquest/m1/wayland-display-id.md.quest/m2/ffi-durations.mdfor the inherited_usbinding durations.av-clock.md(probe/jittergo first),ffi-poll-protocol.md(absorbs the ordered track reader split so reads break once),rate-grant.md/rate-quic.md/rate-websocket.md(the unenforcedrateclaim is reverted; the first enforcing quest re-adds it).Corrections to the external audit, recorded in the epic:
Prepared::broadcast().announce()returnsError::Closedrather than panicking; JSgroupspredates release;Audio.Decoder.arrivals()has a planned moq.dev consumer, so only the video handle goes; theFmp4/Cmafflip was deliberate (#6250) and the defect is the naming axis; the archive layout drift and the flate fold are already gated by m1 quests.Decisions
The maintainer approved every recommendation wholesale ("please quest-plan anything that you recommend").
request(path, epoch)(owns discovery,Unroutableonce synced) andfollow(path, epoch)in Rust, JS, bindings; deleterouted/routed_broadcast. ✅ / keep five and fix callersSyncdecoder calls:@internalwithwaitreturning present/skip ✅ / publicPromise<boolean>ContainerFormat::Cmaf: delete from enum and bindings, passthrough Rust-only viawith_passthrough✅ /ContainerInit::passthroughflagAccess { path, rate }: revert toPatternsuntil a rate quest enforces ✅ / keep refused field@moq/p2p, moq-e2ee, Rust moq-room; moq-cli drops defaultwebrtc; relay STUN behind a feature; moq-rtcwire::Sourcereverted. ✅session::Limits: drop only caps proven redundant with stream credit or the request window ✅ / keep allfloor()✅ / defer relative/time anchorslinger: publishers always linger;lingermeans only the subscriber wait ✅ / follow-policy enumtrack::Demand::{used, unused}(conflicts with refresh), pulling hang VR fields (decided 2026-10-20), one terminal verb across bindings (KotlinAutoCloseable). ✅Checks
quest checkandjust checkpass. Quest files only; no code, public API, or wire change.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code