Skip to content

quest: plan the API audit of main against release - #6340

Merged
kixelated merged 2 commits into
mainfrom
claude/api-audit-release-7777ab
Oct 22, 2026
Merged

kixelated merged 2 commits into
mainfrom
claude/api-audit-release-7777ab

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Plans the fixes from an extensive API audit of release (36f392f) against main (d44813c) ahead of the next cut. Seven read-only audits covered Rust moq-net, @moq/net, the media crates, the bindings, @moq/watch/@moq/publish, the native/relay/transport crates, and the gateway/misc crates. Consumers were checked in this repo, moq.pro (excluding its vendored checkout), and moq.dev. A prior external audit was verified and folded in.

  • New m1 epic quest/m1/api-audit/ with 27 children, ranked by priority.
  • Bug quests found along the way: quest/m1/nix-cluster-connect.md (NixOS leaf sets MOQ_CLUSTER_ROOT, which nothing reads) and quest/m1/wayland-display-id.md.
  • New quest/m2/ffi-durations.md for the inherited _us binding durations.
  • Updated quests the plan touches: av-clock.md (probe/jitter go first), ffi-poll-protocol.md (absorbs the ordered track reader split so reads break once), rate-grant.md/rate-quic.md/rate-websocket.md (the unenforced rate claim is reverted; the first enforcing quest re-adds it).

Corrections to the external audit, recorded in the epic: Prepared::broadcast().announce() returns Error::Closed rather than panicking; JS groups predates release; Audio.Decoder.arrivals() has a planned moq.dev consumer, so only the video handle goes; the Fmp4/Cmaf flip was deliberate (#6250) and the defect is the naming axis; the archive layout drift and the flate fold are already gated by m1 quests.

Decisions

The maintainer approved every recommendation wholesale ("please quest-plan anything that you recommend").

  1. Goal: before the cut, every surface added since release has a consumer or is gone, overlapping operations are collapsed, names mirror across Rust/JS/bindings, and every break has a MIGRATE entry. ✅
  2. Inherited debt: fixed here only when cheap or on a surface this release already breaks; otherwise joins the quest that reshapes it. ✅
  3. Broadcast resolution: request(path, epoch) (owns discovery, Unroutable once synced) and follow(path, epoch) in Rust, JS, bindings; delete routed/routed_broadcast. ✅ / keep five and fix callers
  4. Sync decoder calls: @internal with wait returning present/skip ✅ / public Promise<boolean>
  5. ContainerFormat::Cmaf: delete from enum and bindings, passthrough Rust-only via with_passthrough ✅ / ContainerInit::passthrough flag
  6. Auth Access { path, rate }: revert to Patterns until a rate quest enforces ✅ / keep refused field
  7. Unpublish @moq/p2p, moq-e2ee, Rust moq-room; moq-cli drops default webrtc; relay STUN behind a feature; moq-rtc wire::Source reverted. ✅
  8. session::Limits: drop only caps proven redundant with stream credit or the request window ✅ / keep all
  9. Subscription ranges: keep the general API, refuse anchors a wire cannot carry, fix floor() ✅ / defer relative/time anchors
  10. Ordered track reader (inherited): fold into m2 foreign poll ✅ / new m1 quest
  11. Binding durations: m2 quest; names fixed in m1 ✅
  12. linger: publishers always linger; linger means only the subscriber wait ✅ / follow-policy enum
  13. Rejected: restoring track::Demand::{used, unused} (conflicts with refresh), pulling hang VR fields (decided 2026-10-20), one terminal verb across bindings (Kotlin AutoCloseable). ✅

Checks

quest check and just check pass. Quest files only; no code, public API, or wire change.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Audit release (36f392f) against main (d44813c) and plan the fixes:
a new m1 epic, quest/m1/api-audit, with 27 children that remove unconsumed
surfaces, collapse overlapping operations, mirror names across Rust, JS, and
the bindings, and fill MIGRATE gaps. Two bug quests (NixOS cluster variable,
Wayland display id), an m2 binding-durations quest, and updates to av-clock,
ffi-poll-protocol, and the rate quests that the plan touches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bc2d736d-6d9e-40e7-9cd6-3e3995137ab9
📥 Commits

Reviewing files that changed from the base of the PR and between ae24311 and d4e606a.

📒 Files selected for processing: 38
  • quest/m1/README.md
  • quest/m1/api-audit/README.md
  • quest/m1/api-audit/announce-owner.md
  • quest/m1/api-audit/auth-access.md
  • quest/m1/api-audit/auth-clock-names.md
  • quest/m1/api-audit/binding-state.md
  • quest/m1/api-audit/binding-trim.md
  • quest/m1/api-audit/clean-close.md
  • quest/m1/api-audit/cli-flags.md
  • quest/m1/api-audit/container-format.md
  • quest/m1/api-audit/decode-read.md
  • quest/m1/api-audit/derived-origin-close.md
  • quest/m1/api-audit/gateway-api.md
  • quest/m1/api-audit/js-prepared.md
  • quest/m1/api-audit/largest-getter.md
  • quest/m1/api-audit/media-trim.md
  • quest/m1/api-audit/migrate.md
  • quest/m1/api-audit/net-exports.md
  • quest/m1/api-audit/qmux-shape.md
  • quest/m1/api-audit/ranges-wire.md
  • quest/m1/api-audit/relay-config.md
  • quest/m1/api-audit/resolve.md
  • quest/m1/api-audit/session-limits.md
  • quest/m1/api-audit/stats-naming.md
  • quest/m1/api-audit/sync-wait.md
  • quest/m1/api-audit/transport-config.md
  • quest/m1/api-audit/unpublish.md
  • quest/m1/api-audit/watch-trim.md
  • quest/m1/api-audit/wrapper-config.md
  • quest/m1/av-clock.md
  • quest/m1/nix-cluster-connect.md
  • quest/m1/wayland-display-id.md
  • quest/m2/README.md
  • quest/m2/ffi-durations.md
  • quest/m2/ffi-poll-protocol.md
  • quest/m2/rate-grant.md
  • quest/m2/rate-quic.md
  • quest/m2/rate-websocket.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-22T16:24:45.288597Z d4e606a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31d051e310

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/api-audit/auth-access.md Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: plans the release API audit as the m1 epic quest/m1/api-audit/ (27 children), two m1 bug quests, and the m2 binding-durations quest, with updates to av-clock, ffi-poll-protocol, and the rate quests. All decisions in the PR body were approved by the maintainer. The one Codex finding (auth claims must not depend on moq-net for the rate type) is fixed in d4e606a. quest check --base origin/main passes.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 1f47222 Oct 22, 2026
9 checks passed
@kixelated
kixelated deleted the claude/api-audit-release-7777ab branch October 22, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant