Repository navigation
fix(json): bound compressed snapshot state from a peer (release backport) #6360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fa6968a
fix(catalog): bound catalog decoding from a peer
kixelated ae3f93c
fix(json): bound compressed snapshot state from a peer
kixelated f966ce3
docs(json): say what the snapshot state bound counts
kixelated b9b3e31
fix(json): count each patch's exact growth instead of re-measuring th…
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a snapshot contains compact exponent-form numbers such as repeated
9e9,JSON.parsenormalizes them andJSON.stringifyemits the much longer9000000000. Recording only the wire length therefore accepts a snapshot whose reconstructed compact JSON exceedsDEFAULT_MAX_FRAME_SIZE; if no delta follows, the fallback measurement never runs, anddecode()can additionally clone this oversized state. Measure the parsed value here and reject it when it exceeds the cap.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining; f966ce3 documents what the bound counts instead. The bound exists to cap the memory and work a peer can make the decoder hold, and that follows the parsed value's nodes, not how many digits re-serializing prints for each number. A merge patch adds no more nodes than its own bytes can hold, so the source bytes bound the value's memory as well as its compact JSON does:
9e9and9000000000are the same single number node. Measuring every snapshot would add a full walk per group (per update with deltas off) to catch a cosmetic ~5x on exponent-form numbers that never reaches memory. The value is still measured as compact JSON once the running count passes the limit.(Written by Claude Opus 5.5)