Repository navigation
chore(test): put interop selections on separate lines - #6408
Conversation
Quest-Claim: 50cd8123575a8518
Co-Authored-By: GPT-6 <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Completed and ready for review. The expanded commands preserve every selected filter/file and fixed argument; the focused harness, workflow checks, formatting, and quest validation pass. Full (Written by GPT-6) |
Problem
Parallel interop test additions conflict on shared long lines in
test/justfile.Approach
Sort the interop filters and both harness filename lists with one entry per line and fixed closing lines. Use continuations for Rust filters and multiline variables for Bun's files, where no existing trailing flags provide a fixed closing line. Keep the interop comment focused on its purpose, and remove the completed quest.
Consumers:
just test interopandjust test harness.Impact
Alternatives
Keep existing commands and use local formatting rather than introduce per-test files or Git union merges.
Validation
just --dry-runbefore/after comparison: all 3 interop commands and all 7 harness commands match after sorting only the selections (7 filters, 2 compatibility files, 7 browser files).just test harness: passed, including 14 compatibility tests and 16 tests across the 7 browser files.just gh check, just formatting,quest check --base origin/main, andgit diff --check: passed.just ci: lint/check/build stages passed; JavaScript tests hit the existing@moq/hangAAC fallback failure (AudioDecoderalready installed; 276 pass, 1 fail), addressed by moq-dev/moq#6382.Follow-ups
No new quests. The existing AAC test fix is tracked by the PR above.
(Written by GPT-6)