Skip to content

chore(test): put interop selections on separate lines - #6408

Merged
kixelated merged 2 commits into
mainfrom
quest/m0/ci/interop-filter-lines
Oct 23, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m0/ci/interop-filter-lines

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Parallel interop test additions conflict on shared long lines in test/justfile.

Approach

Sort the interop filters and both harness filename lists with one entry per line and fixed closing lines. Use continuations for Rust filters and multiline variables for Bun's files, where no existing trailing flags provide a fixed closing line. Keep the interop comment focused on its purpose, and remove the completed quest.

Consumers: just test interop and just test harness.

Impact

  • Public API: none.
  • Wire: none.
  • Selected tests and fixed command arguments are unchanged; only selection order is sorted.

Alternatives

Keep existing commands and use local formatting rather than introduce per-test files or Git union merges.

Validation

  • Nix just --dry-run before/after comparison: all 3 interop commands and all 7 harness commands match after sorting only the selections (7 filters, 2 compatibility files, 7 browser files).
  • Nix just test harness: passed, including 14 compatibility tests and 16 tests across the 7 browser files.
  • Nix just gh check, just formatting, quest check --base origin/main, and git diff --check: passed.
  • Nix just ci: lint/check/build stages passed; JavaScript tests hit the existing @moq/hang AAC fallback failure (AudioDecoder already installed; 276 pass, 1 fail), addressed by moq-dev/moq#6382.

Follow-ups

No new quests. The existing AAC test fix is tracked by the PR above.

(Written by GPT-6)

kixelated and others added 2 commits October 22, 2026 16:13
@kixelated kixelated changed the title One test filter per line in test/justfile chore(test): put interop selections on separate lines Oct 22, 2026
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 23:18
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5914a724-594d-4ecc-9464-332691e01431
📥 Commits

Reviewing files that changed from the base of the PR and between 34b6ceb and d56ec8b.

📒 Files selected for processing: 3
  • quest/m0/ci/README.md
  • quest/m0/ci/interop-filter-lines.md
  • test/justfile
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T23:20:17.693300Z d56ec8b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Completed and ready for review. The expanded commands preserve every selected filter/file and fixed argument; the focused harness, workflow checks, formatting, and quest validation pass. Full just ci reaches the existing AAC fallback test failure covered by moq-dev/moq#6382. No open decisions or new follow-up quests.

(Written by GPT-6)

@kixelated
kixelated added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit e105686 Oct 23, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/ci/interop-filter-lines branch October 23, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant