Repository navigation
quest: close the cpp -> js interop budget flake, fixed by #6231 #6442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cf56ea5
chore(quest): claim quest/m1/test-flakes-2/interop-cpp-js.md
kixelated 8b3211f
quest: close the cpp -> js interop budget flake, fixed by #6231
kixelated eda6b04
Merge main
kixelated c61cff5
quest: record the tone-check grace flake
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # [S] The interop tone check charges its grace only for audible playback | ||
|
|
||
| ## Goal | ||
|
|
||
| The JS interop driver's tone check fails only when audio that played was | ||
| silent or wrong, never because the player was still refilling its ring. Under | ||
| CPU starvation a browser cell waits out the re-stall instead of failing fast | ||
| with silence or a false "wrong tone". | ||
|
|
||
| ## Plan | ||
|
|
||
| Found while closing the cpp to js budget flake | ||
| ([moq-dev/moq#6442](https://github.com/moq-dev/moq/pull/6442)), never seen in | ||
| CI. With 8 browsers on 2 CPUs, 7 of 500+ main browser cells failed in under | ||
| 12 s: the auto playout delay rose to 1 to 5 s, the ring re-stalled to refill, | ||
| and the 3 s `TONE_GRACE_MS` in `test/interop/clients/js/driver.ts` expired on | ||
| silence. Once it read stuttered audio as a wrong tone. | ||
|
|
||
| Reproduce it under the same starvation, then measure the grace from audible | ||
| playback (the player's own stalled/playing state) rather than wall time since | ||
| the check began, keeping the overall cell budget unchanged. | ||
|
|
||
| Public API: none. Wire: none. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.