Skip to content

quest: the JS namespace lifecycle cell waits on an @moq/net patch - #6503

Merged
kixelated merged 6 commits into
mainfrom
quest/m1/interop-coverage/js-namespace-done
Oct 23, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest/m1/interop-coverage/js-namespace-done

Conversation

@kixelated

@kixelated kixelated commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Finds why the interop runner's moq-dev-js subscribe-namespace-lifecycle case never sees NAMESPACE_DONE against Cloudflare draft-18 and aiomoqt (englishm/moq-interop-runner#173), fixes it on release, and rewrites the quest to wait on the next @moq/net patch release that carries the fix, then the runner pin bump.

Cause

Not shared state between two sessions in one process. The published @moq/net 0.4.5 and earlier withdraw a PUBLISH_NAMESPACE on drafts 17+ with FIN plus STOP_SENDING. Draft-18 §3.3.2 cancels a request by terminating every open direction abruptly. Both relays end the namespace only on RESET_STREAM, so the subscriber waits until the publisher's session closes. From two processes the case passed only because the exiting publisher closed its session.

Reproduced with the runner's client on the release source, trying each signal alone: FIN, STOP_SENDING, FIN then STOP_SENDING after the ack, and FIN plus STOP_SENDING all fail on both relays; RESET_STREAM alone passes. Our sender was out of spec, so nothing goes upstream.

main already sends the reset since moq-dev/moq#5483, and the runner's client built on main passes against both relays. The published Rust client (moq-tokio 0.19.28) passes too, over WebTransport and raw QUIC.

Changes

Public API and wire impact

Checks

  • quest check and just check pass on this branch after merging main.
  • fix(net): withdraw PUBLISH_NAMESPACE by reset on draft-17+ (release backport) #6518: just check origin/release passes. The three changed publisher tests and the new subscriber test fail without the fix. CI passed and Codex approved its final head. just test interop --all passes except the browser js cells, which could not launch Chromium (release's Playwright against the dev shell's browsers). That harness runs moq-lite, which the change does not touch.

Decisions

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 22, 2026 23:59
The cause is @moq/net 0.4.4 withdrawing PUBLISH_NAMESPACE with a FIN on
drafts 17+, fixed on main by #5483 and backported to release by #6518.
What remains is bumping the runner's JS client once that patch publishes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title JS namespace lifecycle passes with both halves in one process quest: the JS namespace lifecycle cell waits on an @moq/net patch Oct 23, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Outcome: the cell fails because @moq/net 0.4.4 withdraws PUBLISH_NAMESPACE with a FIN on drafts 17+, and Cloudflare d18 and aiomoqt end the namespace only on RESET_STREAM. Fixed on main by moq-dev/moq#5483 and backported in moq-dev/moq#6518. The quest now tracks the runner pin bump after the patch publishes. Draft until the two decisions in the body are settled.

(Written by Claude Opus 5.5)

@kixelated kixelated mentioned this pull request Oct 23, 2026
kixelated and others added 2 commits October 23, 2026 09:26
# Conflicts:
#	quest/m1/interop-coverage/README.md
#	quest/m1/interop-coverage/js-namespace-done.md
#	quest/m1/interop-coverage/runner-cases.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 23, 2026 16:53
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cd89c304-d031-4486-a402-9e83662dfecb
📥 Commits

Reviewing files that changed from the base of the PR and between 8419cb2 and ab37e1a.

📒 Files selected for processing: 2
  • quest/m1/interop-coverage/README.md
  • quest/m1/interop-coverage/js-namespace-done.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T19:40:46.265766Z ab37e1a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging. The maintainer decided to ship #6518 JS-only on release, and this quest now waits on the @moq/net 0.4.6+ patch that carries it. CI is green, the current head has a non-Grok review, and quest check passes against main.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 23, 2026
# Conflicts:
#	quest/m1/interop-coverage/README.md
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging. Requeued after merging main; the only change since review is that merge. CI is green, the current head has a non-Grok review, and quest check passes against main.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 23, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge triage: quest-only change (2 files), quest check passes against current main, CI green (10/10), mergeable and clean, no unresolved threads, Codex thumbs-up on the head after its last commit. No changes made; enabling auto-merge on ab37e1af02d3e8ed99c182773514cffb3a871893.

(Written by Sonnet 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit b24e7fe Oct 23, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m1/interop-coverage/js-namespace-done branch October 23, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant