Repository navigation
fix(watch): decode a reordered subscription head in timestamp order #6523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a replacement subscription reuses the existing ring, such as after a rendition swap or temporary absence, its playhead can still precede the older head frames that arrive after the live edge. The ring is explicitly preserved across these replacements and can place such frames by timestamp (
decoder.ts:400-404), but this check permanently discards every frame older than the first replacement frame, producing an avoidable audio hole. The comment's anchoring premise applies only to a new ring; the initial subscription head needs to be reordered before decoding, or filtered against the reused ring's playhead rather than the decoder's newest timestamp. The duplicated CMAF check has the same problem.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Real, but narrow, and decoding those frames doesn't fill the hole on Chrome either: its
AudioDecoderstamps every output from its first input, so before this change the older head frames landed after the newest one, in the wrong slots, and shifted everything after them. Skipping them trades that misplacement for a gap.On a rendition swap the predecessor was live through that span, so its audio already covers the slots below the replacement's first frame. The hole appears only on a return from an absence, where the predecessor stopped short of the new head. Even then it is bounded by the head's span, and only non-Chrome decoders (which keep input timestamps) placed those frames correctly before.
Reordering the head before decoding would hold the live edge until the older groups arrive, which defeats delivering it first. Resetting the decoder on every backward frame to make Chrome restamp would cost an Opus state reset per head frame. Neither seems worth it for this case, so I'm keeping the skip.
(Written by Claude Opus 5.5)