Skip to content

quest: ascending order for buffered playback, and a buffered video poster - #6574

Merged
kixelated merged 2 commits into
mainfrom
plan/buffered-ascending
Oct 23, 2026
Merged

kixelated merged 2 commits into
mainfrom
plan/buffered-ascending

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Plans two m1 quests from the moq.dev Voice demo work (#6523, #6549):

Both are ranked right after Container reads drop backfill.

Decisions

Goal. "A subscriber can ask for a track's groups in ascending sequence order, so a voice reply's opening never arrives after its live edge, and the watch player's head-hold heuristic (#6549) can be deleted."

  • ✅ Yes, as stated
  • Voice tracks only
  • Keep the decoder hold too

Which subscriptions request ascending?

  • Buffered audio only
  • ✅ All buffered media. The maintainer added: "it's an opt in by the app. Buffering in the future is definitely an opt-in though, so maybe it's tied to that."
  • Explicit opt-in

What happens to #6549's head hold?

  • Delete it
  • Keep for old versions
  • ✅ Maintainer: "We should still have some head hold based on the minimum latency."

Placement.

  • ✅ m1, requires lite-07
  • m2
  • m1, unblocked now

How does the app opt in?

  • ✅ Tied to buffered mode
  • Separate attribute

Head hold rule with ascending.

Does the hold apply to video?

  • Audio only
  • Audio and video
  • ✅ Maintainer: "both before playback starts, but we still want to render the first video frame ASAP as a poster while the rest load before resume"

Split.

  • ✅ Two quests
  • One quest

When does buffered video leave the poster?

  • With audio, at the floor
  • Its own floor. Chosen first, then revised: "I think synchronized A/V shares a floor?"
  • ✅ Shared floor
  • Audio drives the start

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

…eo poster

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7fe0b699-bbaa-4e5d-8256-ad4c24edf2da
📥 Commits

Reviewing files that changed from the base of the PR and between 66ce942 and e17e9ed.

📒 Files selected for processing: 3
  • quest/m1/README.md
  • quest/m1/buffered-ascending.md
  • quest/m1/buffered-video-poster.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T17:29:36.478763Z 6197bd0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6197bd026e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m1/buffered-ascending.md Outdated
`js/watch/src/element.ts` and `js/watch/src/sync.ts` in the same PR.
- Verify against a voice agent on a lite-07 relay: every reply decodes from
its first frame, plain and barge-in, with no overflow. moq.dev's local
Pipecat stack (moq-dev/moq.pro#2785) is one way.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the private repository reference

This public quest document points readers to the private tracker entry moq-dev/moq.pro#2785, exposing a private-repository reference. Replace it with a self-contained public validation recipe or a generic description of the required Pipecat setup.

AGENTS.md reference: AGENTS.md:L35-L35

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Fixed in e17e9ed: the verification step now describes the setup generically (a Pipecat pipeline publishing each TTS reply as a fresh track with one Opus frame per group) instead of linking a private repository.

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary

Adds two m1 quests, ranked right after Container reads drop backfill:

  • Buffered playback subscribes in ascending order [M]: a nonzero buffer makes every media subscription order: "ascending", and the audio head hold from fix(watch): hold a buffered subscription's audio head and decode it in order #6549 shrinks to one floor-span rule. It is blocked on Finalize moq-lite-07, because lite-06 serves ascending requests newest-first, and it ships in the next minor.
  • Buffered video poster [S]: buffered startup paints the first video frame at once, and synchronized A/V starts together at a shared floor. It is ready now.

Every decision is recorded with ✅ in the PR description and dated in each quest's Plan. Codex's one finding, a private-repository link, is fixed. quest check passes.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 043a6e7 Oct 23, 2026
9 checks passed
@kixelated
kixelated deleted the plan/buffered-ascending branch October 23, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant