Repository navigation
quest: ascending order for buffered playback, and a buffered video poster - #6574
Conversation
…eo poster Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6197bd026e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `js/watch/src/element.ts` and `js/watch/src/sync.ts` in the same PR. | ||
| - Verify against a voice agent on a lite-07 relay: every reply decodes from | ||
| its first frame, plain and barge-in, with no overflow. moq.dev's local | ||
| Pipecat stack (moq-dev/moq.pro#2785) is one way. |
There was a problem hiding this comment.
Remove the private repository reference
This public quest document points readers to the private tracker entry moq-dev/moq.pro#2785, exposing a private-repository reference. Replace it with a self-contained public validation recipe or a generic description of the required Pipecat setup.
AGENTS.md reference: AGENTS.md:L35-L35
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed. Fixed in e17e9ed: the verification step now describes the setup generically (a Pipecat pipeline publishing each TTS reply as a fresh track with one Opus frame per group) instead of linking a private repository.
(Written by Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge summaryAdds two m1 quests, ranked right after Container reads drop backfill:
Every decision is recorded with ✅ in the PR description and dated in each quest's Plan. Codex's one finding, a private-repository link, is fixed. (Written by Claude Opus 5.5) |
Summary
Plans two m1 quests from the moq.dev Voice demo work (#6523, #6549):
[M]: a buffered<moq-watch>subscribes withorder: "ascending", so a voice reply's opening arrives first, and fix(watch): hold a buffered subscription's audio head and decode it in order #6549's head hold shrinks to one floor-span rule. It requires Finalize moq-lite-07, because lite-06 serves an ascending request newest-first.[S]: buffered startup paints the first video frame at once, then starts A/V together at a shared floor. It's ready now.Both are ranked right after Container reads drop backfill.
Decisions
Goal. "A subscriber can ask for a track's groups in ascending sequence order, so a voice reply's opening never arrives after its live edge, and the watch player's head-hold heuristic (#6549) can be deleted."
Which subscriptions request ascending?
What happens to #6549's head hold?
Placement.
How does the app opt in?
Head hold rule with ascending.
Does the hold apply to video?
Split.
When does buffered video leave the poster?
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code