Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/audio-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
shell: bash -leo pipefail {0}
env:
# Somewhere upload-artifact can reach; the harness default is under $TMPDIR.
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs

# The harness keeps a failing run's directory: every row's samples and summary.
- name: Keep the failing run
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/features.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ jobs:
run: nix develop --command just ${{ matrix.recipe }}
env:
NEXTEST_PROFILE: ci
MOQ_STRICT: 1
CI_STRICT: 1
4 changes: 2 additions & 2 deletions .github/workflows/ietf-conformance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
- name: Pinned Moxygen through the relay under the conformance profile
run: nix develop --command just test ietf-conformance
env:
MOQ_TEST_RUNS: ${{ runner.temp }}/ietf-conformance
MOQ_TEST_KEEP: 1
HARNESS_RUNS: ${{ runner.temp }}/ietf-conformance
HARNESS_KEEP: 1
- name: Keep conformance reports and endpoint logs
if: ${{ !cancelled() }}
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7
Expand Down
30 changes: 15 additions & 15 deletions .github/workflows/interop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
shell: bash -leo pipefail {0}
env:
# Fail rather than skip the io_uring arm if the runner's kernel lacks it.
MOQ_STRICT: 1
CI_STRICT: 1

- name: Harness regressions
id: harness
Expand Down Expand Up @@ -101,8 +101,8 @@ jobs:
# The run writes its directory here, so a failed one is uploaded below
# and a passing one is deleted as usual. Each case's record lands beside
# it, for the report below.
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
MOQ_TEST_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl

# The same matrix with every client pinned to one moq-transport draft per pass. A release
# PR runs the oldest and newest even draft between Rust and native JS; nightly and manual
Expand All @@ -116,8 +116,8 @@ jobs:
shell: bash -leo pipefail {0}
env:
INTEROP_ARGS: ${{ github.event_name == 'pull_request' && '--publishers rust --subscribers rust,js-native-node,js-native-bun --versions moq-transport-14,moq-transport-22' || '--all --versions ietf' }}
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
MOQ_TEST_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl

# Registry installs and the release matrix run only on main, nightly or
# on demand: a break only needs catching before the next release.
Expand All @@ -128,26 +128,26 @@ jobs:
shell: bash -leo pipefail {0}
env:
GH_TOKEN: ${{ github.token }}
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
MOQ_TEST_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl

- name: Portrait transcode
id: portrait
if: ${{ !cancelled() && steps.setup.outcome == 'success' }}
run: nix develop --command just test portrait
shell: bash -leo pipefail {0}
env:
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
MOQ_TEST_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl

- name: Interop negative control
id: negative
if: ${{ !cancelled() && steps.setup.outcome == 'success' }}
run: nix develop --command just test interop-negative
shell: bash -leo pipefail {0}
env:
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
MOQ_TEST_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl

# Browser-to-browser media QA: presented frame progress, audible tone, audio/video skew, and
# the publication lifecycle, plus the negative controls that prove each assertion can fail.
Expand All @@ -157,8 +157,8 @@ jobs:
run: nix develop --command just test media
shell: bash -leo pipefail {0}
env:
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
MOQ_TEST_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl

# Run independently so an unrelated cold-start failure cannot hide the
# codec replacement and same-track coded-size growth measurements.
Expand All @@ -168,8 +168,8 @@ jobs:
run: nix develop --command just test media --media-cases rename
shell: bash -leo pipefail {0}
env:
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
MOQ_TEST_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RESULTS: ${{ runner.temp }}/moq-test-runs/results.jsonl

# A failing harness run keeps its directory, holding the process logs, the
# relay config, and a Playwright trace of the failing page. Upload it for a
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ jobs:
run: nix develop ${{ matrix.shell }} --command just ${{ matrix.recipe }}
env:
NEXTEST_PROFILE: default
MOQ_BENCH_BASE: ${{ matrix.paired && (inputs.bench-base || 'previous-nightly') || '' }}
BENCH_BASE: ${{ matrix.paired && (inputs.bench-base || 'previous-nightly') || '' }}
GH_TOKEN: ${{ matrix.paired && github.token || '' }}

- name: Record benchmark outcome
Expand Down Expand Up @@ -351,7 +351,7 @@ jobs:
fail-fast: false
matrix:
# `rs uring` is a separate feature compile (off the default set), and
# MOQ_STRICT fails it below the 6.12 kernel floor. The embedding tests for
# CI_STRICT fails it below the 6.12 kernel floor. The embedding tests for
# io_uring live there; uring.yml also runs it on affected release PRs.
# `test drain` stands up two relays and drains one under a live JS
# viewer: diff-independent, since a break can arrive through the relay,
Expand Down Expand Up @@ -393,7 +393,7 @@ jobs:
run: nix develop --command just ${{ matrix.recipe }}
env:
NEXTEST_PROFILE: ci
MOQ_STRICT: 1
CI_STRICT: 1

# Media QA with a Firefox player against a Chromium fixture. The Chromium
# player already runs in interop.yml, nightly and on release PRs. WebKit has
Expand Down Expand Up @@ -423,7 +423,7 @@ jobs:
- name: Media and negative controls
run: nix develop --command env PLAYWRIGHT_BROWSERS_PATH="${{ runner.temp }}/playwright" just test media --media-engines firefox
env:
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
# Playwright checks a browser's libraries with the `ldd` on PATH, which in the
# dev shell is Nix glibc's and can't see the ones `--with-deps` installed, so
# it refuses a Firefox that launches fine.
Expand Down Expand Up @@ -478,16 +478,16 @@ jobs:
run: nix develop --command just test native-play
shell: bash -leo pipefail {0}
env:
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
- name: Audio quality
if: ${{ !cancelled() }}
run: nix develop --command just test audio-quality --runtimes chromium --enforce --capture
shell: bash -leo pipefail {0}
env:
# Somewhere upload-artifact can reach; the harness default is under $TMPDIR.
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
# A passing run is kept too: budgets.json is measured from these nights.
MOQ_TEST_KEEP: 1
HARNESS_KEEP: 1
# The native player's rows, graded but not enforced: an intermittent device
# stall voids about one AAC row in seven, which would fail most nights until
# it is fixed. Kept beside the browser run so its ceilings can be re-measured.
Expand All @@ -496,8 +496,8 @@ jobs:
run: nix develop --command just test audio-quality --runtimes native
shell: bash -leo pipefail {0}
env:
MOQ_TEST_RUNS: ${{ runner.temp }}/moq-test-runs
MOQ_TEST_KEEP: 1
HARNESS_RUNS: ${{ runner.temp }}/moq-test-runs
HARNESS_KEEP: 1
# The run directory is the diagnosis: each process's log, the shaper's
# counters, the raw samples, and every row's summary.
- name: Keep the run
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ jobs:
cli=$(nix build --refresh --no-link --print-out-paths 'github:moq-dev/moq#moq')
{
echo "RELAY_BIN=$relay/bin/moq-relay"
echo "MOQ_BIN=$cli/bin/moq"
echo "CLI_BIN=$cli/bin/moq"
} >> "$GITHUB_ENV"
# cachix.yml only pushes release tags, so each new HEAD
Expand All @@ -228,19 +228,19 @@ jobs:
echo "no CACHIX_AUTH_TOKEN secret; not pushing"
exit 0
fi
nix run nixpkgs#cachix -- push kixelated "${RELAY_BIN%/bin/*}" "${MOQ_BIN%/bin/*}"
nix run nixpkgs#cachix -- push kixelated "${RELAY_BIN%/bin/*}" "${CLI_BIN%/bin/*}"
- name: Pull moqdev images (docker channel)
if: matrix.channel == 'docker'
# Pull :latest fresh, then point smoke.sh at the wrapper scripts (which
# `docker run --network host` the images) via RELAY_BIN/MOQ_BIN. Docker is
# `docker run --network host` the images) via RELAY_BIN/CLI_BIN. Docker is
# preinstalled on the Linux runners.
run: |
docker pull moqdev/moq-relay
docker pull moqdev/moq
{
echo "RELAY_BIN=$PWD/clients/docker/moq-relay"
echo "MOQ_BIN=$PWD/clients/docker/moq"
echo "CLI_BIN=$PWD/clients/docker/moq"
} >> "$GITHUB_ENV"
# ── browser deps (Chromium runtime libs on Linux) ──────────────────
Expand Down Expand Up @@ -290,7 +290,7 @@ jobs:
# ── token interop ──────────────────────────────────────────────────
# Independent of the media matrix: prove the published token tooling
# cross-verifies. `moq auth` rides the same channel as moq-relay/moq
# (cargo/apt/brew/nix, on PATH or MOQ_BIN); @moq/auth comes from npm and
# (cargo/apt/brew/nix, on PATH or CLI_BIN); @moq/auth comes from npm and
# runs under both node and bun; rust-docker runs `auth` in the
# moqdev/moq image. The negative pass inside token.sh confirms each verifier rejects
# tampered tokens and the wrong key.
Expand Down
Loading
Loading