Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
13632ff
chore(quest): claim quest/m1/broadcast-lifecycle/stateless.md
kixelated Oct 24, 2026
b6b951f
fix(net): a relay finishes an ended lite subscription when its sessio…
kixelated Oct 24, 2026
bce2d4e
feat(net)!: broadcasts have no finished state (WIP)
kixelated Oct 24, 2026
c851cce
Merge remote-tracking branch 'origin/main' into quest/m1/broadcast-li…
kixelated Oct 24, 2026
b6857ba
feat!: drop broadcast Finish from @moq/net and every binding
kixelated Oct 24, 2026
8eb5d0d
Merge remote-tracking branch 'origin/main' into quest/m1/broadcast-li…
kixelated Oct 24, 2026
ecf4929
style: format and lint fixes
kixelated Oct 24, 2026
1d77bc9
test: a failed finish leaves the broadcast for its close
kixelated Oct 24, 2026
6d42b69
docs: moq_publish_finish keeps its released signature but no longer c…
kixelated Oct 24, 2026
ceac975
Merge remote-tracking branch 'origin/main' into HEAD
kixelated Oct 24, 2026
cdb59a7
Merge remote-tracking branch 'origin/main' into HEAD
kixelated Oct 25, 2026
26b3737
test: follow main's with_range rename in relay_upstream_close
kixelated Oct 25, 2026
3b49ef3
feat(ffi,c)!: finish the catalog through its own handle
kixelated Oct 25, 2026
2af22ea
fix(net): a tail the session ends finishes its track
kixelated Oct 25, 2026
736627b
fix: restore imports main's Fill wrappers use
kixelated Oct 25, 2026
3be1b5b
Merge remote-tracking branch 'origin/main' into HEAD
kixelated Oct 25, 2026
b53e8f6
quest: drop the last broadcast finish reference in listing-clean-end
kixelated Oct 25, 2026
65c82a3
Merge remote-tracking branch 'origin/main' into HEAD
kixelated Oct 25, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions cpp/moq/test/probe.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -172,17 +172,14 @@ int main() {
CHECK(!moq::MediaTimebase::init(timebase_owner));
ok(timebase_other->close(), "close timebase other");

// A finished broadcast lingers for its longest max age; closing the handle ends the wait early.
// A finished catalog leaves the broadcast up, still serving its finished tracks, until it closes.
auto finished = ok(moq::BroadcastProducer::init(), "finished broadcast");
moq::TrackInfo aged;
aged.max_age_us = 3600000000;
ok(ok(finished->publish_track("status", aged), "publish aged track")->finish(), "finish aged track");
auto finish = ok(finished->finish(), "broadcast finish");
CHECK(finish->linger_us() == 3600000000);
CHECK(!finished->publish_track("events", {}));
auto lingering = finish->wait();
finish->close();
ok(lingering.get(), "finish wait");
auto finished_catalog = ok(moq::MediaCatalogProducer::init(finished), "finished catalog");
ok(ok(finished->publish_track("status", {}), "publish track")->finish(), "finish track");
ok(finished_catalog->finish(), "catalog finish");
ok(finished->consume(), "consume a finished broadcast");
ok(finished->close(), "close finished broadcast");
CHECK(!finished_catalog->finish());

// A synchronous error is a returned value, not an exception.
auto unbound = ok(moq::Server::init({}), "server init");
Expand Down
7 changes: 4 additions & 3 deletions dart/moq/MIGRATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,11 @@ Where you skipped such a rendition on that error, bound the call yourself: add a

Audio and video init records no longer carry a track name. Pass that name on the media producer's named target instead; init records describe only the codec and media.

### Broadcast `finish` no longer closes
### Broadcast `finish` is removed

`BroadcastProducer.finish()` was a deprecated alias for `close()`; it no longer ends the broadcast at once.
`BroadcastProducer.finish()`, a deprecated alias for `close()`, is removed.
Call `BroadcastProducer.close()` where you called `finish()`.
To end the content first, call `CatalogProducer.finish()`; the broadcast stays up until `close()`.

### JSON snapshot `deltaRatio` is `deltas`

Expand Down Expand Up @@ -89,7 +90,7 @@ Clamp timestamps you build from unbounded input to `2^61 - 1`.

### Finished tracks stay until the broadcast ends (#6157)

A finished track now stays listed, with its catalog rendition and demand, until its broadcast closes or the new `BroadcastProducer.finish()` lets go.
A finished track now stays listed, with its catalog rendition and demand, until its broadcast closes.
Publish a replacement under a new name, and expect a finished track's demand watch to end with the broadcast.

### A claim answers by publishing (#5678)
Expand Down
4 changes: 0 additions & 4 deletions dart/moq/lib/src/aliases.dart
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@ typedef BroadcastConsumer = MoqBroadcastConsumer;
/// Receives tracks requested from a dynamically served broadcast.
typedef BroadcastDynamic = MoqBroadcastDynamic;

/// A cleanly ended broadcast, still announced and serving its finished tracks
/// until its linger ends; close it to end the linger early.
typedef BroadcastFinish = MoqBroadcastFinish;

/// The write side of a raw track: append groups of frames.
typedef TrackProducer = MoqTrackProducer;

Expand Down
6 changes: 0 additions & 6 deletions dart/moq/lib/src/durations.dart
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,6 @@ extension TrackInfoDuration on MoqTrackInfo {
maxAgeUs == null ? null : Duration(microseconds: maxAgeUs!);
}

/// Duration view over how long a finished broadcast stays up.
extension BroadcastFinishDuration on MoqBroadcastFinish {
/// The longest max age of the finished tracks the broadcast holds.
Duration get linger => Duration(microseconds: lingerUs());
}

/// Duration view over a raw frame's presentation time.
extension FrameDuration on MoqFrame {
/// Presentation timestamp, or null for an untimed frame.
Expand Down
25 changes: 8 additions & 17 deletions dart/moq/test/moq_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -385,24 +385,15 @@ void main() {
second.close();
});

test('a finished broadcast lingers until closed', () async {
test('a finished catalog leaves the broadcast up until closed', () {
final broadcast = BroadcastProducer();
final track = broadcast.publishTrack(
name: 'status',
info: TrackInfo(maxAgeUs: 3600000000),
);
track.finish();
final finish = broadcast.finish();
expect(finish.linger, const Duration(hours: 1));
expect(
() => broadcast.publishTrack(name: 'events', info: null),
throwsA(isA<ClosedMoqException>()),
);
// A Dart future can't be cancelled, so closing is the interrupt: the wait
// ends instead of lingering for an hour.
final wait = finish.wait();
finish.close();
await wait.timeout(timeout);
final catalog = moq_media.CatalogProducer(broadcast: broadcast);
broadcast.publishTrack(name: 'status', info: null).finish();
catalog.finish();
// Finishing the content leaves the broadcast up until it closes.
broadcast.consume();
broadcast.close();
expect(() => catalog.finish(), throwsA(isA<ClosedMoqException>()));
});

test('microsecond fields read back as Durations', () {
Expand Down
Loading
Loading