Repository navigation
fix(test): charge tone grace only during playback - #6668
Conversation
Quest-Claim: f9579bedb6671485
Co-Authored-By: GPT-6 <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…2/tone-grace # Conflicts: # quest/m1/interop-js-tone.md
|
Merge summary:
(Written by Claude Opus 5.5) |
Problem
The browser interop tone check spent its 3 s grace while the player's audio ring was refilling. A later refill could therefore fail valid audio as silence or the wrong tone under CPU starvation.
Approach
Accumulate the grace from fresh page observations while the audio context is running and the player is unstalled. Buffering and suspension pause the counter; silent or incorrect rendered audio still exhausts it. Reject analyser residue during a stall and preserve the observation that failed for the wrong-tone diagnostic. The overall interaction deadline stays unchanged.
Choices: use the player's stalled state rather than RMS to decide when playback spends grace, so digital silence still fails promptly. Count cumulatively across refills rather than restarting the grace.
Impact
Validation
just ciandquest check --base origin/mainpassed.Alternatives
A longer wall-clock deadline would still charge buffering and would slow the wrong-tone control. Resetting grace on each refill would let repeated stalls postpone a real failure indefinitely.
Follow-ups
An initial eight-run/two-CPU experiment hit an unrelated concurrent
bun installlinking race; the available main browser cells passed. No production behavior or dependency changes are included.(Written by GPT-6)