Repository navigation
fix(net): a lowered resume floor backfills from the serving route #6759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ed66f97
chore(quest): claim quest/m1/resume-floor.md
kixelated 95ea6b3
fix(net): a lowered resume floor backfills from the serving route
kixelated 3dd323c
fix(net): mirror the resume floor backfill in js and finish the quest
kixelated 4d645aa
Merge origin/main into quest/m1/resume-floor
kixelated 0b68937
test(js): drive the lowered-floor test on a manual clock
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎 Supported by static analysis
Script executed:
Repository: moq-dev/moq
Length of output: 42773
Script executed:
Repository: moq-dev/moq
Length of output: 27955
Script executed:
Repository: moq-dev/moq
Length of output: 24775
Defer lowered-floor backfill until a serving route exists.
Route.park()clears the route source but retains each reader copy. IfwithRangelowers the floor while the front is parked,#backfill()sends the request to the departed copy from#copies.at(-1). The next serving copy starts at#newest, so the newly covered interval is not requested again if the departed copy cannot serve it.Keep the uncovered interval pending while no route serves, then request it from the new serving route during
sync().