Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 17 additions & 21 deletions quest/m1/interop-coverage/js-namespace-done.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,27 @@

## Goal

Condition: the next `@moq/net` patch release, 0.4.6 or later, ships from
`release` carrying [moq-dev/moq#6518](https://github.com/moq-dev/moq/pull/6518),
the JS-only `release` backport of
[moq-dev/moq#5483](https://github.com/moq-dev/moq/pull/5483). It merged as
`350dee5520` after the 0.4.5 bump
([moq-dev/moq#6501](https://github.com/moq-dev/moq/pull/6501)) had shipped
without it. Check that `npm view @moq/net version` is above 0.4.5 and that
`git log origin/release -- js/net/package.json` shows the bump to it after
`350dee5520`. Releases are cut separately; this quest bumps nothing.

Then bump `@moq/net` in the moq-dev-js client of
[englishm/moq-interop-runner](https://github.com/englishm/moq-interop-runner)
to it, so `subscribe-namespace-lifecycle` passes against Cloudflare
draft-18 and aiomoqt, and delete this quest once that PR merges.
Condition: [englishm/moq-interop-runner#177](https://github.com/englishm/moq-interop-runner/pull/177)
merges and the runner republishes the moq-dev-js client image. That PR,
from an outside contributor, bumps the moq-dev-js client's `@moq/net` from
0.4.4 to 0.4.6, which carries
[moq-dev/moq#6518](https://github.com/moq-dev/moq/pull/6518) and withdraws
namespaces with a reset. Check it with
`gh pr view 177 -R englishm/moq-interop-runner --json state`, then confirm
`subscribe-namespace-lifecycle` passes for moq-dev-js against Cloudflare
draft-18 and aiomoqt in the next runner nightly. Delete this quest once it
does.

## Plan

`@moq/net` 0.4.5 and earlier withdraw a PUBLISH_NAMESPACE on drafts 17+
with FIN plus STOP_SENDING, which draft-18 §3.3.2 does not allow. Both
relays end the namespace only on RESET_STREAM, so the subscriber never sees
NAMESPACE_DONE until the publisher's session closes. The case passed from
two processes only because the exiting publisher closed its session. `main`
has sent the reset since #5483, and the runner's client passes against both
relays when built on `main` or on #6518. The Rust client already passes, so
the maintainer kept the backport JS-only.
NAMESPACE_DONE until the publisher's session closes. 0.4.6 shipped from
`release` with the backport, so no moq release is needed.

The interop audit's standing approval covers PRs touching the `moq-dev-*`
builds.
Do not open a competing runner PR. If #177 stalls, nudge it there; the
interop audit's standing approval covers PRs touching the `moq-dev-*`
builds. Its author tested only against moq-go, so if the nightly still
fails against Cloudflare draft-18 or aiomoqt, debug that relay pairing
with a client built from `main`.
Loading