Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions js/json/src/snapshot/consumer.loss.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
import { expect, test } from "bun:test";
import { Error as NetError, StreamCode, Track } from "@moq/net";
import { Consumer } from "./consumer.ts";

const frame = (json: string) => ({
payload: new TextEncoder().encode(json),
});

for (const method of ["next", "latest"] as const) {
test(`snapshot ${method} resumes after an established group is missing`, async () => {
const track = new Track.Producer("catalog.json");
const consumer = new Consumer<{ value: number }>({ track: track.subscribe() });
const first = track.appendGroup();
first.writeFrame(frame('{"value":1}'));
expect((await consumer[method]())?.value).toEqual({ value: 1 });

const pending = consumer[method]();
// Before lite-07, SUBSCRIBE_DROP reports a missing group as NotFound.
first.close(new NetError.Stream(StreamCode.NotFound, { message: "dropped" }));
const replacement = track.appendGroup();
replacement.writeFrame(frame('{"value":2}'));
replacement.close();
track.close();

expect((await pending)?.value).toEqual({ value: 2 });
});

for (const established of [false, true]) {
test(`snapshot ${method} reports terminal track NotFound (${established ? "established" : "missing"})`, async () => {
const track = new Track.Producer("catalog.json");
const consumer = new Consumer<{ value: number }>({ track: track.subscribe() });
if (established) {
track.appendGroup().writeFrame(frame('{"value":1}'));
expect((await consumer[method]())?.value).toEqual({ value: 1 });
}

const pending = consumer[method]();
const failure = new NetError.Stream(StreamCode.NotFound);
track.close(failure);
await expect(pending).rejects.toBe(failure);
});
}

test(`snapshot ${method} refuses malformed JSON after a good value`, async () => {
const track = new Track.Producer("catalog.json");
const consumer = new Consumer<{ value: number }>({ track: track.subscribe() });
const group = track.appendGroup();
group.writeFrame(frame('{"value":1}'));
expect((await consumer[method]())?.value).toEqual({ value: 1 });

group.writeFrame(frame('{"value":'));
group.close();
track.close();
await expect(consumer[method]()).rejects.toBeInstanceOf(SyntaxError);
});
}
3 changes: 3 additions & 0 deletions js/json/src/snapshot/consumer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import { Decoder } from "./decoder.ts";
import type { Config as CodecConfig } from "./encoder.ts";

const GAPS: Moq.StreamCode[] = [
// Before lite-07, SUBSCRIBE_DROP reports a missing group as NotFound.
// This only handles a failed group read; a track refusal still propagates.
Moq.StreamCode.NotFound,
Moq.StreamCode.TooFarBehind,
Moq.StreamCode.Old,
Moq.StreamCode.Evicted,
Expand Down
Loading