Repository navigation
quest: lean defaults with a release feature; Media Foundation adapter pick #6835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # [M] Media Foundation encodes on the texture's adapter | ||
|
|
||
| ## Goal | ||
|
|
||
| On a Windows machine with more than one GPU, `moq-studio`'s program reaches a | ||
| hardware Media Foundation encoder on the GPU route: the encoder is enumerated | ||
| on the adapter that owns the exported texture, rather than being passed over | ||
| for a readback encoder because Media Foundation picked another GPU. | ||
|
|
||
| ## Plan | ||
|
|
||
| Builds on `moq_video::render::export` from | ||
| [moq-dev/moq#6805](https://github.com/moq-dev/moq/pull/6805); start after it | ||
| merges. That PR's exporter probes each candidate encoder with a frame | ||
| exported from the drawing device, and passes over a Media Foundation encoder | ||
| that sits on a different adapter. Enumerate with `MFTEnum2` instead of | ||
| `MFTEnumEx`, passing an `IMFAttributes` store whose `MFT_ENUM_ADAPTER_LUID` | ||
| is the texture's adapter, so the probe finds a hardware encoder that reads it. An explicitly named encoder that still cannot read the device | ||
| fails at setup, as it does today. | ||
|
|
||
| Decided 2026-10-26 (maintainer): m2, beside Direct3D11 import. It changes no | ||
| public API, so it does not need to land before the cut, and it needs a | ||
| Windows machine with two GPUs to prove: an ignored hardware test plus an | ||
| entry in [Hardware validation](/quest/m3/video-hardware.md) if CI cannot run | ||
| it. | ||
|
|
||
| Public API: none. Wire: none. | ||
|
|
||
| ## Related | ||
|
|
||
| - [Direct3D11 render import](/quest/m2/render-d3d11.md) - the other Windows half of keeping the studio's pictures on the GPU | ||
| - [Studio](/quest/m3/studio/README.md) - the app whose program this encodes | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.