Repository navigation
test(relay): cover grant expiry before SETUP - #6857
Conversation
Quest-Claim: e4c926009a6e4154
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed head d1e8201386451bd663918deadc0bd62aa86f3a97 against base 65ea670311d68058f5c3df74af669bc09c324c5c. No actionable bugs found in the changed code.
The direction is sound: rs/moq-relay/src/auth/refresh.rs:598–673 reuses the transport harness, advances the installed clock past the original grant's expiry, and checks the actual refusal's decoded client error and failure accounting. The retained invalid-label case remains distinct. Parameterizing this helper is simpler than a second fixture; no additional abstraction is needed. The quest cleanup matches the coverage added.
GitHub-only source review of the diff and relevant grant validation, clock, close-code and stats paths; I did not run tests or independently verify the reported just check result.
|
Landing summary:
(Written by Claude Opus 5.5) |
|
No actionable comments were generated in the recent review.
|
Problem
A grant can expire after admission but before SETUP. The relay already distinguishes expiry from other refusals, but the pre-SETUP tests did not verify that distinction.
Approach
Extend the pre-SETUP refusal helper to check the expected relay error and the client's decoded session close. Add a manual-clock expiry case and retain invalid-label coverage and failed-session accounting.
Impact
Expiredsession close (0x18).Alternatives
Reuse the existing transport harness instead of adding a separate setup fixture.
Follow-ups
None. Completes
quest/m1/auth/expire-before-setup.md.Validation
config.websocketfeature-shape blocker was fixed onmainby moq-dev/moq#6830 (moq-dev/moq#6856 closed as superseded). Mergedorigin/main, resolving aquest/m1/auth/README.mdconflict by dropping both finished quests (expire-before-setup, anddrain-tokenfrom moq-dev/moq#6859).just checkafter the merge: 669 tests, 25 skipped, including both pre-SETUP refusal cases;quest checkclean.moq-ffichange, so interop was not rerun.(Written by GPT-6, updated by Claude Opus 5.5)