Skip to content

quest(ci): deprioritize moving unit tests out of moq-net - #6893

Merged
kixelated merged 5 commits into
mainfrom
quest/m0/ci/test-layout
Oct 27, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m0/ci/test-layout

Conversation

@kixelated

@kixelated kixelated commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

quest/m0/ci/test-layout.md asked whether moving moq-net's inline unit tests to external harnesses ([lib] test = false) would save CI CPU by not compiling the library twice. A first pass found no evidence of savings and a large migration cost. Its raw audit was not worth committing.

Approach

  • Keep the inline test layout and deprioritize the quest instead of closing it.
  • Rewrite the quest to the conclusion, the few facts a revisit needs (about half of moq-net is test code, ~2.7k library tests, ~1k name private items with no test-support surface to reach them, the fuzz feature is public and async-only, the prototype measured nothing on a loaded host, several recipes select library tests by name), and what would have to be true to revisit.
  • Update its line in the CI epic's Required list, where it is already last.
  • Drop the committed audit (.github/test-layout-audit.{json,md}) from the diff.

Choices made without asking: deprioritize rather than delete, and keep it in m0/ci (quest mv refuses to move a quest with an open PR). Moving it to m3 or deleting it later is a one-line follow-up.

Impact

None: quest-only.

Alternatives

  • Delete the quest: loses the revisit conditions, though the audit stays in this PR's history.
  • Move it to m3 (speculative work): the natural home, but not possible in this PR.

Follow-ups

None created.

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 26, 2026 15:43
Quest-Claim: fdffba158bc17d69
Co-Authored-By: GPT-6 (Codex) <noreply@openai.com>
@kixelated kixelated changed the title Measure moving unit tests out of hub crates docs(ci): checkpoint hub test-layout inventory and probe Oct 26, 2026
kixelated and others added 2 commits October 26, 2026 21:47
Drop the committed audit; keep only its conclusion and the facts a revisit needs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title docs(ci): checkpoint hub test-layout inventory and probe quest(ci): deprioritize moving unit tests out of moq-net Oct 27, 2026
@kixelated
kixelated marked this pull request as ready for review October 27, 2026 04:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T05:05:09.657149Z 7e30b09 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: bd04744

No actionable bugs found. The documentation-only direction is sound: retain the simpler inline test layout until controlled measurements justify migration, while preserving feature-boundary and test-selection requirements. The CI epic and quest agree on that decision; no runtime, build, or test configuration changes are introduced.

Verification: inspected both changed documents and the relevant moq-net feature definitions and net-features script. Did not run tests, reproduce the prototype, or independently recount the historical test inventory; no performance improvement is asserted.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing bd04744. Per the maintainer: dropped the committed audit (.github/test-layout-audit.{json,md}), rewrote the quest to its conclusion (keep inline unit tests), the facts a revisit needs, and the revisit conditions, and deprioritized it rather than deleting it. It stays in m0/ci because quest mv refuses while this PR is open; moving it to m3 or deleting it is a later one-line choice. Codex had no findings on this head; quest check and just check pass locally.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 27, 2026
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fa9da9c7-1a8b-4d9a-bfce-29fddba1a522
Commits

Reviewing files that changed from the base of the PR and between 6d55fb4 and bd04744.

Files selected for processing: 2
  • quest/m0/ci/README.md
  • quest/m0/ci/test-layout.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged origin/main (7e30b09) to clear the conflict from moq-dev/moq#6881 in quest/m0/ci/README.md. Kept both Required entries, with the new slow-tests quest ranked above this now-deprioritized one so it stays last. quest check and just check pass; Codex reacted 👍 on the new head. Landing.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 71b01c7 Oct 27, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m0/ci/test-layout branch October 27, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant