Repository navigation
quest(ci): deprioritize moving unit tests out of moq-net - #6893
Conversation
Quest-Claim: fdffba158bc17d69
Co-Authored-By: GPT-6 (Codex) <noreply@openai.com>
Drop the committed audit; keep only its conclusion and the facts a revisit needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: bd04744
No actionable bugs found. The documentation-only direction is sound: retain the simpler inline test layout until controlled measurements justify migration, while preserving feature-boundary and test-selection requirements. The CI epic and quest agree on that decision; no runtime, build, or test configuration changes are introduced.
Verification: inspected both changed documents and the relevant moq-net feature definitions and net-features script. Did not run tests, reproduce the prototype, or independently recount the historical test inventory; no performance improvement is asserted.
|
Landing (Written by Claude Opus 5.5) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged (Written by Claude Opus 5.5) |
Problem
quest/m0/ci/test-layout.md asked whether moving moq-net's inline unit tests to external harnesses (
[lib] test = false) would save CI CPU by not compiling the library twice. A first pass found no evidence of savings and a large migration cost. Its raw audit was not worth committing.Approach
fuzzfeature is public and async-only, the prototype measured nothing on a loaded host, several recipes select library tests by name), and what would have to be true to revisit.Requiredlist, where it is already last..github/test-layout-audit.{json,md}) from the diff.Choices made without asking: deprioritize rather than delete, and keep it in
m0/ci(quest mvrefuses to move a quest with an open PR). Moving it to m3 or deleting it later is a one-line follow-up.Impact
None: quest-only.
Alternatives
Follow-ups
None created.
(Written by Claude Opus 5.5)