Skip to content

refactor(net): name the dial credential presentation - #6962

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/api-audit/dial-credential
Oct 28, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m1/api-audit/dial-credential

Conversation

@kixelated

@kixelated kixelated commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The internal JS dial credential shares its name with the public auth.Credential, forcing the public import to be aliased as Presented.

Approach

Use the quest's suggested Presentation name for the internal dial record and its callers, restoring the public Credential import. The former Rust duplicate in moq-tokio/src/connect/token.rs was already removed by moq-dev/moq#6834, so no Rust replacement is needed. Remove the completed quest.

Impact

  • Public API: none; Presentation is internal and API reports remain unchanged.
  • Wire: none.

Validation

just ci and git diff --check pass, including the selected JS checks, builds/API reports, and tests.

Alternatives

Keep distinct names by role rather than introducing another import alias or duplicating the removed Rust abstraction.

Follow-ups

None.

(Written by GPT-6)

kixelated and others added 2 commits October 27, 2026 17:10
@kixelated kixelated changed the title One meaning for Credential refactor(net): name the dial credential presentation Oct 28, 2026
@kixelated
kixelated marked this pull request as ready for review October 28, 2026 00:31
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 112974c2-e5d9-4667-bd79-d7e17d4709f6
Commits

Reviewing files that changed from the base of the PR and between e5b84dd and 5cb156f.

Files selected for processing: 4
  • js/net/src/connection/connect.ts
  • js/net/src/connection/tokens.ts
  • quest/m1/api-audit/README.md
  • quest/m1/api-audit/dial-credential.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T00:32:49.521601Z 5cb156f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 5cb156f

No actionable bugs found. Naming the internal dial record Presentation cleanly distinguishes it from the public auth.Credential, removes the import alias, and leaves the token-selection and lifetime logic unchanged. This is a suitably small refactor; no additional abstraction is needed.

Verification: static review of the complete diff, the auth type, and dial/token call sites. I did not run builds or tests.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: Codex reviewed head 5cb156f with no findings, and the automated OpenAI review found nothing actionable. CI passed (12/12). quest check against origin/main passed, and the finished quest quest/m1/api-audit/dial-credential.md and its link are removed. No changes or decisions were needed during merge. Squash-merging via the merge queue.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit e2a8a7a Oct 28, 2026
12 checks passed
@kixelated
kixelated deleted the quest/m1/api-audit/dial-credential branch October 28, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant