Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions js/net/src/lite/subscriber.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1090,3 +1090,34 @@ test("closing a broadcast while TRACK_INFO is pending leaves no unhandled reject
subscriber.close();
}
});

// A peer can start mid-group, but this release has no way to preserve those frame indices.
test("a nonzero lite frame start is refused before publishing the group", async () => {
const { quic, streams, opened } = fakeSession();
const subscriber = new Subscriber(quic, Version.DRAFT_07, HopSchema.parse(1n));
const broadcast = subscriber.consume(Path.from("room"));
const track = broadcast.track("video").subscribe();
const ordered = track.ordered();
const reader = new Reader(
new ReadableStream({ start: (controller) => controller.close() }),
undefined,
Version.DRAFT_07,
);
try {
await opened(0);
await answerTrackInfo(streams[0], Version.DRAFT_07);
await (await opened(1)).reading;
const next = ordered.nextGroup();
await expect(
subscriber.runGroup(new Group({ subscribe: 0n, sequence: 0, frameStart: 5 }), reader),
).rejects.toThrow("group 0 starts at frame 5");
ordered.close();
expect(await next).toBeUndefined();
} finally {
reader.stop(new Error("test complete"));
ordered.close();
track.close();
broadcast.close();
subscriber.close();
}
});
6 changes: 6 additions & 0 deletions js/net/src/lite/subscriber.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,12 @@ export class Subscriber {
return;
}

// This reader cannot preserve a partial group's frame indices, so refuse it before
// publishing anything that would number its first received frame as zero.
if (group.frameStart !== 0) {
throw new ProtocolViolation(`group ${group.sequence} starts at frame ${group.frameStart}`);
}

const { track, timescale, tail } = entry;
const producer = new netGroup.Producer(group.sequence);
const read = tail.open(group.sequence);
Expand Down
Loading