Repository navigation
quest: plan the second batch of 2026-10-27 follow-ups #6998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # [S] Runner VM test under load | ||
|
|
||
| ## Goal | ||
|
|
||
| `checks.x86_64-linux.github-runner-vm` (`nix/runner/test.nix`) passes in | ||
| every merge group it runs in, and a failed flake check prints the full log | ||
| of the failing derivation so the failing subtest is named. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-28 (maintainer): an m0 flake quest, fixed at its cause. | ||
|
|
||
| - It failed once, in merge-group run | ||
| [40609795466](https://github.com/moq-dev/moq/actions/runs/40609795466), | ||
| which dropped [moq-dev/moq#6934](https://github.com/moq-dev/moq/pull/6934) | ||
| from the queue. The PR did not change the derivation, and it passed when | ||
| built locally (10 subtests, about 4 minutes). | ||
| - It rarely runs: in 18 earlier merge groups on `nixos-moq-ci` the result was | ||
| already in the runner's store (`built=0`). This time it had been collected, | ||
| so it rebuilt, probably alongside the heavy `check rs` and `test rs` work. | ||
| - `sh/dispatch.sh` runs `nix flake check` without `-L`, so the log kept only | ||
| the last 25 lines (QEMU cleanup). First make a failed check print the full | ||
| build log (`-L`, or `nix log` on failure), so the next failure names its | ||
| subtest. | ||
| - Then reproduce under the same contention (rebuild with the store result | ||
| removed while a Rust test run loads the host) and fix the subtest at its | ||
| cause, not with a longer timeout. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # [S] An HLS viewer starts capture | ||
|
|
||
| ## Goal | ||
|
|
||
| `moq publish` starts capturing a rendition when its only subscriber is an HLS | ||
| export, so an HLS-only viewer gets media. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-28 (maintainer), from | ||
| [moq-dev/moq#6937](https://github.com/moq-dev/moq/pull/6937), which made HLS | ||
| records on by default: a subscriber to a rendition's record track counts as | ||
| demand for that rendition's media. | ||
|
|
||
| - `moq publish` encodes on demand from media-track demand | ||
| (`rs/moq-cli/src/publish.rs`), but the HLS export reads a rendition's | ||
| records before subscribing to its media, so the record subscriber alone | ||
| never starts capture. This was already true with `--hls` before #6937. | ||
| - Make record-track demand reach the media's demand where records are | ||
| produced (`rs/moq-mux/src/hls.rs`), so every on-demand publisher benefits, | ||
| not only the CLI. The demand ends when the record track's last subscriber | ||
| leaves. | ||
| - Test an HLS-only viewer against `moq publish`: capture starts and segments | ||
| appear. | ||
|
|
||
| Public API: none expected. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # [S] Settled copies versus whole groups | ||
|
|
||
| ## Goal | ||
|
|
||
| Every check in moq-net's model that asks whether a group is done uses the | ||
| meaning it needs: a copy whose writer finished (`Handle::is_settled`) or the | ||
| whole group reaching its end (`is_finished`). A finished bounded copy is | ||
| never mistaken for the whole group, and never kept open as unfinished. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-28 (maintainer), from | ||
| [moq-dev/moq#6922](https://github.com/moq-dev/moq/pull/6922): audit every | ||
| caller at once instead of fixing them as reviews find them. Three review | ||
| rounds on #6922 each fixed one site (track teardown, the track's clean end, | ||
| and uncached copies). | ||
|
|
||
| - List every `is_finished`, `is_settled`, `serves_end`, and `cut` caller in | ||
| `rs/moq-net/src/model/` and state which meaning each needs. | ||
| - `tear_down`'s `open` and `lookup.retain` still use whole-group | ||
| `is_finished`. That looks deliberate, since a bounded copy does not serve | ||
| the group's end, but confirm it. | ||
| - Each wrong caller gets a test that fails before its fix. Callers that are | ||
| right need no test. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # [S] Replaced producers retire their records | ||
|
|
||
| ## Goal | ||
|
|
||
| An application that keeps replacing a rendition's producer on one broadcast | ||
| does not keep one HLS record track per replacement until the broadcast ends. | ||
| moq-video, moq-audio, moq-ffi, and moq-c retire a replaced producer's | ||
| records, as the container importers and `moqsink` do since | ||
| [moq-dev/moq#6937](https://github.com/moq-dev/moq/pull/6937). | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-28 (maintainer): m2, since the churn comes from the local | ||
| application, not a network peer. | ||
|
|
||
| - Each of these mints a fresh track name per producer. Call | ||
| `moq_mux::catalog::Producer::retire` when a producer is replaced or | ||
| dropped mid-broadcast, after its last frame is flushed and its recorder is | ||
| released (`retire` errors while the recorder is alive). | ||
| - Keep #6783's rule that a dropped rendition's name can return with its | ||
| record numbering continued: only the owner that minted a name retires it. | ||
| - Test repeated replacement in each: record tracks stay flat. | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
|
|
||
| Public API: none expected; the bindings may document that replacing a | ||
| producer ends its records. Wire: none. | ||
|
|
||
| ## Related | ||
|
|
||
| - [Re-init retires timelines](/quest/m2/reinit-retire.md) - the same bound for fMP4 and MKV re-inits | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.