Repository navigation
quest: plan follow-ups from the main-vs-release audit #7004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f0e8566
7649952
6b71312
1cee2d1
bc57263
5d5e7ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,53 @@ | ||||||
| # [S] moq-quic has every quinn fix it needs | ||||||
|
|
||||||
| ## Goal | ||||||
|
|
||||||
| moq-quic, moq-sock's `udp`, and moq-tokio's `quic::driver` carry every | ||||||
| security and correctness fix quinn has landed since the last sync, each | ||||||
| ported with its regression test or recorded as not applying. The fork | ||||||
| ledger in `rs/moq-quic/README.md` says how far upstream was checked. | ||||||
|
|
||||||
| ## Plan | ||||||
|
|
||||||
| Decided 2026-10-27 (maintainer), from a second audit of main against | ||||||
| release: the hard fork never merges upstream and cargo-deny cannot see a | ||||||
| quinn advisory in in-tree code, so checking upstream is recurring work. | ||||||
|
|
||||||
| Each run: | ||||||
|
|
||||||
| - Compare quinn-rs/quinn `main` against the last checked commit (the fork | ||||||
| point [`7616e6b2`](https://github.com/quinn-rs/quinn/commit/7616e6b2782722f3ce4a1b181ef08817d7f545e4) | ||||||
| for the first run), plus quinn's GitHub security advisories. | ||||||
| - Port each fix that applies to code the fork still carries, with its | ||||||
| regression test, and list it under the README's ported commits. Record | ||||||
| one that does not apply with its reason, as the README already does. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Record every non-applicable fix. The Goal requires each fix to be ported or recorded as not applying. The Plan currently says to record Proposed wording
Committable suggestion
|
||||||
| Skip dependency bumps. | ||||||
| - Record the newest upstream commit checked in the README, so the next run | ||||||
| starts there. | ||||||
|
Comment on lines
+25
to
+26
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make the last-checked commit explicit. The Quinn sync procedure requires each run to record the newest checked commit in
|
||||||
|
|
||||||
| First run: three fixes on quinn `main` are not in the ledger yet. Check | ||||||
| each against the fork's code before porting, since a missing ledger entry | ||||||
| does not prove the bug remains: | ||||||
| [`f233510c`](https://github.com/quinn-rs/quinn/commit/f233510c) (honor a | ||||||
| disabled idle timeout when accepting), | ||||||
| [`6c69f9f4`](https://github.com/quinn-rs/quinn/commit/6c69f9f4) (don't | ||||||
| credit a reset stream's unread data twice on stop; the fork rewrote `stop` | ||||||
| under the README's "Stream credit on stop", so it may already hold), and | ||||||
| [`623a0369`](https://github.com/quinn-rs/quinn/commit/623a0369) (don't make | ||||||
| specific IPv6 endpoints dual-stack). | ||||||
|
|
||||||
| Recurrence: the PR that finishes a run deletes this file and creates the | ||||||
| next run at `/quest/m2/quinn-sync.md`, linked from `/quest/m2/README.md`'s | ||||||
| `Required`. It keeps this Goal and recurrence paragraph, carries forward | ||||||
| what this run learned, and requires [the release cut](/quest/m2/release/cut.md). | ||||||
| The cut removes itself from every `Required` and shifts m2 into m1, so the | ||||||
| next run becomes ready in the new m1, once per release cycle. Only | ||||||
| `/quest-delete` ends the recurrence. | ||||||
|
|
||||||
| Public API: none expected; a ported fix that changes one says so. Wire: | ||||||
| QUIC behavior follows upstream's fixes. | ||||||
|
|
||||||
| ## Related | ||||||
|
|
||||||
| - [moq-quic's API improves on quinn's](/quest/m1/quic-api/README.md) - renames that make each port a hand translation | ||||||
| - [Dependency audit](/quest/m2/audit-deps.md) - covers crates cargo-deny can see | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 6440
Define byte accounting and the overshoot rule.
The plan identifies only that queued bytes count. It does not define the byte set, whether admission uses the prospective queue size, or the maximum overshoot from an indivisible frame or source read. Since frames must not be refused, specify how this overshoot is bounded.