Repository navigation
quest: measure route-health stalls and propose the health contract #7096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dd2a488
chore(quest): claim quest/m2/route-health/design.md
kixelated 794fb34
test(net): measure delivery stalls that transport failure misses
kixelated 3a31c55
quest: record measured route-health stalls and propose the health con…
kixelated 7a6e6b9
Merge origin/main into quest/m2/route-health/design
kixelated 6db59ae
quest: settle the route-health contract and delete the design quest
kixelated 20b4158
test(moq-net): pin the age cut in the headers-only payload stall
kixelated b021fde
Merge remote-tracking branch 'origin/main' into HEAD
kixelated 43d61cd
quest: close the route-health gaps the review found
kixelated 10aaa1f
Merge branch 'base' into pr-7096
3f1ba40
test(net): follow route instance API in health fixtures
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 5682
Gate
meta: trueon peer support before sending it.The plan sends
meta: trueon the existingSUBSCRIBE, with no sender-side check that the peer supports it. The plan requires older negotiated protocols to explicitly report unsupported mode instead of emulating metadata-only delivery. A peer that ignores unknown fields cannot report anything. It can serve full payload for a metadata subscription. The health standby then receives media it did not request, and nothing signals that metadata mode was not accepted.Add an additive SETUP capability, or gate the field on a negotiated protocol version, before sending
meta: true. The repository convention forrs/moq-netstates: "New capabilities are additive SETUP extensions; receivers ignore unknown parameters."Source: Coding guidelines