Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m0/ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,5 @@ The historical samples locate candidates; they are not controlled benchmarks.
- [Padding runs](/quest/m0/ci/quic-padding.md) - moq-quic parses a PADDING run as one frame, keeping the padding stats' meaning
- [tracing-test filter](/quest/m0/ci/tracing-filter.md) - moq-tokio's tests stop forcing every crate to format at TRACE
- [Stats oversize](/quest/m0/ci/stats-oversize.md) - moq-stats refuses an oversized plain snapshot before parsing it back
- [Gate send-depth](/quest/m0/ci/send-depth-gate.md) - the merge gate runs send-depth on a pinned nightly when moq-net changes, after #6890 fixes main
- [Cargo aliases in nested checkouts](/quest/m0/ci/cargo-alias-strings.md) - `cargo build-ffi` and `cargo moq` work from a worktree nested inside another checkout
34 changes: 34 additions & 0 deletions quest/m0/ci/send-depth-gate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# [S] The merge gate runs send-depth

## Goal

A PR whose change deepens moq-net's native `Send` proofs past the default
recursion limit fails the merge gate, instead of turning Nightly red after it
lands. The check runs on a pinned nightly from the dev shell, so a toolchain
release alone never fails it.

## Plan

`just rs send-depth` runs only in Nightly, on whatever nightly
`dtolnay/rust-toolchain` installs. The gate never built it, so a deeper IETF
future failed Nightly every night from 2026-10-25 until
[moq-dev/moq#6890](https://github.com/moq-dev/moq/pull/6890). Land this after
that fix, since the check is red on `main` until then.

Decided 2026-10-28 (maintainer): gate it, because it is cheap. Measured on
2026-10-28: about 14 s cold and 9 s warm on a 24-core host, against a
21-minute median for the gate runs that select moq-net (26% of 144 runs
since 2026-10-25).

- Pin a dated nightly in the flake (rust-overlay already provides one) and
have `sh/rs/send-depth.sh` use it instead of rustup's latest; Nightly's
send-depth job uses the same pin. Bump the pin on purpose, like stable.
- Run it from `sh/rs/select.sh` beside `net-features`:
`if wants moq-net; then just rs send-depth; fi`, so it runs only when
moq-net or a workspace dependency of it changes.

Public API: none. Wire: none.

## Related

- [Measure the parallel frontend](/quest/m0/ci/nightly-levers.md) - also builds on a pinned nightly
2 changes: 2 additions & 0 deletions quest/m1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ removed).
- [Bindings name every session code](/quest/m1/ffi-malformed-auth-kind.md) - MALFORMED_AUTH_TOKEN and its siblings reach moq-ffi, moq-c, and the wrappers
- [Unbounded groups](/quest/m1/unbounded-groups/README.md) - groups and frames lose their size caps; a group keeps a 32 MB tail, and readers behind it replay through paced flights or refresh
- [Next Object on a cold Rust copy](/quest/m1/next-object-cold-copy.md) - a join after an upstream group report starts at the first frame received, never skipping
- [Lite track end at session death](/quest/m1/lite-track-end.md) - Rust and JS abort an ended lite track whose tail never settled, and agree on what declares the end
- [Legacy lite close drain](/quest/m1/lite-legacy-close-drain.md) - a lite-01..06 graceful close never cuts a final group the subscriber has not read
- [moqsrc max-delay](/quest/m1/gst-max-delay.md) - GStreamer's `moqsrc` takes a `max-delay` property instead of a hard-coded 1 s budget
- [moq-clock moves into kio::clock](/quest/m1/kio-clock.md) - moq-clock and its test macro become `kio::clock` and `#[kio::test]` before the cut publishes them
- [Poll-first async](/quest/m1/poll-first/README.md) - library crates compile no coroutines by default: async wrappers are generated from `poll_*` and gated behind an `async` feature
Expand Down
26 changes: 26 additions & 0 deletions quest/m1/lite-legacy-close-drain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# [S] A lite-01..06 graceful close delivers the final group

## Goal

A publisher's graceful close on lite-01..06 never cuts a final group the
subscriber has not read yet, over WebTransport and QMux, in Rust and JS.

## Plan

Found while landing [moq-dev/moq#6969](https://github.com/moq-dev/moq/pull/6969):
the JS publisher's drain waits only for the transport's FIN
acknowledgement. The mock resolves that once the bytes are queued at the
peer, and its close discards unread chunks; WebTransport likewise errors a
session's receive streams on close, dropping their unread bytes. lite-07's
subscriber FIN avoids this.

Decided 2026-10-28 (maintainer): m1, since lite-01..06 are published and a
graceful close losing data breaks what "graceful" promises.

Reproduce first, over real WebTransport and QMux, for the JS publisher and
the Rust publisher. Then make the drain wait until the subscriber has read
the final group, using a signal lite-01..06 already carries (such as the
subscriber closing its side of the stream). If those versions carry no such
signal, stop and report the options rather than add a wait on a timer.

Public API: none expected. Wire: none; published versions keep their wire.
37 changes: 37 additions & 0 deletions quest/m1/lite-track-end.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# [S] An ended lite track with an unsettled tail aborts at session death

## Goal

When a session dies after a lite publisher ended a track but before its tail
settled, Rust and JS both abort the track, and both end it cleanly once the
tail settled. Both agree on what declares the end.

## Plan

Found while landing [moq-dev/moq#6969](https://github.com/moq-dev/moq/pull/6969).
Rust lite marks a track ended on the subscribe stream's FIN, on every
version, and its cleanup then calls `finish()` without checking the tail:
`SubscriptionCleanup::abort` and `close`, and `ServeMode::Tail`'s
`ServeEnd::Finished`, in `rs/moq-net/src/lite/subscriber.rs`. JS declares
the end on SUBSCRIBE_END (and, after #6969, the FIN on lite-01..04), and
`track.Producer#close` downgrades an abort to a clean end only once the
declared end settled. Rust's IETF subscriber already aborts.

Decided 2026-10-28 (maintainer):

- Rust aborts like JS, since `finish()` on an unsettled tail reports
incomplete content as complete. Its cleanup always calls `abort` and relies
on `track::Producer::abort`'s existing downgrade when the declared end
settled. So does `ServeMode::Tail` when the session closes before the tail
settles: that branch returns `ServeEnd::Finished` today, which
`TrackServeRun` turns into `serving.finish()`, so it must abort instead.
- Align the end signal in both languages: SUBSCRIBE_END on lite-05+, the
stream FIN on lite-01..04. On lite-07 a bounded range also FINs, which must
not end the track.

Cover it with a test in each language for the settled and unsettled cases,
including Rust's `ServeMode::Tail` session close, and an interop case that
kills the session with groups unsettled.

Public API: none. Wire: none; behavior only. A Rust consumer of an
unsettled track sees the session error instead of a clean finish.
1 change: 1 addition & 0 deletions quest/m1/ts-reliability/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ catalog linger (#5305).
- [A small step back keeps the TS export's video](/quest/m1/ts-reliability/step-back.md) - the export re-acquires on a sub-group step back from any source instead of dropping its video
- [A stitched export survives a cancelled replacement](/quest/m1/ts-reliability/follow-cancel.md) - a follow window that ran out, then a cancelled replacement, ends cleanly without the selected-catalog panic
- [Decide whether a stitched export demotes its old leg](/quest/m1/ts-reliability/stitch-catch-up.md) - measure on the bufferbloat fixture whether demoting the old leg while the replacement acquires shrinks the switch's output hole, and land it if so
- [Shared PID stats](/quest/m1/ts-reliability/shared-pid-stats.md) - `ts::stats` counts a shared PID once in the shared parser, so its timing counts survive program changes

## Related

Expand Down
32 changes: 32 additions & 0 deletions quest/m1/ts-reliability/shared-pid-stats.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# [M] TS stats count a shared PID once

## Goal

`ts::stats` counts each PID once, in the parser every program shares, so a
PID two programs carry has one continuous set of TR 101 290 counters across
program starts and retirements. The multiplex totals read those counters
directly instead of rebuilding them from per-program copies.

## Plan

Found while landing [moq-dev/moq#6689](https://github.com/moq-dev/moq/pull/6689):

- Each program keeps its own counters for the PIDs it reads, and the
multiplex totals merge them, then subtract what a retiring program still
shares with a running one. Most of that PR's review churn came from this
merge-and-subtract logic.
- A program that starts after another on a shared PID retired counts that
PID's timing checks only from its own start. Where both run at once, the
larger count stands.

Decided 2026-10-28 (maintainer): one quest, since counting in the shared
parser both closes the timing gap and deletes the merge-and-subtract logic.
Keep #6689's outcomes: a retired program's final picture still counts, a
missing PMT still refuses after 0.5 s of program clock, and an unfinished
section on a PMT PID gets its bad CRC counted once. Extend the `ts_programs`
bench if the shared counters change its cost.

Rust: `rs/moq-mux` `container/ts/stats.rs`, `programs.rs`, `unclaimed.rs`.

Public API: none expected; if `ts::stats`' per-program view changes shape,
say how to migrate. Wire: none.
Loading