Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 6690926
No actionable bugs found. Centralizing the approach-first review guidance in REVIEW.md and having the opencode reviewer consume the base copy is a coherent, simpler direction than maintaining separate finding rules. The changes are limited to review instructions, with no runtime API or wire changes.
Verification: static inspection of all three changed files and the surrounding AGENTS.md, CONTRIBUTING.md, and PROMPTING.md guidance. I did not run a reviewer trial or tests; improved review quality remains an empirical claim, not something this inspection verifies.
(Written by OpenAI)
|
Two notes from a trial of the planned
(Written by Claude Opus 5.5) |
Problem
Codex cloud is being replaced by local reviews from the other vendor's model (kixelated/quest#267, adopted here by moq-dev/moq#7125).
quest reviewfeeds the base'sREVIEW.mdto the reviewer, and the repo had none.I audited about two months of review history (6,760 Codex findings, 2,396 CodeRabbit findings) and six weeks of local session transcripts. The bots catch edge-case bugs well, but almost never question the approach. Every "wrong approach" call came from the maintainer, late. Examples: "layering problem" on moq-dev/moq#3663, "seems like a hack" on moq-dev/moq#5030, and "take another stab at the API" on moq-dev/moq#3644. Meanwhile, PRs like moq-dev/moq#3506 went through 94 edge-case findings in 55 commits before closing.
Approach
REVIEW.mdis written for whichever model reviews (Codex, Claude, or hosted Claude Code Review), so it stays vendor-neutral and self-contained:AGENTS.mdand each nestedAGENTS.mdon the path to the changed files. Most tools only auto-load the ones above their working directory. The PR text is treated as claims to verify, and decisions recorded as the maintainer's are settled.git logshows a line of fixes), a simpler alternative, layering, long-term API and wire shape, completeness, and evidence. It is distilled from the maintainer's own pushback and the release-audit questions.AGENTS.md:path:linewith a concrete failure scenario, and a suggested fix has to follow the rules. Reviews should converge: an author's refutation stands without new evidence, and a run of edge-case rounds means the reviewer should judge whether the approach is overbuilt.AGENTS.mdgets a one-line pointer toREVIEW.md. The opencode review agent now reads the base'sREVIEW.mdinstead of keeping its own copy of the finding rules.A trial run of Codex with this file on moq-dev/moq#5030 returned one P1 finding and no nits. The finding is a real draft-20+ regression, and its suggested fix is at the ownership level. It still didn't say outright "this is a hack", so this is one data point, not proof.
Impact
Alternatives
quest reviewlands.AGENTS.mdin with@includes. Hosted Code Review only expands those on a branch it counts as protected.main's ruleset (merge queue, required checks) has no update restriction or required approval, so it doesn't count. Telling the reviewer to read the files works everywhere.Follow-ups
None. If hosted Claude Code Review is ever enabled, it would ignore any exclusions here until
maincounts as protected.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code