Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m0/ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,4 @@ The historical samples locate candidates; they are not controlled benchmarks.
- [Padding runs](/quest/m0/ci/quic-padding.md) - moq-quic parses a PADDING run as one frame, keeping the padding stats' meaning
- [tracing-test filter](/quest/m0/ci/tracing-filter.md) - moq-tokio's tests stop forcing every crate to format at TRACE
- [Stats oversize](/quest/m0/ci/stats-oversize.md) - moq-stats refuses an oversized plain snapshot before parsing it back
- [Cargo aliases in nested checkouts](/quest/m0/ci/cargo-alias-strings.md) - `cargo build-ffi` and `cargo moq` work from a worktree nested inside another checkout
25 changes: 25 additions & 0 deletions quest/m0/ci/cargo-alias-strings.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# [XS] Cargo aliases work in a nested checkout

## Goal

`cargo build-ffi` and `cargo moq` run correctly from a worktree nested inside
another moq checkout, such as an agent worktree under
`~/work/moq/.claude/worktrees/`.

## Plan

Found 2026-10-28 by [moq-dev/moq#7156](https://github.com/moq-dev/moq/pull/7156):
cargo reads every `.cargo/config.toml` from the working directory up, and
concatenates list values across files instead of overriding. In a nested
worktree both checkouts' list aliases join, so `build-ffi` becomes
`build --locked … build --locked …` and fails with "unexpected argument
'build'". Every C, C++, OBS, Kotlin, Go and Dart check fails locally for
agents. `cargo moq` duplicates the same way, but the copy lands after `--`.

Decided 2026-10-28 (maintainer): write the aliases in `.cargo/config.toml` as
strings, which override rather than concatenate. Check whether any other list
value there, such as the wasm32 `rustflags`, also duplicates harmfully. Add a
check that runs `cargo build-ffi --help` from a checkout nested inside
another. Agent worktrees stay where they are.

Public API: none. Wire: none.
5 changes: 5 additions & 0 deletions quest/m1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,14 @@ removed).
- [SUBSCRIBE honors the properties opt-out](/quest/m1/subscribe-timestamps.md) - the Rust publisher sends untimed objects to a SUBSCRIBE that declines Track Properties, and the Rust subscriber asks for them when it needs timestamps
- [JS FETCH timeout test](/quest/m1/js-fetch-timeout-test.md) - a JS joining FETCH still waiting on its SUBSCRIBE at the deadline is refused with TIMEOUT
- [JS joins at the current group](/quest/m1/ietf-js-join.md) - a late JS moq-transport subscriber gets the group in progress whole through a joining FETCH or fill, as Rust does
- [Rust marks a lost listed group unknown](/quest/m1/ietf-publisher-unknown-range.md) - the Rust IETF publisher sends End of Unknown Range for a listed group it can't serve, after the publisher's open quests land
- [Identity and recovery guide](/quest/m1/identity-guide.md) - explain epochs, pinned catalogs, lazy jobs, restart and version compatibility as they exist; takeover adds its own section
- [Native rung disable](/quest/m1/simulcast-rung-disable.md) - OBS stops sending the top renditions its grant cannot fund, as the Rust/FFI publishers do, and a shaped uplink through moq-ffi proves the resume
- [Audio jitter target](/quest/m1/audio-jitter-target/README.md) - the playout target is default in both languages; a manual browser proof and a native trace replay remain
- [A/V clock](/quest/m1/av-clock.md) - the audio playhead drives Sync.reference while audio plays, through per-track sync handles
- [Container reads drop backfill](/quest/m1/read-backfill.md) - the JS container consumer drops groups below its read cursor like Rust
- [Buffered playback subscribes in ascending order](/quest/m1/buffered-ascending.md) - a buffered `<moq-watch>` asks for the oldest group first, so a voice reply's opening arrives first, and audio's head hold shrinks to the floor
- [The publish controls stay visible without a preview](/quest/m1/publish-controls.md) - `<moq-publish>`'s controls no longer collapse with a live camera and no preview
- [Push-to-talk loses no speech](/quest/m1/push-to-talk/README.md) - consumers hold a disabled rendition, and an unmute encodes at once with the mic still open
- [Always-on encoding](/quest/m1/eager-encode/README.md) - publishers encode while enabled whatever the demand, so the past exists to fetch; on-demand is opt-in, and audio returns to it through a raw backbuffer
- [TS fidelity and recovery](/quest/m1/ts-reliability/README.md) - both modes have explicit profiles, automated validation, loss tests, and a dedicated guide
Expand All @@ -175,7 +177,10 @@ removed).
- [moq-clock's tests pass under cargo test](/quest/m1/clock-test-process.md) - `paused_runtimes_own_their_anchors` stops depending on being first in its process
- [kio's log tests pass in a workspace build](/quest/m1/kio-workspace-tests.md) - the eviction tests pass under the workspace's unified features, or eviction is fixed
- [The JS stalled-consumer eviction test ages its groups](/quest/m1/js-cache-age-test.md) - the test drives the clock the cache reads, so it can fail
- [moq-transport-22 FETCH cost](/quest/m1/ietf22-fetch-poll-cost.md) - #7042's +12.8% instructions on draft-22 FETCH is fixed or attributed
- [An idle track poll exits cheaply](/quest/m1/idle-poll-exit.md) - a reader's poll on a track with nothing new costs a small constant, not ~3,800 instructions
- [Main is no slower than release](/quest/m1/release-perf/README.md) - every benchmark where main is slower than release is fixed or accepted with a reason, checked by a final paired run before the cut
- [The browser baseline keeps its page logs](/quest/m1/baseline-page-logs.md) - a failing wasm-baseline cell is diagnosable from its artifact
- [Interop coverage](/quest/m1/interop-coverage/README.md) - the riskiest moq-transport features moq-net exposes get cross-implementation tests over drafts 18 and 22
- [Calibrate the paired nightly benchmarks](/quest/m1/bench-ci.md) - A/A and deliberately slowed Nightly runs set the paired comparison's threshold, so its regression alerts can be trusted
- [HLS and DASH segment conformance](/quest/m1/hls-conformance.md) - nightly ffprobe checks that advertised timing, sync flags, and bytes match the media served
Expand Down
21 changes: 21 additions & 0 deletions quest/m1/baseline-page-logs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# [XS] The browser baseline keeps its page logs

## Goal

`just test wasm-baseline` keeps the publisher and consumer page logs and the
binding's error reason in its artifact, so a failing cell can be diagnosed
from the artifact alone.

## Plan

Found 2026-10-28 by [moq-dev/moq#7135](https://github.com/moq-dev/moq/pull/7135):
the harness (`test/justfile`'s `wasm-baseline`) kept neither page's log, and
the binding's error reason was lost, so diagnosing an `evaluate:
MoqError.Internal` failure meant rebuilding that context locally.

Decided 2026-10-28 (maintainer): m1, since the baseline is a Nightly lane.

Write each page's console and the error reason beside the existing
diagnostics, and check the Nightly job uploads them.

Public API: none. Wire: none.
8 changes: 8 additions & 0 deletions quest/m1/bench-ci.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ lands; agents never dispatch Nightly.
- Check the paired legs' durations against their hour; the base build relies
on the mbx cache for the previous night's artifacts, and a cold one roughly
doubles each leg's build time.
- Each revision in a paired comparison needs its own `CARGO_TARGET_DIR`.
`bench/run.sh` already splits them (`target/bench/current` and
`target/bench/base`); the stale artifacts while attributing
[moq-dev/moq#7141](https://github.com/moq-dev/moq/pull/7141), such as a bench
linked against the other tree's library, came from an ad-hoc A/B of two
source trees sharing one. Say so in `bench/README.md`'s paired section, so an
A/B outside `run.sh` uses its base mode or a target per tree (decided
2026-10-28).

- Decide whether `bench/run.sh` pins glibc's malloc thresholds for every
Criterion target, as [moq-dev/moq#6727](https://github.com/moq-dev/moq/pull/6727)
Expand Down
1 change: 1 addition & 0 deletions quest/m1/c/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ Public API: moq-c gains each m1 binding feature. Wire: none.

- [moq-c decode start](/quest/m1/c/decode-start.md) - a moq-c decoder can read a finished track from its start
- [JSON windows](/quest/m1/c/json-window.md) - moq-c publishes and reads moq-json windows, as moq-ffi does
- [API gaps](/quest/m1/c/api-gaps.md) - one malformed-epoch error code, an audio enabled query, and a relay hops test
32 changes: 32 additions & 0 deletions quest/m1/c/api-gaps.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# [S] moq-c closes its small API gaps

## Goal

moq-c reports a malformed epoch the same way everywhere, lets a C consumer see
that audio is disabled as it can for video, and has a test of the hops on a
route received through a relay.

## Plan

Found 2026-10-28 by [moq-dev/moq#7151](https://github.com/moq-dev/moq/pull/7151)
and [moq-dev/moq#7156](https://github.com/moq-dev/moq/pull/7156).

Decided 2026-10-28 (maintainer): one PR for all three. moq-c already breaks
at this cut (0.6 to 0.7), so the error-code change rides that break.

- `moq_broadcast_request_prepare` reports a malformed epoch as
`MOQ_ERROR_INVALID_CODE`, while `moq_publication_announce`, which takes an
epoch in `moq_announce_route` since
[moq-dev/moq#7151](https://github.com/moq-dev/moq/pull/7151), reports a
malformed one as `MOQ_ERROR_INVALID_CONFIG`. Use
`MOQ_ERROR_INVALID_CONFIG` for both, with an Impact migration note.
- Add an audio counterpart to `moq_consume_video_enabled`, so a C app can tell
that a held audio rendition is disabled.
- Add a moq-c test that announces through a relay session and checks the
received route's `hops`.

Update `moq.h`, `rs/moq-c/README.md` and `doc/lib/c` as needed.

Public API: moq-c gains an audio enabled query and changes one error code.
Wire: none.

7 changes: 7 additions & 0 deletions quest/m1/drop-set.md
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,13 @@ case needs an update to arrive between START and the first group. Cover it
deterministically, through the track hooks rather than wire timing, when the
drop runs are reworked here.

### Cancelled fetches hold the end

Found 2026-10-28 by [moq-dev/moq#7149](https://github.com/moq-dev/moq/pull/7149):
a cancelled fetch below a track's end still holds the end open until the cache
expiry scan removes it, so how fast a subscription ends depends on expiry
timing. Settle it here, where cancelled and expired runs get a reason.

## Related

- [Subscribe ranges](/quest/m1/subscribe-ranges/README.md) - fills the cache miss an evicted run leaves
Expand Down
4 changes: 4 additions & 0 deletions quest/m1/eager-encode/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ The epic's own work, once the children land:
watching"), `doc/concept/use-case/contribution.md` (on-demand becomes an
option), the moq-c doc comment at `rs/moq-c/src/audio.rs:433`, and the
Swift/Python/Go/Dart wrapper docs.
- `@moq/room`'s docs: a joined room publishes through `Publish.Broadcast`, so
it now encodes the camera and microphone while `Local`'s `cameraEnabled` and
`microphoneEnabled` are on, even when nobody watches (found 2026-10-28 by
[moq-dev/moq#7143](https://github.com/moq-dev/moq/pull/7143)).
- Rewrite the quests that assume demand-gated capture:
[studio replay](/quest/m3/studio/replay.md) and its compose sources ("arm
replay = local subscriber"), [iOS capture](/quest/m2/mobile-capture-ios.md),
Expand Down
32 changes: 32 additions & 0 deletions quest/m1/idle-poll-exit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# [M] An idle track poll exits cheaply

## Goal

A reader's poll on a track with nothing new costs a small constant number of
instructions, not about 3,800, so catalog and media fanout scale with the
readers that have work rather than every pending reader.

## Plan

Found 2026-10-28 by [moq-dev/moq#7140](https://github.com/moq-dev/moq/pull/7140),
which moved the arrival-grace and clock checks behind the cheap "nothing
changed" checks in `Misses::judge`. Even at the old baseline, a pending catalog
poll costs about 3,800 instructions per reader, spread across the cursor's
poll path (`Cursor::probe` in `rs/moq-net/src/model/track.rs` and what it
calls) on a track with nothing new.

Decided 2026-10-28 (maintainer): m1, for relay fanout scale.

- Profile one idle poll with instruction counts (callgrind or
`perf stat --no-scale`) and find where the cost goes.
- Add one early exit the whole path shares, keyed on something every change
already bumps (for example a track revision the cursor last saw), rather
than a short-cut per function.
- Measure the moq-mux catalog fanout benches and the moq-net session benches
over tracks and readers, before and after.

Public API: none. Wire: none.

## Related

- [Mesh session cost](/quest/m2/perf/mesh-session-cost.md) - per-session costs in the same model
39 changes: 39 additions & 0 deletions quest/m1/ietf-publisher-unknown-range.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# [S] The Rust IETF publisher marks a lost listed group unknown

## Goal

When the Rust moq-transport publisher has listed a group in a FETCH answer or
a draft-22 fill but can no longer serve it, it sends End of Unknown Range
(`0x10C`) for that group on drafts 18 and 22, as the JS publisher does, instead
of skipping it silently.

## Plan

Found 2026-10-28 by [moq-dev/moq#7150](https://github.com/moq-dev/moq/pull/7150),
which fixed the JS publisher. In `rs/moq-net/src/ietf/publisher.rs` Rust skips
such a group in two places: the FETCH answer loop in `serve_fetch_stream`, on
`NotFound | NotFetchable | Unsupported | Old`, and `run_fill`, when
`fetch_group` fails with the same errors.

Rust can refetch from upstream, so a skip there means a failed refetch rather
than only an eviction. `NotFound` and `Old` map to `0x10C`. Decide in the PR
whether `Unsupported` and `NotFetchable` mean "unknown" too, or need their own
handling, and record the reason.

Decided 2026-10-28 (maintainer): it starts after the three quests below land,
since each edits the same publisher. The third was IETF fill timeout, which
[moq-dev/moq#7194](https://github.com/moq-dev/moq/pull/7194) dropped for
[one group](/quest/m1/ietf-publisher-one-group.md); that quest edits the same
paths, so it takes the slot. Once it lands, a FETCH or fill lists at most one
group, so this marks that one group.

Tests: a listed group evicted before it is written, for FETCH on drafts 18
and 22 and for a draft-22 fill, each failing before the fix. Run `just test interop --all` if the framing order changes.

Public API: none. Wire: none; the marker exists in both drafts.

## Required

- [Rust FETCH parity](/quest/m1/ietf-fetch-parity.md) - edits the same FETCH answer path
- [Our moq-transport publishers serve at most one group](/quest/m1/ietf-publisher-one-group.md) - narrows the same FETCH answer and fill paths to one group
- [SUBSCRIBE honors the properties opt-out](/quest/m1/subscribe-timestamps.md) - edits the same publisher
34 changes: 34 additions & 0 deletions quest/m1/ietf22-fetch-poll-cost.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# [M] moq-transport-22 FETCH costs what it did before the waiter refactor

## Goal

A moq-transport-22 FETCH of 256-frame groups costs no more instructions than
it did before [moq-dev/moq#7042](https://github.com/moq-dev/moq/pull/7042), or
the remaining cost is attributed to work the refactor needs and recorded in
its PR. Other versions and group sizes don't regress.

## Plan

Found 2026-10-28 by the paired-relay measurements in
[moq-dev/moq#7141](https://github.com/moq-dev/moq/pull/7141): #7042
(`6eff65506e`, "transport polls take kio waiters through &self") adds +12.8%
instructions on moq-transport-22 FETCH of 256-frame groups (8.02M to 9.04M per
round). The commit before it measures the same as the head. It landed after the
range the 2026-10-28 Nightly compared, so the next paired Nightly may flag it.

Decided 2026-10-28 (maintainer): m1, not a Nightly blocker.

- Attribute with instruction counts (`perf stat --no-scale` pinned to one core
type, or callgrind), not wall time: the hosted runners and a busy host are
too noisy for a 13% delta. Give each revision its own `CARGO_TARGET_DIR`.
- Find which poll path the refactor made more expensive on draft 22's FETCH
(per-call waiter registration, extra polls, or a lost fast path), and fix it
at the cause without reverting the `&self` waiter API.
- Sweep the relay session bench's FETCH cases across lite-07, draft 18 and
draft 22, at 4- and 256-frame groups, and record before and after.

Public API: none. Wire: none.

## Related

- [Calibrate the paired nightly benchmarks](/quest/m1/bench-ci.md) - owns the gate's threshold if the Nightly flags this first
10 changes: 5 additions & 5 deletions quest/m1/moxygen-pin-bump.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ merges, `nix/moxygen.nix` pins a Moxygen that includes it,
`nix/moxygen-track-status.patch` is deleted, and the Moxygen interop and
conformance lanes still pass.

Check moxygen#264's state. Delete this quest once the patch is gone, or if
moxygen#264 lands before the patch reaches `main`.
Check moxygen#264's state. Delete this quest once the patch is gone.

## Plan

The patch is not on `main` yet:
[moq-dev/moq#6729](https://github.com/moq-dev/moq/pull/6729), still open, adds
it to `nix/moxygen.nix`'s `patches` and carries it until upstream lands it. Upstream's client has moved to draft-20 Location
The patch is on `main`:
[moq-dev/moq#6729](https://github.com/moq-dev/moq/pull/6729) (merged
2026-10-25) added it to `nix/moxygen.nix`'s `patches`, carried until upstream
lands it. Upstream's client has moved to draft-20 Location
Filters, so the profile patch the pin also applies needs rebasing in the same
bump. Run `just test interop --all` and the Moxygen smoke lane.

Expand Down
22 changes: 22 additions & 0 deletions quest/m1/publish-controls.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# [XS] The publish controls stay visible without a preview

## Goal

`<moq-publish>`'s controls stay visible when a camera is live but the element
shows no `<video>` or `<canvas>` preview.

## Plan

Found 2026-10-28 by [moq-dev/moq#7157](https://github.com/moq-dev/moq/pull/7157),
and present on main: the controls box is sized by whether a camera source
exists, not by whether a preview is showing, so it collapses to zero height
and the controls leave the screen. #7157's browser test added a `<video>`
preview to its page to work around it.

Decided 2026-10-28 (maintainer): m1.

Size the box by what it shows, and cover it in
`test/interop/clients/js/publish-ui.browser.ts` with a page that has no
preview.

Public API: none. Wire: none.
8 changes: 8 additions & 0 deletions quest/m1/push-to-talk/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,19 @@ only from queue overflow. Rerun the reporter's setup (100 ms RTT, 2% random
loss) only as a reproduction of the original numbers, not as acceptance.
Record both in the PR.

Also check failure recovery (found 2026-10-28 by
[moq-dev/moq#7157](https://github.com/moq-dev/moq/pull/7157)): unmuting used to
reopen the microphone, which made a new source and so recovered a failed
encoder. Capture now stays open, so only a device swap, a settings change or a
new `source` recovers one. Decide whether re-enabling should retry a failed
encoder, and record why.

## Required

- [JS consumers hold a disabled rendition](/quest/m1/push-to-talk/hold-js.md) - watch keeps a disabled audio or video rendition subscribed, and the hang spec says "should not select"
- [moqsrc holds a disabled rendition](/quest/m1/push-to-talk/hold-rs.md) - moqsrc keeps its reader running under the selection rule moq play and moq-mux already apply
- [`muted` and `invisible` keep capture open](/quest/m1/push-to-talk/mute.md) - the element disables only the encoder, so unmute skips getUserMedia and AudioContext setup
- [Watch caches audio codec support](/quest/m1/push-to-talk/audio-support-cache.md) - an unmute resumes audio without waiting on a support check

## Closes

Expand Down
17 changes: 17 additions & 0 deletions quest/m1/push-to-talk/audio-support-cache.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# [XS] Watch caches audio codec support

## Goal

`js/watch`'s audio source checks codec support once per rendition config, as
video does, so an unmute resumes the AudioContext without waiting on a support
check.

## Plan

Found 2026-10-28 by [moq-dev/moq#7155](https://github.com/moq-dev/moq/pull/7155):
the audio source re-checks codec support on every catalog change, while video
caches the result. So on unmute the AudioContext resumes only after a support
check of a few milliseconds, even though frames are already arriving. Share
the cache with video if that keeps it simpler.

Public API: none. Wire: none.
Loading
Loading