Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion quest/m1/api-audit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ Rejected in planning:

- [Two broadcast resolutions](/quest/m1/api-audit/resolve/README.md) - Rust, JS, and the bindings resolve a broadcast with `request(path, epoch)` or `follow(path, epoch)`, and every racy two-step caller is gone
- [Routes are the origin API](/quest/m1/api-audit/route/README.md) - apps announce exact or prefix routes through one `Route` handle that owns its broadcast and carries an `identity`, prefix routes can serve a held broadcast, and readers get a listing plus `follow`
- [moq-congestion's first-publish names](/quest/m1/api-audit/congestion-names.md) - `bbr3::Config`, `cubic::Config`, `Metrics`, `Factory`, and no `into_any`
- [@moq/net names the origin read side](/quest/m1/api-audit/origin-reader.md) - `Origin.Reader`, which `Origin.Table` extends, replaces `Pick` lists

## Related
Expand Down
39 changes: 0 additions & 39 deletions quest/m1/api-audit/congestion-names.md

This file was deleted.

3 changes: 1 addition & 2 deletions quest/m1/quic-api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ error type per direction, terminal operations that consume their handle,
plain config structs, and no quinn compatibility baggage. Consumers lose the
workarounds quinn's shape forced on them.

Non-goals: the congestion controller API
([its names](/quest/m1/api-audit/congestion-names.md)), a
Non-goals: the congestion controller API, a
buffer pool ([QUIC I/O boundary](/quest/m2/quic-io-boundary.md)), and the
non-QUIC backends' move off `web_transport_trait`, which has landed.

Expand Down
2 changes: 1 addition & 1 deletion quest/m2/quic-realtime/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ Remaining work once the candidates finish (this README's own job):
- Delete the losing candidates' code.
- Decide who asks for receive timestamps. The spike added
`transport::Config::receive_timestamps`, off by default, and the maintainer
kept it on 2026-10-30. The winner decides whether its `ControllerFactory`
kept it on 2026-10-30. The winner decides whether its `Factory`
turns them on instead, so only `Realtime` sessions pay the ACK bytes.
- Wire the winner's moq-shaper run into the nightly so a regression in
queuing delay shows up.
Expand Down
2 changes: 1 addition & 1 deletion quest/m2/quic-realtime/gcc.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ fork.
Controller's per-packet send and receive instants; drop the parts that only
serve RTCP or probe clusters unless the comparison needs them.
- GCC outputs a target rate and pacing rate; map them to the Controller's
window and `ControllerMetrics::{pacing_rate, bandwidth_estimate}`, keeping
window and `Metrics::{pacing_rate, bandwidth_estimate}`, keeping
its congestion-window pushback as the inflight bound.
- Keep the BSD license and PATENTS file with the vendored code.
- Implement `Controller::probes` and report `probe_inflight` so moq-quic's
Expand Down
2 changes: 1 addition & 1 deletion rs/moq-congestion/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ repository = "https://github.com/moq-dev/moq"
license = "MIT OR Apache-2.0"

[features]
# Test-only `Bbr3Config::probe_rng_seed`, for moq-quic's deterministic transport tests.
# Test-only `bbr3::Config::probe_rng_seed`, for moq-quic's deterministic transport tests.
testing = []

[dependencies]
Expand Down
4 changes: 4 additions & 0 deletions rs/moq-congestion/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ BBR3, Cubic, and Unlimited congestion controllers, consumed by moq-quic and the

The controllers take explicit `kio::clock::Instant` values and never drive a runtime. The `Controller` trait names no transport types: `on_sent` returns an opaque per-packet state that the transport stores and hands back with each acknowledgement or loss, and the controller paces its own sends.

Construct controllers with `Factory::build` on an `Arc<bbr3::Config>`, `Arc<cubic::Config>`, or `Arc<Unlimited>`. `Bbr3`, `Cubic`, `Unlimited`, and `Metrics` live at the crate root.

For callers of the unpublished API, replace `Bbr3Config` with `bbr3::Config`, `CubicConfig` with `cubic::Config`, `ControllerFactory` with `Factory`, and `ControllerMetrics` with `Metrics`. Remove `Controller::into_any` from custom implementations; inspect the controller's behavior or metrics instead of downcasting. `clone_box` still copies controller state for path migration. The test-only `Bbr3::probing_rtt` and `min_rtt` accessors are removed; model internals are tested in this crate.

The code was extracted from [moq-quic](../moq-quic), under the same MIT or Apache-2.0 license. Cubic originated in quinn; BBR3 was ported from moq-dev/noq and carries the fixes listed in [moq-quic's fork history](../moq-quic/README.md).

Controller tests run with `just rs test -p moq-congestion`. The per-packet benchmark runs nightly, or locally with:
Expand Down
2 changes: 1 addition & 1 deletion rs/moq-congestion/src/bbr3/bench.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const PACKET: u16 = 1200;
fn measure(flight: usize, batch: usize, steady: bool) -> (Duration, usize) {
let base = Instant::now();
let region = Region::new(ALLOCATOR);
let config = Bbr3Config {
let config = Config {
probe_rng_seed: Some([7; 16]),
..Default::default()
};
Expand Down
Loading