Repository navigation
quest: plan follow-ups from the 2026-10-29 /quest-complete merges #7274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # [S] Backport the SETUP-path and iroh-key fixes to release | ||
|
|
||
| ## Goal | ||
|
|
||
| `release` refuses a moq-transport SETUP Path on WebTransport and WebSocket | ||
| bindings, as [moq-dev/moq#7206](https://github.com/moq-dev/moq/pull/7206) | ||
| fixed on main, and writes persisted iroh endpoint keys with private file | ||
| permissions, as [moq-dev/moq#7213](https://github.com/moq-dev/moq/pull/7213) | ||
| did. Both ship in one patch release with the published API unchanged. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-30 (maintainer, `/quest-plan`): one quest and one PR against | ||
| `release` for both. They are small security fixes that ship in the same patch | ||
| release, so pairing them is simpler than the usual one PR per backport. | ||
|
|
||
| - SETUP path: `release`'s handshake also accepts a SETUP Path that names a | ||
| different path or query than the request URI, so Tokio could authorize the | ||
| wrong path. Port #7206's refusal onto `release`'s handshake, with its test. | ||
| - iroh key: port #7213's private permissions for the persisted key file, with | ||
| its test. | ||
| - Version bumps are hand-picked, per `CONTRIBUTING.md`. | ||
|
|
||
| Public API: none. Wire: a conflicting SETUP Path is refused, as on main. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Describe the complete SETUP Path contract. The upstream fix rejects any SETUP Path on URI bindings, including empty and request-URI-matching values. This line says only “a conflicting SETUP Path is refused”. That wording can produce an incomplete backport that still accepts the empty or matching cases. State that every present
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # [S] moq-uring's tests build on macOS and Windows | ||
|
|
||
| ## Goal | ||
|
|
||
| Nightly's `platform / macOS` and `platform / Windows` jobs compile again: the | ||
| 23 `error[E0433]: cannot find module or crate kio` errors are gone. | ||
|
|
||
| ## Plan | ||
|
|
||
| Seen in Nightly run 40885347517 (2026-10-29). moq-uring's integration tests | ||
| include `rs/moq-uring/src/transport/adapter.rs` by path | ||
| (`tests/integration/../../src/transport/adapter.rs`), and that file names | ||
| `kio`, which is not in scope for the test crate on those platforms. moq-uring | ||
| is Linux-only, so make its integration tests build to nothing off Linux, or | ||
| give the test crate what the included file needs. Prefer the first, so a | ||
| non-Linux build never compiles io_uring code. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # [XS] moq-tokio's isolated feature builds pass | ||
|
|
||
| ## Goal | ||
|
|
||
| Nightly's `rs features` job gets past `just rs tokio-features --all`, so | ||
| every later step in it runs again, including the rustdoc check. | ||
|
|
||
| ## Plan | ||
|
|
||
| `moq_tokio`'s `Incoming::refuse` is called only from tests, so one isolated | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P2] Remove the already-completed Incoming::refuse fix #7120 (f5f1cb1) already added (Written by OpenAI) |
||
| feature build fails on `dead_code` and stops the job. Either a non-test caller | ||
| should use it, or it should be compiled only where it is used. Pick whichever | ||
| keeps the API honest: drop it from the public surface if nothing outside tests | ||
| needs it. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # [S] moq-rtc's session-end test survives load | ||
|
|
||
| ## Goal | ||
|
|
||
| `a_session_ending_without_a_delete_ends_its_tracks` in moq-rtc stops failing | ||
| with a DTLS handshake timeout when the host is busy, fixed at its cause. | ||
|
Comment on lines
+5
to
+6
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| ## Plan | ||
|
|
||
| Seen during [moq-dev/moq#6987](https://github.com/moq-dev/moq/pull/6987)'s | ||
| local `just check`: it failed once under load, then passed alone and on the | ||
| full rerun. Find what bounds the handshake by wall clock (a real timer in the | ||
| test or in the DTLS path) and drive it on the simulated clock, or measure it | ||
| from progress rather than elapsed time. | ||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # [S] Every moq-c consumer cancels while its subscription is pending | ||
|
|
||
| ## Goal | ||
|
|
||
| Cancelling a hand-written moq-c catalog, raw track, datagram, or media | ||
| consumer ends it with a clean final callback even while it waits for its | ||
| subscription to be accepted, as the JSON consumers do since | ||
| [moq-dev/moq#7082](https://github.com/moq-dev/moq/pull/7082). | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-30 (maintainer, `/quest-plan`): the hand-written crate ships | ||
| at the cut and the [generated C line](/quest/m2/c/README.md) follows it, so | ||
| fix this bug for the release, but skip converting the consumer loops to kio | ||
| polling and changing the producers: the generated binding replaces both. | ||
|
|
||
| Reuse #7082's `Consume::json_subscribe` pattern for the other consumers, with | ||
| a test per consumer that cancels an unanswered subscription. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # [S] Stream-accept loops yield on a per-poll budget | ||
|
|
||
| ## Goal | ||
|
|
||
| A peer that opens many streams at once cannot keep a session's driver busy: | ||
| every peer-driven stream-accept loop in moq-net yields after a fixed budget per | ||
| poll, as the receive loops do since | ||
| [moq-dev/moq#7034](https://github.com/moq-dev/moq/pull/7034). | ||
|
|
||
| ## Plan | ||
|
|
||
| Today accept loops are bounded only by MAX_STREAMS credit, so one poll can | ||
| accept up to the 10,000-stream default. Charge the same `kio::coop::Budget` | ||
| per accepted stream, in lite and moq-transport, Rust and JS. Add a flood test | ||
|
Comment on lines
+13
to
+14
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Separate the Rust and JavaScript budget contracts.
|
||
| like #7034's that shows a sibling still makes progress. | ||
|
Comment on lines
+12
to
+15
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # [XS] A resumed untimed copy keeps DYNAMIC_GROUPS | ||
|
|
||
| ## Goal | ||
|
|
||
| On moq-transport draft 22, a resumed copy of an untimed track that opts out of | ||
| Track Properties still knows the track's DYNAMIC_GROUPS, as its first | ||
| subscription did. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found in [moq-dev/moq#7085](https://github.com/moq-dev/moq/pull/7085): opting | ||
| out of properties on resume drops DYNAMIC_GROUPS along with TIMESCALE. Carry | ||
| it from the first subscription, or keep asking for it when the track has it. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| Add a resume test on draft 22. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # [S] Rust cancels an unclaimed fill head when a subscription ends | ||
|
|
||
| ## Goal | ||
|
|
||
| When SUBSCRIPTION_ENDED arrives while a fill head is still unclaimed, Rust's | ||
| moq-transport subscriber cancels that fill instead of finishing it, as the JS | ||
| subscriber does since [moq-dev/moq#7089](https://github.com/moq-dev/moq/pull/7089), | ||
| so a reader never sees a clean end for a group it was never sent. | ||
|
|
||
| ## Plan | ||
|
|
||
| Planned 2026-10-30 (maintainer, `/quest-plan`). The finish is `Fill::end` in | ||
| `rs/moq-net/src/ietf/subscriber.rs`. Add a test that ends a subscription with | ||
| an unclaimed fill head and expects the cancel, in both languages' terms. | ||
|
|
||
| [IETF fill refill](/quest/m2/ietf-fill-refill.md) would later remove this | ||
| fill handoff entirely; this fix is for the release cut, not a reason to wait. | ||
|
|
||
| ## Related | ||
|
|
||
| - [IETF fill refill](/quest/m2/ietf-fill-refill.md) - replaces the fill claim and handoff this touches |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # [S] Decoding from a track's first packet keeps its start | ||
|
|
||
| ## Goal | ||
|
|
||
| moq-audio decoding an Opus track from its first packet outputs everything but | ||
| the codec's pre-skip, so recordings keep their first 80 ms and a track shorter | ||
| than that decodes to something, in every binding. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-30 (maintainer, `/quest-plan`): from the track's first packet, | ||
| drop only the OpusHead pre-skip, as the codec defines. A decoder that joins | ||
| mid-stream keeps today's 80 ms warmup, since it has no history to warm up | ||
| from. Found in [moq-dev/moq#7033](https://github.com/moq-dev/moq/pull/7033). | ||
|
|
||
| Test both cases: a short finished track decodes to its length minus | ||
| pre-skip, and a mid-stream join still drops its warmup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport the full persisted-key hardening.
The referenced
#7213fix does more than set private permissions. It creates new files exclusively, rejects symlinks and non-regular files, and refuses existing files readable by group or others. A plan that only ports “private permissions” can leave the dangling-symlink and unsafe-existing-file cases open. Expand this bullet and its test scope to cover all of those cases. (github.com)