Repository navigation
fix(net): abort an ended lite track whose tail never settled #7295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2e4217d
chore(quest): claim quest/m1/lite-track-end.md
kixelated ffc21b4
fix(net): abort an ended lite track whose tail never settled
kixelated 0fa75c7
Merge origin/main
kixelated 7f56375
Merge origin/main
kixelated dcb9ace
Merge branch 'base' into pr-7295
0e68d65
test(net): adapt clean-end fixtures to base error API
e871178
Merge base and follow kio test attribute rename
7667644
quest land: merge tested base
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 15212
Script executed:
Repository: moq-dev/moq
Length of output: 42051
Script executed:
Repository: moq-dev/moq
Length of output: 42740
Script executed:
Repository: moq-dev/moq
Length of output: 42240
Script executed:
Repository: moq-dev/moq
Length of output: 34092
Script executed:
Repository: moq-dev/moq
Length of output: 12892
Script executed:
Repository: moq-dev/moq
Length of output: 19716
Script executed:
Repository: moq-dev/moq
Length of output: 15160
Script executed:
Repository: moq-dev/moq
Length of output: 21747
Do not finish a legacy track before its tail settles.
For Lite01–Lite04, FIN declares the track end while a GROUP stream can still be in flight. If the session closes before that stream’s header arrives, this call finishes an empty local producer at group 0.
TrackServeRunthen aborts with the session error, but the track model sees the empty boundary as settled and readers receive clean EOF.SubscriptionCleanup::abortcan do the same becauseTail::is_ended()means FIN was declared, not that the tail settled. Distinguish declaration from settlement; finish only after settlement and otherwise preserve the session error.