Repository navigation
A quick finish keeps its pre-draft-22 join - #7306
Conversation
Quest-Claim: cc38b3a19ea65f83
A subscription whose track ended cleanly keeps its joining-FETCH entry past PUBLISH_DONE, so a joining FETCH sent on SUBSCRIBE_OK that arrives after the finish is answered with the Largest group's head instead of refused. The entry lasts until the subscriber closes the request, the session closes, or the request token's grant or the session grant stops covering the track. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… drains cooperatively Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 1ea2c29.
No actionable bugs found. Request-scoped retention is a better fit than a new timeout: only answerable, cleanly finished joins survive, while the original subscription slot and authority remain held. Both the blocked PUBLISH_DONE flush and subsequent wait watch cancellation and authorization loss; removing the join also terminates an in-flight joining FETCH. The bounded discard handles crossing updates without monopolizing polling.
The reported local authorization-flush and unbounded-drain findings appear addressed in the current source. The documented cache-eviction refusal remains an explicit limitation, not a guaranteed pinned head.
Verification limits: static review of the changed code, surrounding subscription/FETCH lifecycle and regression tests, with an independent source check. No tests or interop runs executed; author-reported checks were not independently verified. Draft-18 tail/finish interoperability still needs the planned reruns.
(Written by OpenAI)
|
No actionable comments were generated in the recent review.
|
|
Merging. I merged main into this branch (no rebase). The hand-resolved conflict with moq-dev/moq#6999 keeps this PR's (Written by Claude Opus 5.5) |
|
quest land removed this pull request from the queue: the batch check failed (exit 1). js: selecting docs
..js: selecting reader
...
----------------------------------------------------------------------
Ran 24 tests in 0.332s
OK
python3 sh/js/audit.test.py
..
----------------------------------------------------------------------
Ran 2 tests in 0.064s
OK
python3 sh/rs/test-lints.test.py
.
----------------------------------------------------------------------
Ran 1 test in 2.344s
OK
python3 sh/gh/nightly.test.py
..............
----------------------------------------------------------------------
Ran 14 tests in 1.112s
OK
python3 sh/gh/pages-clean.test.py
....
----------------------------------------------------------------------
Ran 4 tests in 0.048s
OK
python3 sh/gh/bench-report.test.py
............
----------------------------------------------------------------------
Ran 12 tests in 0.407s
OK
bench-ffi: 2 measured entries
bench-rust: failure; no history point
bench-ffi: failure; no history point
bench-rust: failure; no history point
no completed benchmark reports; no history point
bench-rust: 1 measured entries
bench-rust: failure; no history point
no completed benchmark reports; no history point
Paired comparison of c2 against c1: 1 confirmed regressions, 1 targets not compared
- `rust/kio/lock/4`: +40.0% (rounds +30.0%, +40.0%, +50.0%)
- `rust/gst/moq-gst/catalog` not compared: base build failed
Paired comparison of c2 against c1: 0 confirmed regressions, 0 targets not compared
python3 sh/gh/ts-paths.test.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.000s
OK
sh/go/publish-wrapper.test.sh
publish-wrapper test: no rsync on PATH, skipping
bash .claude/hooks/direnv.test.sh
direnv hook: could not load the dev shell, see the direnv output above.
direnv hook: regression tests passed
python3 sh/rs/uring.test.py
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting moq-relay moq-uring
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting moq-relay
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting kio moq-relay moq-uring
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting moq-unrelated
rs: selecting the workspace
rs: selecting the workspace
rs: selecting the workspace
.
----------------------------------------------------------------------
Ran 1 test in 0.270s
OK
ci: check quest failed
ci: check rs failed
ci: check rs_shapes failed
ci: check js failed
ci: seconds per module
24 check rs (failed)
9 check rs_shapes (failed)
14 check js (failed)
19 check drafts
11 check markdown
6 check gh
36 test gh
0 check drill
2 check quest (failed)
13 check shell
0 check large_files
0 check toml
0 check nix
0 check justfile
87 wall time
error: recipe `ci` failed on line 104 with exit code 1
. |
|
codex / Codex land fixer: (written by codex / Codex) |
|
quest land removed this pull request from the queue: the batch check failed (exit 101). ...js: selecting docs
js: selecting docs
..js: selecting reader
...
----------------------------------------------------------------------
Ran 24 tests in 1.786s
OK
python3 sh/js/audit.test.py
..
----------------------------------------------------------------------
Ran 2 tests in 0.103s
OK
python3 sh/rs/test-lints.test.py
.
----------------------------------------------------------------------
Ran 1 test in 3.877s
OK
python3 sh/gh/nightly.test.py
..............
----------------------------------------------------------------------
Ran 14 tests in 2.476s
OK
python3 sh/gh/pages-clean.test.py
....
----------------------------------------------------------------------
Ran 4 tests in 0.077s
OK
python3 sh/gh/bench-report.test.py
............
----------------------------------------------------------------------
Ran 12 tests in 0.993s
OK
bench-ffi: 2 measured entries
bench-rust: failure; no history point
bench-ffi: failure; no history point
bench-rust: failure; no history point
no completed benchmark reports; no history point
bench-rust: 1 measured entries
bench-rust: failure; no history point
no completed benchmark reports; no history point
Paired comparison of c2 against c1: 1 confirmed regressions, 1 targets not compared
- `rust/kio/lock/4`: +40.0% (rounds +30.0%, +40.0%, +50.0%)
- `rust/gst/moq-gst/catalog` not compared: base build failed
Paired comparison of c2 against c1: 0 confirmed regressions, 0 targets not compared
python3 sh/gh/ts-paths.test.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s
OK
sh/go/publish-wrapper.test.sh
publish-wrapper test: no rsync on PATH, skipping
bash .claude/hooks/direnv.test.sh
direnv hook: could not load the dev shell, see the direnv output above.
direnv hook: regression tests passed
python3 sh/rs/uring.test.py
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting moq-relay moq-uring
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting moq-relay
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting kio moq-relay moq-uring
jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a string
rs: selecting moq-unrelated
rs: selecting the workspace
rs: selecting the workspace
rs: selecting the workspace
.
----------------------------------------------------------------------
Ran 1 test in 0.469s
OK
ci: check rs failed
ci: check rs_shapes failed
ci: check js failed
ci: seconds per module
56 check rs (failed)
65 check rs_shapes (failed)
94 check js (failed)
33 check drafts
23 check markdown
3 check gh
77 test gh
0 check drill
5 check quest
38 check shell
1 check large_files
0 check toml
1 check nix
0 check justfile
231 wall time
error: recipe `ci` failed on line 106 with exit code 101
. |
|
codex / Codex land fixer: (written by codex / Codex) |
|
quest land removed this pull request from the queue: Conflicts with the base: quest/m2/audit-ci.md, quest/m2/ietf-fill-refill.md, quest/m2/ietf-js-joining-fetch.md, rs/moq-net/src/ietf/publisher.rs, rs/moq-net/src/ietf/publisher/tracks.rs |
|
quest land removed this pull request from the queue: the batch check failed (exit 101). Compiling tungstenite v0.30.0
Compiling moq-quic v0.1.0 (/work/rs/moq-quic)
Compiling rustls-platform-verifier v0.7.1
Compiling tokio-tungstenite v0.30.0
Compiling openh264 v0.9.9
Compiling qmux v0.7.0 (/work/rs/qmux)
Compiling moq-tokio v0.19.23 (/work/rs/moq-tokio)
Compiling moq-audio v0.1.10 (/work/rs/moq-audio)
Compiling moq-ffi v0.4.12 (/work/rs/moq-ffi)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 19s
mbx[cache]: object cache: 428 hits, 18 misses; 0 B downloaded, 0 B uploaded, 532.9 MiB stored locally
mbx[cache]: 1m 20s session; 6m 36s estimated compiler time avoided (summed across compilations)
mbx[cache]: Cargo artifact reuse and CI cache archive transfers are not included above
mbx[savings]: 2.6 TiB of outputs, one copy, several very confident checkouts.
�[2m2026-11-01T06:34:50.871778Z�[0m �[32m INFO�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mbuild_uniffi_wheel�[0m:�[1mcompile_cdylib�[0m: �[2mmaturin::build_orchestrator�[0m�[2m:�[0m close �[3mtime.busy�[0m�[2m=�[0m80.3s �[3mtime.idle�[0m�[2m=�[0m4.13µs
🚉 Overriding platform tag from _PYTHON_HOST_PLATFORM environment variable as linux_x86_64.
�[2m2026-11-01T06:34:50.874766Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mbuild_uniffi_wheel�[0m: �[2mglobset�[0m�[2m:�[0m glob `Glob("**/moq_ffi/_uniffi/**/*")` converted to regex: `"(?-u)^(?:/?|.*/)moq_ffi/_uniffi(?:/|/.*/)[^/]*$"`
�[2m2026-11-01T06:34:50.874778Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mbuild_uniffi_wheel�[0m: �[2mglobset�[0m�[2m:�[0m glob `Glob("**/__pycache__/**/*")` converted to regex: `"(?-u)^(?:/?|.*/)__pycache__(?:/|/.*/)[^/]*$"`
�[2m2026-11-01T06:34:50.874782Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mbuild_uniffi_wheel�[0m: �[2mglobset�[0m�[2m:�[0m built glob set; 0 literals, 0 basenames, 0 extensions, 0 prefixes, 0 suffixes, 0 required extensions, 2 regexes
�[2m2026-11-01T06:34:50.875965Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mbuild_uniffi_wheel�[0m: �[2mmaturin::build_context::repair�[0m�[2m:�[0m copy_back_cargo_outputs: copied unpatched /home/check/mbx-targets/check/v1/7a4aae51b2e53b173e0e88b328d8b5d16a3ff418f0f523578c8ab24ae8dfd401/py/maturin/libmoq_ffi.so -> /work/target/py/debug/libmoq_ffi.so
�[2m2026-11-01T06:34:52.955477Z�[0m �[34mDEBUG�[0m �[1mdevelop_cmd�[0m:�[1mbuild_wheels�[0m:�[1mbuild_wheels_inner�[0m:�[1mbuild_uniffi_wheel�[0m: �[2mmaturin::binding_generator::uniffi_binding�[0m�[2m:�[0m Running cd "/work" && env -u CARGO_BUILD_TARGET "cargo" "run" "--bin" "uniffi-bindgen" "--features" "cli" "generate" "--no-format" "--language" "python" "--out-dir" "/home/check/mbx-targets/check/v1/7a4aae51b2e53b173e0e88b328d8b5d16a3ff418f0f523578c8ab24ae8dfd401/py/maturin/uniffi/moq_ffi._uniffi" "--config" "/work/rs/moq-ffi/uniffi.toml" "--library" "/home/check/mbx-targets/check/v1/7a4aae51b2e53b173e0e88b328d8b5d16a3ff418f0f523578c8ab24ae8dfd401/py/maturin/libmoq_ffi.so"
Compiling libc v0.2.191
Compiling anyhow v1.0.104
Compiling syn v3.0.6
Compiling winnow v1.0.4
Compiling indexmap v2.14.2
Compiling rustix v1.1.5
Compiling linux-raw-sys v0.12.1
Compiling foldhash v0.2.0
Compiling hashbrown v0.17.1
Compiling uniffi_internal_macros v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling rustc-hash v2.1.3
Compiling siphasher v1.0.4
Compiling utf8parse v0.2.2
Compiling serde_json v1.0.154
Compiling getrandom v0.4.3
Compiling glob v0.3.4
Compiling anstyle-parse v1.0.0
Compiling fs-err v3.3.1
Compiling scroll_derive v0.12.1
Compiling tempfile v3.27.0
Compiling is_terminal_polyfill v1.70.2
Compiling anstyle-query v1.1.5
Compiling smawk v0.3.3
Compiling anstyle v1.0.14
Compiling colorchoice v1.0.5
Compiling parking_lot_core v0.9.12
Compiling errno v0.3.14
Compiling socket2 v0.6.5
Compiling signal-hook-registry v1.4.8
Compiling parking_lot v0.12.5
Compiling mio v1.2.3
Compiling anstream v1.0.0
Compiling textwrap v0.16.4
Compiling uniffi_pipeline v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling weedle2 v5.0.0 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling toml_parser v1.1.3+spec-1.1.0
Compiling plain v0.2.3
Compiling strsim v0.11.1
Compiling clap_lex v1.1.1
Compiling scroll v0.12.0
Compiling clap_builder v4.6.7
Compiling uniffi_meta v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling goblin v0.8.2
Compiling serde_derive v1.0.229
Compiling tokio-macros v2.7.2
Compiling thiserror-impl v2.0.21
Compiling clap_derive v4.6.7
Compiling toml v1.1.6+spec-1.1.0
Compiling thiserror v2.0.21
Compiling uniffi_udl v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling clap v4.6.7
Compiling serde v1.0.229
Compiling bytes v1.12.1
Compiling cargo_metadata v0.23.1
Compiling basic-toml v0.1.10
Compiling askama_parser v0.16.1
Compiling uniffi_macros v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling tokio v1.54.1
Compiling uniffi_core v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling askama_derive v0.16.1
Compiling askama_macros v0.16.1
Compiling askama v0.16.1
Compiling uniffi_bindgen v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling uniffi v0.32.2 (https://github.com/kixelated/uniffi-rs?rev=88d835d#88d835d6)
Compiling uniffi-bindgen v0.1.0 (/work/rs/uniffi-bindgen)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 32s
Running `target/py/debug/uniffi-bindgen generate --no-format --language python --out-dir /home/check/mbx-targets/check/v1/7a4aae51b2e53b173e0e88b328d8b5d16a3ff418f0f523578c8ab24ae8dfd401/py/maturin/uniffi/moq_ffi._uniffi --config /work/rs/moq-ffi/uniffi.toml --library /home/check/mbx-targets/check/v1/7a4aae51b2e53b173e0e88b328d8b5d16a3ff418f0f523578c8ab24ae8dfd401/py/maturin/libmoq_ffi.so`
warning: /work/rs/moq-ffi/uniffi.toml looks like an old-style --config override file. The --config flag now expects a global config file with [defaults], [crates.<name>], and/or [crate-roots] sections. Old-style flat config files are no longer supported.
DEBUG Received SIGTERM, forwarding to child at 684
error: recipe `_develop` failed on line 27 with exit code 143
error: recipe `check` failed on line 46 with exit code 143
ci: test rs failed
ci: seconds per module
310 check py (cancelled)
81 check rs
229 test rs (failed)
310 check c (cancelled)
310 wall time
error: recipe `ci` failed on line 107 with exit code 101
. |
|
codex / Codex land fixer: (written by codex / Codex) |
|
quest land removed this pull request from the queue: Conflicts with the base: rs/moq-net/src/ietf/publisher.rs |
|
quest land removed this pull request from the queue: the batch check failed (exit 100). PASS [ 0.471s] (9287/9337) moq-video frame::cuda::tests::auto_external_captures_are_distinguishable
PASS [ 0.095s] (9288/9337) moq-uring::integration endpoint::dropping_the_last_connection_handle_closes_it
PASS [ 0.103s] (9289/9337) moq-uring::integration endpoint::dropping_the_last_raw_session_closes_the_connection
PASS [ 21.600s] (9290/9337) moq-net model::group::test::a_long_compressed_group_sheds_its_front
PASS [ 3.139s] (9291/9337) moq-tokio::integration reconnect::two_peers_redirecting_to_each_other_escalate_the_backoff
PASS [ 2.158s] (9292/9337) moq-video encode::encoder::tests::transcode_keeps_the_space_the_source_signalled
PASS [ 3.065s] (9293/9337) qmux session::tests::websocket_keep_alive_runs_during_continuous_output
PASS [ 3.101s] (9294/9337) moq-uring::integration endpoint::cancelling_a_dial_releases_its_connection
PASS [ 0.291s] (9295/9337) moq-uring::integration endpoint::unsupported_version_is_negotiated_only_by_servers
PASS [ 0.088s] (9296/9337) moq-uring::integration identity::a_stopped_worker_fails_dials_and_accepts
PASS [ 0.057s] (9297/9337) moq-uring::integration identity::an_endpoint_refuses_a_stopped_worker
PASS [ 0.693s] (9298/9337) moq-uring::integration identity::an_endpoint_runs_on_the_worker_that_adopted_its_socket
PASS [ 0.109s] (9299/9337) moq-uring::integration local_addr::a_dual_stack_wildcard_answers_a_v4_peer_from_the_address_reached
PASS [ 0.109s] (9300/9337) moq-uring::integration local_addr::a_v4_wildcard_answers_from_the_address_reached
PASS [ 0.094s] (9301/9337) moq-uring::integration local_addr::a_wildcard_endpoint_handshakes_on_a_secondary_address
PASS [ 0.153s] (9302/9337) moq-uring::integration mtu::a_path_at_the_ipv6_minimum_connects
PASS [ 0.359s] (9303/9337) moq-uring::integration mtu::a_shrinking_path_falls_back_to_the_floor
PASS [ 0.125s] (9304/9337) moq-uring::integration mtu::discovery_finds_a_larger_mtu
PASS [ 0.151s] (9305/9337) moq-uring::integration mtu::discovery_stays_off_by_default
PASS [ 0.116s] (9306/9337) moq-uring::integration receive_credit::partial_frame_gives_way
PASS [ 0.091s] (9307/9337) moq-uring::integration session::a_root_bundle_is_loaded_whole
PASS [ 0.091s] (9308/9337) moq-uring::integration session::configured_roots_verify_the_server
PASS [ 0.101s] (9309/9337) moq-uring::integration session::lite_session_over_the_worker
PASS [ 0.092s] (9310/9337) moq-uring::integration session::required_client_auth_refuses_an_anonymous_client
PASS [ 0.110s] (9311/9337) moq-uring::integration session::two_lite_sessions_share_the_server_socket
PASS [ 0.092s] (9312/9337) moq-uring::integration teardown::a_published_close_has_already_left_the_client
PASS [ 0.058s] (9313/9337) moq-uring::integration teardown::a_send_staged_on_the_way_out_still_goes
PASS [ 0.093s] (9314/9337) moq-uring::integration teardown::handles_outliving_the_worker_fail
PASS [ 0.007s] (9315/9337) moq-uring::integration transport::adapter::outcome_tests::typed_ring_close_kinds_survive_the_adapter
PASS [ 0.006s] (9316/9337) moq-uring::integration transport::adapter::tests::forwards_thread_local_streams_and_keeps_error_codes
PASS [ 0.006s] (9317/9337) moq-uring::integration transport::adapter::tests::preserves_session_close_codes
PASS [ 0.094s] (9318/9337) moq-uring::integration web::a_clean_finish_closes_a_stream
PASS [ 0.093s] (9319/9337) moq-uring::integration web::a_dropped_session_delivers_its_close
PASS [ 0.094s] (9320/9337) moq-uring::integration web::a_dropped_stream_carries_a_webtransport_code
PASS [ 1.092s] (9321/9337) moq-uring::integration web::a_rejection_reaches_the_peer
PASS [ 0.094s] (9322/9337) moq-uring::integration web::a_reset_stream_keeps_its_header
PASS [ 0.093s] (9323/9337) moq-uring::integration web::a_reset_stream_keeps_its_header_without_credit
PASS [ 8.283s] (9324/9337) moq-video encode::producer::tests::clock::hls_records_keep_the_live_timestamps
PASS [ 0.092s] (9325/9337) moq-uring::integration web::an_abandoned_handshake_closes_the_connection
PASS [ 0.093s] (9326/9337) moq-uring::integration web::an_unpolled_handshake_closes_the_connection
PASS [ 0.094s] (9327/9337) moq-uring::integration web::cancelling_before_peer_settings_closes_the_connection
PASS [ 0.105s] (9328/9337) moq-uring::integration web::cancelling_while_awaiting_connect_closes_the_connection
PASS [ 0.103s] (9329/9337) moq-uring::integration web::lite_session_over_webtransport
PASS [ 0.096s] (9330/9337) moq-uring::integration web::the_last_web_session_drop_delivers_a_close_capsule
PASS [ 0.119s] (9331/9337) moq-uring::integration web::webtransport_accepts_a_buffered_uni_after_the_peer_close
PASS [ 0.098s] (9332/9337) moq-uring::integration web::webtransport_echo_end_to_end
PASS [ 0.263s] (9333/9337) moq-uring::integration workers::a_steered_group_serves_a_shared_port
PASS [ 10.100s] (9334/9337) moq-uring::integration endpoint::an_unanswered_dial_times_out
PASS [ 10.091s] (9335/9337) moq-uring::integration endpoint::the_backlog_bounds_pending_handshakes
PASS [ 10.099s] (9336/9337) moq-uring::integration endpoint::the_backlog_bounds_queued_connections
SLOW [> 60.000s] (─────────) moq-net ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object
TERMINATING [>120.000s] (─────────) moq-net ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object
TIMEOUT [ 120.005s] (9337/9337) moq-net ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object
stdout ───
running 1 test
test ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object has been running for over 60 seconds
(test timed out)
Cancelling due to test failure:
────────────
Summary [ 137.019s] 9337 tests run: 9336 passed, 1 timed out, 108 skipped
TIMEOUT [ 120.005s] (9337/9337) moq-net ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object
stdout ───
running 1 test
test ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object has been running for over 60 seconds
(test timed out)
error: test run failed
mbx[cache]: object cache: 24 hits, 76 misses, 2 bypassed; 0 B downloaded, 0 B uploaded, 7.4 GiB stored locally
mbx[cache]: 7m 45s session; 38.24s estimated compiler time avoided (summed across compilations)
mbx[cache]: bypass reasons: 2 unsupported-crate-type
mbx[cache]: Cargo artifact reuse and CI cache archive transfers are not included above
mbx[savings]: 4.5 TiB logical of target/ was waiting for checkouts that are never coming back. it has stopped waiting.
error: recipe `test` failed on line 274 with exit code 100
error: recipe `test-changed` failed on line 82 with exit code 100
ci: test rs failed
ci: seconds per module
79 check rs
466 test rs (failed)
215 check obs_compile
364 check js
85 test js
12 check markdown
7 check gh
44 test gh
121 check flake
2 check drill
3 check quest
20 check obs
16 check shell
0 check large_files
1 check toml
1 check nix
0 check justfile
546 wall time
error: recipe `ci` failed on line 107 with exit code 100
. |
|
codex / Codex land fixer: (written by codex / Codex) |
…DONE is out main's a_cold_reported_copy_serves_its_first_wire_object awaited a finished draft-18 subscription, which now keeps its join until the subscriber closes the request. Share run_live's drive-and-close loop as served(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 8c1fd92.
No actionable bugs found in this update. The shared served helper correctly closes the mock request only after PUBLISH_DONE, allowing a_cold_reported_copy_serves_its_first_wire_object to finish under draft-18 join retention while preserving its payload, reset, and wire Object ID assertions. Reusing the existing drive-and-close loop is simpler than adding a timeout or weakening the test.
After accounting for base changes, the production retention logic is unchanged from the earlier review; its authorization-flush and bounded-drain fixes remain intact. No additional API or wire change.
Verification limits: static comparison and inspection of the helper, both callers, and surrounding lifecycle only. No tests or interoperability runs executed; the reported 9,337-test pass was not independently verified.
(Written by OpenAI)
Main's #7306 keeps a cleanly finished subscription's join in `Retain`, bounded by its request grant and gate. It now holds the request's `RequestBinding` and the gate the subscription was held to (the named one once it named a token), so a token named by an update still bounds the retained join. Main's #7439/#7296 made `poll_withdrawn` and `until_withdrawn` take `fin_cancels`; `admit_request` takes it too, `false` for TRACK_STATUS as main's TRACK_STATUS path does, `fin_cancels(version)` elsewhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes the quest/m2/ietf-join-after-finish.md quest.
Summary
On draft 18, a joining FETCH that reaches our publisher after its subscription has finished cleanly is now answered from the subscription's saved Largest group. Before, it was refused. A track that ends within about an RTT of SUBSCRIBE_OK now finishes cleanly at the subscriber, head included. This fixes the draft-18
tailinterop flake with a Rust publisher: PUBLISH_DONE went out, the FETCH arrived afterward and found no entry, and the subscriber's settle grace ran out before the 10 s registration wait refused it.Following the Plan's recommendation, the retention is bounded by the request:
Joined::Group), keeps itsJoinpast PUBLISH_DONE (Retaininrs/moq-net/src/ietf/publisher.rs). An unsubscribed, refused, or failed subscription still drops its entry at once.joined()is unchanged.Our subscriber needed no change. It already holds the SUBSCRIBE request open through its settle, and the settle waits for the joining FETCH's head (
poll_settledrequires the fill to resolve) up to its grace.Public API: none. Wire: none; a late joining FETCH is answered where it was refused.
Tests
On mocked time with no sleeps:
track_tail::draft18_a_join_reaching_a_finished_track_keeps_its_head(integration): a publisher and subscriber over the mock with 50 ms one-way latency. The track ends as the subscription starts, so the FETCH lands an RTT after PUBLISH_DONE, and the subscriber ends cleanly with the head. Without the fix it fails: the grace expires at 1.1 s and the head is lost.a_joining_fetch_after_the_track_ends_is_answered: FETCH_OK with the Largest group's head after PUBLISH_DONE. Closing the request then drops the entry, and a FETCH after that is refused.a_kept_join_ends_with_its_request_token: a request token that expires (mocked time) or is revoked after the finish drops the entry, and the late FETCH is refused.an_unsubscribed_join_is_not_keptanda_session_close_frees_every_kept_join.a_kept_join_ends_with_its_token_while_publish_done_waits: a revoked token drops the entry even while PUBLISH_DONE waits on flow control.an_update_after_publish_done_keeps_the_join: a REQUEST_UPDATE crossing PUBLISH_DONE neither closes the session nor drops the entry. The first fulljust checkcaught this regression:subscribe_ranges::initial_mixed_ranges_keep_the_absolute_historyfailed when the relay's crossing update closed the session.servedtest helper (shared byrun_liveand main'sa_cold_reported_copy_serves_its_first_wire_objectfrom moq-dev/moq#6982) closes the request after PUBLISH_DONE, since a finished draft-18 subscription now waits for that. Without it, that test hung on draft 18 and timed out the 16:30Z land batch.Checks:
just check origin/mainpasses on8c1fd92f9a(9337 tests).Choices made without asking
tracks::Subscribedguard is now held until the request closes rather than only until PUBLISH_DONE is acknowledged. It only affects whether the same track can be PUBLISHed to this session in the meantime.Follow-ups
track::Producerright afterfinish(), the cache demotes the latest group and the late FETCH is refused as not found. The Plan accepts this ("a head evicted from the cache meanwhile stays a loud refusal"), and the interoptailpublisher keeps its track alive. Whether a kept join should pin the head is a cache-policy question for/quest-plan.tailandfinishcells on draft 18 with a Rust publisher, per IETF finish.Review
quest reviewwith Codexgpt-6.1-sol, medium effort, in a new session. Round 1 on head8c1fd92f9af58b6b29b9c51c9293d197624c808breported no findings.That head merges main at
4b8e37bd44(conflict-free) and fixes the land failure: main's newserve_tests::a_cold_reported_copy_serves_its_first_wire_objectawaited a finished draft-18 subscription, which this PR now keeps open until the subscriber closes the request, so it hung until nextest's 120 s timeout. The test now drives the subscription withserved, the drive-and-close loop extracted fromrun_live.Earlier: land fixer merges at
1ef8161dcfanda434b5d4da(main'spublisher/tracks.rsdeletion and themoq_clocktokio::clockrename), and Codex rounds on728b51c8e6,1ea2c29b63(no findings) and4cdee3c700(2 findings, both fixed: the retained join watches its authorization while PUBLISH_DONE waits on flow control, and the drain loop yields viaReader::poll_discard).🤖 Generated with Claude Code
(Written by Claude Opus 5.5)