Repository navigation
quest: pin the restart a follower gets when the serving epochless route leaves #7370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kixelated
merged 8 commits into
moq-dev:main
from
Dryvnt:quest-plan/epochless-leave-restart
Nov 2, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0ef5cdf
quest: pin the restart a follower gets when the serving epochless rou…
5bf04f0
quest: observe the restart past a wire hop
ad7bf25
quest: require epochless lite-07 and moq-transport cases
e82cea5
Merge branch 'base' into pr-7370
92316e7
docs: follow completed epoch quest link on base
6e553b8
Merge remote-tracking branch 'origin/main' into epochless-merge
kixelated fa55cb8
Merge remote-tracking branch 'origin/main' into pr-7370
kixelated 7bd75d7
quest: align epochless-leave-restart with main's epochless coverage
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # [S] A follower is told when the serving epochless route leaves | ||
|
|
||
| ## Goal | ||
|
|
||
| When the route serving an epochless broadcast is withdrawn, or its session | ||
| dies, while another route for the path remains, a follower downstream of the | ||
| relay is announced the restart its version carries, such as an end then a | ||
| start on lite-06 and older and `ANNOUNCE_RESTART` on lite-07-wip. A re-request | ||
| then resumes on the survivor. Integration tests in the merge gate pin this | ||
| over the wire, with an epochless route, on lite-04 to 06, lite-07-wip, and | ||
| moq-transport 18 and 22. | ||
|
|
||
| ## Plan | ||
|
|
||
| [Identity and recovery](/doc/concept/identity.md) promises that without an | ||
| epoch, any other route winning the path is a restart, and players restart only | ||
| on the announcement, never on a request error. If a follower is not told, a | ||
| player's track subscriptions end while the path stays announced, and playback | ||
| freezes until something else changes the announcement. The release line | ||
| before [moq-dev/moq#5087](https://github.com/moq-dev/moq/pull/5087) behaves | ||
| this way: two epochless publishers on one path, and the serving one stops. | ||
| Main implements the restart in the origin's announce cursor (the "another | ||
| instance" case), but only | ||
| `an_equal_cost_peer_replacement_waits_for_the_old_route` asserts it, at the | ||
| model level with no hold and no wire. | ||
|
|
||
| Decided in quest-plan (2026-10-30): | ||
|
|
||
| - Regression coverage on main, not a fix or a release backport. Reading the code | ||
| shows main already behaves correctly. If a test shows otherwise, fix it in | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| this PR, at the relay's announcement, never by splicing the survivor into | ||
| the front or by having players retry on track errors. | ||
| - Rust assertion only. `route_dies_without_an_epoch` in | ||
| `rs/moq-net/tests/integration/route_change.rs` already covers the | ||
| `Disconnect` and `Unannounce` triggers over moq-transport 18 and 22 and | ||
| lite-04 to 06 under mock time (`pinned_tests!`). Its `Topology::new` mints | ||
| an epoch, which those versions drop (moq-transport since | ||
| [moq-dev/moq#7239](https://github.com/moq-dev/moq/pull/7239)), so it is | ||
| epochless there but not on lite-07-wip. It checks that the subscription | ||
| ends and a re-request reaches the survivor. | ||
| Extend it, or a sibling sharing its topology, so a follower one wire hop | ||
| past the relay observes the restart for both triggers. Watching | ||
| `announced()` on the relay's own origin only sees its local model event, | ||
| which `better_route_restarts` already covers; the follower must see what the | ||
| relay sends over the wire. | ||
| Moq-transport 18 and 22 get the follower assertion from the shared | ||
| topology. Lite-07-wip is required too, through a topology that announces | ||
| without an epoch, as `replacement.rs`'s `epochless_lite07` already does. | ||
| Player-level resume is already | ||
| covered on a graceful leave by `just test native-play` (lite-06 publishers) and | ||
| `just test media --media-cases replacement`. A crash differs only in when | ||
| the relay notices, which the `Disconnect` trigger already exercises, so no | ||
| new browser or native harness case. | ||
| - Assert the event kind the version can carry, not just "something arrived". | ||
| The `best_route_wins_and_fails_over` helper accepts Update or Start, which | ||
| would hide a regression to an in-place update. | ||
|
|
||
| Public API: none. Wire: none. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.