Repository navigation
feat(net): pace relay ingest by the group's fastest reader #7388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4d7bf1a
44a637e
05231f0
4305b8e
c8b1a5e
33f2f89
c2ae1ff
73a2984
2c96836
a051f54
13322e5
775219a
b0e7943
85beba9
3f5babd
27dfa25
a592278
eeaf610
f6b01d3
2ebe52d
cdf9346
646e6e1
bea3fab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -383,6 +383,18 @@ Put together, a conference might use: | |
| Under light congestion video drops the tail of a group; under heavy congestion | ||
| video stops and audio lags by at most 500 ms. No protocol change, just knobs. | ||
|
|
||
| A long group is paced by its fastest reader instead. Each hop receives at most | ||
| 16 MB of a group past its fastest reader, then stops reading the group's stream, | ||
| so stream flow control pushes back hop by hop to the publisher, and a reader | ||
| that keeps up loses nothing. A slower reader is never waited on: one that trails | ||
| the fastest by more than the group's 32 MB tail reaches a shed frame, and asks | ||
| for a new group on tracks that opt into [refresh](#refresh) or ends with | ||
| `Evicted`. A hop with no reader keeps receiving and shedding, so pacing never | ||
| stalls an unwatched track, and the publisher's own writes never wait unless it | ||
| asks to. A stopped stream keeps its receive credit, so a hop stops at most as | ||
| many streams per connection as fit in half its connection window, and the rest | ||
| keep receiving and shedding. | ||
|
Comment on lines
+386
to
+396
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. State the conditions of the pacing claim. This paragraph says "Each hop" stops reading at the 16 MB window. Per the quest, only moq-quic through moq-tokio and moq-uring, plus the memory transport, report a receive window. The following paths do not pause ingest yet:
The page does not say this, so it overstates what ships. State the covered implementations, or say that other hops receive and shed unpaced. Keep the edit inside this paragraph. As per coding guidelines (
|
||
|
|
||
| ### Refresh | ||
|
|
||
| A publisher can opt a track into refresh by setting its byte ratio. A new | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
State which transports the pacing covers.
The paragraph says the relay stops reading a stream once it is 16 MB past the fastest reader. It does not say this holds only for transports that report a receive window. The quest file lists quinn, iroh, qmux, browser WebTransport, and the FFI adapters as not reporting one. On those transports ingest never pauses. An operator reading this page cannot tell which connections get pacing.
Add one clause that names the covered transports, or states that others receive and shed unpaced.
As per coding guidelines (
doc/**): "State a claim's conditions with it: opt-in or experimental versions, and the paths it does not cover."Source: Coding guidelines