Repository navigation
quest: plan follow-ups from the 2026-10-30 /quest-complete merges #7405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
00f9c40
quest: plan follow-ups from the 2026-10-30 /quest-complete merges
kixelated 2027987
quest: keep the queue host quest free of private references
kixelated 5c458d9
Merge remote-tracking branch 'origin/main' into merge-7405
kixelated 3dda354
quest: drop the done padding quest, reconcile the follow-ups with main
kixelated dc451b2
Merge branch 'base' into pr-7405
386855c
docs(quest): reconcile completed pad-actor prerequisite with base
6208922
quest land: merge tested base
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # [M] The queue host keeps the queue's disk | ||
|
|
||
| ## Goal | ||
|
|
||
| Agent sessions sharing the self-hosted queue host can never fill its disk to | ||
| the point where the `moq-queue` runner fails a check, and a runner that does | ||
| crash comes back on its own. | ||
|
|
||
| ## Plan | ||
|
|
||
| On 2026-10-30 the host filled twice (about 03:00 and 07:30 PDT). Each time | ||
| non-CI usage grew by roughly 480 GB and was later freed. CI's XFS quota is | ||
| whatever the host leaves free past a 32 GiB reserve, so the runner hit ENOSPC | ||
| mid-check: quest land ejected moq-dev/moq#6985 and moq-dev/moq#6999 as | ||
| `failed_checks`, and at 07:49 the runner aborted and stayed down for 36 | ||
| minutes. | ||
|
|
||
| Done so far, in the host's configuration: | ||
| an `agent-storage-gc` user timer reclaims idle worktree build outputs and | ||
| leaked test scratch every 10 minutes and logs free space, and the runner unit | ||
| restarts after a crash (that change is in the PR but not yet deployed). | ||
|
|
||
| Remaining: | ||
|
|
||
| - Find what consumed the 480 GB, using the timer's free-space log the next | ||
| time it happens, and fix that source. | ||
| - Guarantee CI a floor: put agent storage (`/home`, `/tmp`) in its own XFS | ||
| project with a hard cap, so an agent gets ENOSPC instead of the queue. | ||
|
|
||
| Decided 2026-10-30 (maintainer, /quest-plan of the 2026-10-30 /quest-complete follow-ups): ✅ new m0 quest / note in the host configuration only / drop. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # [M] The next test-CPU cuts | ||
|
|
||
| ## Goal | ||
|
|
||
| The test costs [moq-dev/moq#6987](https://github.com/moq-dev/moq/pull/6987) | ||
| found but left are cut at their source, with coverage kept. | ||
|
|
||
| ## Plan | ||
|
|
||
| Left by #6987 (halve the slowest tests' CPU): | ||
|
|
||
| - Encode the recovery clips once per run instead of per test. | ||
| - Use `tracing-test`'s `no-env-filter` where its filter costs time. | ||
| - Make the moq-stats oversize tests cheap. | ||
| - Make `a_fill_refused_group_by_group_stays_linear` cheap without losing what | ||
| it proves. | ||
|
|
||
| Measure each before and after, as #6987 did. The export idle poll and mesh | ||
| session cost already have quests in `quest/m2/perf/`, and | ||
| [moq-dev/moq#7075](https://github.com/moq-dev/moq/pull/7075) already decodes a | ||
| moq-quic padding run as one frame. | ||
|
|
||
| Decided 2026-10-30 (maintainer, /quest-plan of the 2026-10-30 /quest-complete follow-ups): ✅ new m0 CI quest / drop. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # [S] Draft-22 interop with a native publisher holds | ||
|
|
||
| ## Goal | ||
|
|
||
| Interop on moq-transport draft 22 with a Rust or C++ publisher stops failing | ||
| with "invalid fetch range" and an audio gap, or is shown not to reproduce on | ||
| current main. | ||
|
|
||
| ## Plan | ||
|
|
||
| [moq-dev/moq#7085](https://github.com/moq-dev/moq/pull/7085) hit it and cited | ||
| `ffi-audio-gap.md`, which [moq-dev/moq#6990](https://github.com/moq-dev/moq/pull/6990) | ||
| deleted. [moq-dev/moq#7204](https://github.com/moq-dev/moq/pull/7204) has | ||
| since limited IETF publishers to one group of history, which may change it. | ||
| Reproduce on current main first. If it no longer reproduces, delete this quest | ||
| with that evidence; otherwise fix the range at its source. | ||
|
|
||
| Decided 2026-10-30 (maintainer, /quest-plan of the 2026-10-30 /quest-complete follow-ups): ✅ new flake child / drop. | ||
|
|
||
| Public API: none. Wire: none unless the fix shows a FETCH range bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # [XS] moq-relay's auth-trust test survives load | ||
|
|
||
| ## Goal | ||
|
|
||
| `http_client::tests::auth_trust_is_independent_from_mesh_verification` in | ||
| moq-relay stops timing out when the host is busy, fixed at its cause. | ||
|
|
||
| ## Plan | ||
|
|
||
| Seen during [moq-dev/moq#6994](https://github.com/moq-dev/moq/pull/6994)'s | ||
| local `just ci`: it timed out under load and passes alone in 0.08 s. Find what | ||
| it waits on by wall clock and make it deterministic, rather than raising a | ||
| timeout. | ||
|
|
||
| Decided 2026-10-30 (maintainer, /quest-plan of the 2026-10-30 /quest-complete follow-ups): ✅ new flake child / drop. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # [S] @moq/net names the origin read side | ||
|
|
||
| ## Goal | ||
|
|
||
| @moq/net exports a named read-side origin interface, `Origin.Reader`, that | ||
| `Origin.Table` extends, so readers such as @moq/watch accept that one name | ||
| instead of repeating a `Pick<Origin.Consumer, ...>` list. | ||
|
|
||
| ## Plan | ||
|
|
||
| [moq-dev/moq#7251](https://github.com/moq-dev/moq/pull/7251) makes @moq/watch | ||
| accept a structural read-side origin and leaves the named interface as a | ||
| follow-up. Name it before the API cut, and move existing `Pick` lists to it. | ||
| If #7251 has not merged, `Player` and `Broadcast` still take `Origin.Table`: | ||
| widen their origin inputs to `Origin.Reader` here. | ||
|
|
||
| Decided 2026-10-30 (maintainer, /quest-plan of the 2026-10-30 /quest-complete follow-ups): ✅ new m1 api-audit quest / drop. | ||
|
|
||
| Public API: @moq/net adds `Origin.Reader`; @moq/watch's origin inputs accept | ||
| it. Both are additive, so nothing migrates. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # [XS] JS join tests cover draft 20 | ||
|
|
||
| ## Goal | ||
|
|
||
| `js/net/src/ietf/join.test.ts` runs its join cases on every moq-transport | ||
| draft @moq/net supports, including draft 20, instead of hard-coding drafts 18 | ||
| and 22. | ||
|
|
||
| ## Plan | ||
|
|
||
| [moq-dev/moq#7190](https://github.com/moq-dev/moq/pull/7190) restored draft 20 | ||
| and added it to `fetch.test.ts`, but `join.test.ts` still names drafts 18 and | ||
| 22. Iterate its cases over the supported versions, as `fetch.test.ts` does, | ||
| with each draft's own expectation: draft 18 joins with a relative joining | ||
| FETCH and draft 22 with a fill, so confirm which path draft 20 takes first. | ||
|
|
||
| Decided 2026-10-30 (maintainer, /quest-plan of the 2026-10-30 /quest-complete follow-ups): ✅ new m1 XS quest / drop. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # [S] Hidden capture idles | ||
|
|
||
| ## Goal | ||
|
|
||
| While nothing reads it (the camera is invisible or every encoder is disabled), | ||
| `Video.Capture` produces no frames, yet unhiding resumes as quickly as it does | ||
| today. | ||
|
|
||
| ## Plan | ||
|
|
||
| [moq-dev/moq#7157](https://github.com/moq-dev/moq/pull/7157) made `muted` and | ||
| `invisible` keep capture open so unmute and unhide skip getUserMedia. The | ||
| capture now keeps producing frames nobody reads. Keep the device open but stop | ||
| pulling and processing frames while unread, and measure the idle CPU before and | ||
| after. | ||
|
|
||
| Decided 2026-10-30 (maintainer, /quest-plan of the 2026-10-30 /quest-complete follow-ups): ✅ new m1 push-to-talk child / drop. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # [S] moq-gst playback shares one session context | ||
|
|
||
| ## Goal | ||
|
|
||
| moq-gst's playback helpers take one session context instead of passing six | ||
| arguments of session plumbing to each other. | ||
|
|
||
| ## Plan | ||
|
|
||
| Suggested by [moq-dev/moq#7084](https://github.com/moq-dev/moq/pull/7084). | ||
| The prerequisite pad-actor refactor landed in | ||
| [moq-dev/moq#7368](https://github.com/moq-dev/moq/pull/7368), reshaping the | ||
| same code. | ||
|
|
||
| Decided 2026-10-30 (maintainer, /quest-plan of the 2026-10-30 /quest-complete follow-ups): ✅ new m2 quest, after moqsrc-pad-actor / fold into it / drop. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: moq-dev/moq
Length of output: 27851
Correct the
#6946prerequisite. The snapshot and stream writers do not take timestamps yet.The quest says the JSON snapshot and stream writers accept optional timestamps "since"
#6946. At this head, they do not. moq-dev/moq#6946 is still open and unmerged. Name it as a prerequisite that lands first, and state that the window methods depend on it.Committable suggestion