Skip to content

chore(quest): retire the verified libav test dependency task - #7430

Merged
moq-bot[bot] merged 3 commits into
mainfrom
quest/m0/nightly/hang-libav-tests
Nov 1, 2026
Merged

moq-bot[bot] merged 3 commits into
mainfrom
quest/m0/nightly/hang-libav-tests

Conversation

@kixelated

@kixelated kixelated commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The libav test quest hypothesized that the JS gate did not build @moq/libav before running hang tests. On current main, that dependency already exists: sh/js/workspace.py runs bun install --frozen-lockfile before package scripts, and the root postinstall runs js/libav/build.ts.

Approach

  • Verified from a fresh worktree at main a1169021b6f250309b4428e8f28b03dcdc4236af, initially without node_modules, js/libav/dist, or js/libav/result.
  • Running the two tests before installation fails to resolve @moq/libav. The supported frozen install builds libav through the existing hook, and both tests then pass (33 assertions). All 311 hang tests also pass (20,515 assertions).
  • Delete the completed quest and its epic link. The earlier failure reported in moq-dev/moq#7061 is not reproducible after supported setup; its original cause remains unconfirmed.

Impact

  • Public API: none.
  • Wire: none.
  • No runtime, test, dependency, or build changes. No generated WebAssembly committed.

Alternatives

A second explicit libav build in the gate would duplicate the existing install hook. Skipping these tests would hide coverage that already works after installation.

Choices made without asking

Retire the quest based on the passing supported setup rather than add redundant build machinery. The user authorized recommended decisions while AFK.

Validation

  • quest check --base origin/main: 679 documents OK.
  • Frozen install followed by bun test js/hang/src/util/libav.test.ts: 2 passed.
  • bun run --cwd js/hang test: 311 passed.
  • just ci: passed with the Nix dev shell, its pinned Rust toolchain first on PATH, and BASH_ENV=/dev/null. The harness Bash startup hook otherwise restores the host mbx Cargo wrapper in child shells; two earlier runs failed in unchanged Rust selector tests with mbx Argument list too long. No repository code was changed to work around that host issue.

Review

Head 4f2b30021df5b2abd37cabd40634e3d78f01dcc3: skipped under the quest guide's trivial-change exception. The diff only deletes the completed quest and its epic link; source and tests are unchanged. Local quest review --base origin/main attempted Claude Code's default reviewer but could not run: weekly quota exhausted until November 2. No independent review verdict is claimed.

Follow-ups

No libav follow-up needed. The separate host mbx wrapper failure was observed and left outside this quest's scope.

(Written by GPT-6.1 Sol)

kixelated and others added 2 commits October 31, 2026 02:04
The root postinstall already runs js/libav/build.ts, and the JS gate installs dependencies before package tests. A fresh supported install builds libav and both targeted tests pass on origin/main a116902. Avoid duplicating that build or skipping tests that already pass.

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@kixelated kixelated changed the title @moq/hang's libav tests pass on main chore(quest): retire the verified libav test dependency task Oct 31, 2026
@kixelated
kixelated marked this pull request as ready for review October 31, 2026 09:12
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cada7be8-2b66-4384-a8d2-055863c8ab08
Commits

Reviewing files that changed from the base of the PR and between a116902 and 4f2b300.

Files selected for processing: 2
  • quest/m0/nightly/README.md
  • quest/m0/nightly/hang-libav-tests.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 4f2b30021df5b2abd37cabd40634e3d78f01dcc3.

No actionable bugs found. The diff consistently removes the completed libav quest and its epic link without changing source, tests, dependencies, or build behavior. Retiring the task rather than adding a second build step is the simpler direction: the existing JS runner installs dependencies before tests, and the root postinstall invokes the libav build.

Verification: static review of the diff and the existing workspace/install/build chain only. I did not run tests or independently reproduce the reported fresh-worktree results; the original failure's cause remains unconfirmed.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Epic link removed — quest/m0/nightly/README.md drops the ## Required bullet for the libav quest.
  • Quest deleted — quest/m0/nightly/hang-libav-tests.md (15 lines) removed.

I verified the retirement's clearing condition: a repo-wide grep for hang-libav-tests returns no dangling prose or cross-link references, and the epic README's hand-maintained bullet is gone. The stated dependency also holds in the tree: sh/js/workspace.py:153 runs bun install --frozen-lockfile, and the root postinstall (package.json:30) runs bun run --cwd js/libav build, so the supported install builds js/libav before the hang tests run. Documentation-only change with no runtime, test, dependency, or wire impact.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing summary: this PR retires quest/m0/nightly/hang-libav-tests.md and its link from the nightly epic. The supported frozen install already builds @moq/libav through the root postinstall before hang tests run, so no gate change is needed. Both online reviews (OpenAI, Pullfrog) found no issues on head 4f2b30021df5b2abd37cabd40634e3d78f01dcc3. The recorded trivial-change review skip covers this head, and quest check --base origin/main passes (679 documents). No decisions were outstanding.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) October 31, 2026 16:25
@moq-bot
moq-bot Bot disabled auto-merge November 1, 2026 03:41
@moq-bot moq-bot Bot removed the quest:merge label Nov 1, 2026
@moq-bot

moq-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

quest land removed this pull request from the queue: the batch check failed (exit 1).

@moq/hang:test            | skipping missing groups: track=test 1 -> 2
@moq/hang:test            | 
@moq/hang:test            | src/util/libav.test.ts:
@moq/hang:test            | using libav WebCodecs polyfill; performance may be degraded
@moq/hang:test            | 
@moq/hang:test            |  311 pass
@moq/hang:test            |  0 fail
@moq/hang:test            |  20515 expect() calls
@moq/hang:test            | Ran 311 tests across 27 files. [3.40s]
@moq/hang:test            | Done in 3.46s
@moq/interop-browser:test | bun test v1.4.2 (744846f84)
@moq/interop-browser:test | killed 1 dangling process
@moq/interop-browser:test | 
@moq/interop-browser:test | src/native.test.ts:
@moq/interop-browser:test |  6 | // frame, so the native picture cannot drift from the one the fixture paints.
@moq/interop-browser:test |  7 | const ffmpeg = Bun.which("ffmpeg");
@moq/interop-browser:test |  8 | 
@moq/interop-browser:test |  9 | function render(args: string[]): Uint8Array {
@moq/interop-browser:test | 10 | 	const run = Bun.spawnSync([ffmpeg ?? "ffmpeg", "-hide_banner", "-loglevel", "error", ...args]);
@moq/interop-browser:test | 11 | 	if (run.exitCode !== 0) throw new Error(`ffmpeg failed: ${run.stderr.toString()}`);
@moq/interop-browser:test |                                                                                        ^
@moq/interop-browser:test | error: ffmpeg failed: 
@moq/interop-browser:test |       at render (/work/test/interop/clients/js/src/native.test.ts:11:83)
@moq/interop-browser:test |       at <anonymous> (/work/test/interop/clients/js/src/native.test.ts:24:15)
@moq/interop-browser:test | (fail) the native picture decodes as the frame ffmpeg numbered it [6060.13ms]
@moq/interop-browser:test |   ^ this test timed out after 5000ms.
@moq/interop-browser:test | 
@moq/interop-browser:test |  24 pass
@moq/interop-browser:test |  1 fail
@moq/interop-browser:test |  181 expect() calls
@moq/interop-browser:test | Ran 25 tests across 7 files. [7.19s]
@moq/interop-browser:test | Exited with code 1
Traceback (most recent call last):
  File "/work/sh/js/workspace.py", line 229, in <module>
    main()
    ~~~~^^
  File "/work/sh/js/workspace.py", line 224, in main
    run(action, plan)
    ~~~^^^^^^^^^^^^^^
  File "/work/sh/js/workspace.py", line 158, in run
    scripts("test")
    ~~~~~~~^^^^^^^^
  File "/work/sh/js/workspace.py", line 142, in scripts
    command("bun", "run", *concurrency, *filters, "--elide-lines=0", verb)
    ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/sh/js/workspace.py", line 131, in command
    subprocess.run(args, cwd=cwd, check=True)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/xahxrjs30p3mw0a42bqg9ikgkikskw8m-python3-3.14.8/lib/python3.14/subprocess.py", line 578, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '('bun', 'run', '--sequential', '--filter=@moq/audio-quality', '--filter=@moq/auth', '--filter=@moq/bench-browser', '--filter=@moq/boy', '--filter=@moq/clock', '--filter=@moq/demo-carla', '--filter=@moq/e2ee', '--filter=@moq/hang', '--filter=@moq/interop-browser', '--filter=@moq/json', '--filter=@moq/msf', '--filter=@moq/net', '--filter=@moq/p2p', '--filter=@moq/pattern', '--filter=@moq/publish', '--filter=@moq/qmux', '--filter=@moq/room', '--filter=@moq/sign', '--filter=@moq/signals', '--filter=@moq/ui', '--filter=@moq/video', '--filter=@moq/watch', '--filter=moq-doc', '--elide-lines=0', 'test')' returned non-zero exit status 1.
error: recipe `test-changed` failed on line 54 with exit code 1
ci: check go cancelled in 110s
==> check go
bash ../sh/go/check.sh
go check: gofmt -l...
go stage: building moq-ffi for x86_64-unknown-linux-gnu...
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.83s
mbx[savings]: has quietly disposed of 9.3 TiB logical of build leftovers. nobody saw anything.
go stage: generating bindings...
go stage: assembling ffi module...
  go lib linux_amd64 <- x86_64-unknown-linux-gnu (605 MiB)
  go lib linux_arm64: skipped, /work/dist/go-libs/aarch64-unknown-linux-gnu/libmoq_ffi.a missing
  go lib darwin_arm64: skipped, /work/dist/go-libs/aarch64-apple-darwin/libmoq_ffi.a missing
  go lib windows_amd64: skipped, /work/dist/go-libs/x86_64-pc-windows-msvc/moq_ffi.lib missing

Staged: /work/dist/go-ffi-pkg/moq-ffi-0.0.0-dev-go
go stage: staging wrapper module...
  skipping go mod tidy (no go.sum staged)

Staged: /work/dist/go-wrapper-pkg/moq-go-0.7-wrapper
go check: checking error sentinels...
go check: go vet ./...
go check: go build ./...
go check: go test -race ./...
error: recipe `check` failed on line 17 with exit code 143
ci: test js failed
ci: seconds per module
   375  check py
    62  test py
    54  check rs
   436  test rs
   506  check c
   270  check cpp
    34  check obs_compile
   323  check js
    23  test js (failed)
   220  check kt
     0  check swift
   110  check go (cancelled)
     0  check drill
     4  check quest
    29  check shell
     1  check large_files
     0  check toml
     1  check nix
     0  check justfile
   836  wall time
error: recipe `ci` failed on line 107 with exit code 1

.

@moq-bot
moq-bot Bot enabled auto-merge (squash) November 1, 2026 03:47
@moq-bot moq-bot Bot added the quest:merge label Nov 1, 2026
@moq-bot

moq-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

codex / Codex land fixer: Requeued unchanged: healthy; flaky test "the native picture decodes as the frame ffmpeg numbered it" (test/interop/clients/js/src/native.test.ts) timed out at 5000ms; unchanged from base and rerun passed

(written by codex / Codex)

@moq-bot
moq-bot Bot merged commit b652b3e into main Nov 1, 2026
2 checks passed
@moq-bot
moq-bot Bot deleted the quest/m0/nightly/hang-libav-tests branch November 1, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant