Repository navigation
fix(quic): sync Quinn and BBR3 correctness fixes - #7458
Conversation
Quest-Claim: 01a91a51935fbafe
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
# Conflicts: # quest/m1/vendor-sync/quinn.md # rs/moq-quic/README.md # rs/moq-sock/src/udp/apple_fast.rs # rs/moq-sock/tests/udp/main.rs
The Apple source-address fix landed on main in #7418, so the merge keeps main's moq-sock and the fork ledger credits it. With the BBR3 refresh ported and the ledger checked through 2c575013, this run is done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Snapshot the precautionary-stop flag with the other loss-undo state and restore it while its feedback round is still running, so a spurious loss in that round no longer delays the next probe by a full bw_probe_wait. Clear the flag once the feedback round ends, so it never outlives the probe it marks. Drop the bench's Recovery mode: only its first ACK differed from Steady. Move the deleted quinn quest's sync hints into the moq-quic README, so the next run finds them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since an idle ACK renews the application-limited marker, the round sent right after it is application-limited, as draft-06 labels every packet sent while C.app_limited is set. Startup's probe fill therefore ends one round later, on the sender's next round of its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- BBR3 recovery-window restore —
check_recovery_donenow restores the savedprior_cwndon the recovery-exit transition, andsave_cwndkeys onin_recovery; this matches upstream01b8848d. - BBR3 Startup ACK aggregation —
update_ack_aggregationholds the per-round maximum in Startup rather than overwriting it on each ACK. - BBR3 precautionary probe —
maybe_go_downstops a probe atinflight_longtermwhen the prior probe found excess loss,adapt_long_term_modelrestarts a refill on clean feedback, and spurious-loss undo snapshots/restoresprev_probe_precautionary; probe-bound growth is saturated. - Application-limited renewal —
rate.rsclears and renewsapp_limitedas two independent steps, so an idle ACK crossing the old marker still renews the label (matches upstreamon_end_acks). - Vendor-sync ledger — the completed
quest/m1/vendor-sync/quinn.mdis deleted, its sync guidance folds intors/moq-quic/README.md, and the README records the advisories and new upstream heads (2c575013/4b84837d) with the ported/held commits.
I read the diff end to end and verified it independently: the port tracks the actual quinn#2481 head 01b8848d, cargo test -p moq-congestion --lib reports 102 passed / 1 ignored, and clippy --all-targets -D warnings plus fmt --check are clean. Two divergences from upstream are deliberate and benign: on_spurious_loss restores the precautionary history conditionally (documented in the PR body, with a regression test), and check_recovery_done adds an in_recovery guard (restore is max, so idempotent). No public API or wire changes; congestion-control behavior only.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

Problem
The Quinn fork ledger had not recorded the latest upstream comparison, and the carried BBR3 lacked several fixes from the force-pushed quinn-rs/quinn#2481.
Approach
mainthrough2c575013,0.11.xthrough4b84837d, BBR3 quinn-rs/quinn#2481 through01b8848d, and all 13 published advisories. Record the heads and dispositions inrs/moq-quic/README.md.moq-congestion): keep Startup's per-round ACK aggregation maximum, restore the saved window once when recovery ends, preserve it into ProbeRTT (save_cwndkeys on recovery, as draft-06 does), renew application-limited markers, saturate probe growth, and stop a probe at the previous loss bound (precautionary probing) before accelerating again on clean feedback. Spurious-loss undo restores that probe history, including a precautionary stop still waiting on its feedback round.IP_PKTINFOsource-address fix (a2c55b36) landed on main separately in moq-dev/moq#7418. The ledger credits that PR, and this PR does not touchmoq-sock.quest/m1/vendor-sync/quinn.mdis deleted withquest rm. Its standing sync guidance (check the fork's reworked code first, whereEndpointfixes land, compare0.11.xby subject, check quinn#2481 each run) moves into the moq-quic README'sUpstreamsection, as the other vendor-sync children recorded theirs. The vendor-sync README re-creates the child for the next cycle.Impact
C.app_limitedis set. Startup's probe fill therefore lasts one round longer, ending on the sender's next round of its own.probe_inflight_fills_one_up_per_probe_waitnow expects that.Alternatives
The idle-accept, reset-credit, IPv6 binding, GSO, and release-branch receive-error fixes already hold in the fork; reapplying them would add no behavior. Dependency bumps are skipped. Batched
read_datagramsstays out until the planned lock profile shows a consumer worth changing the API for.Decisions
moq-sockcode, so nothing needs a Mac. This supersedes the 2026-11-01 instruction to keep the PR a draft for it.rs/moq-quic/README.md(main'sControllerMetrics→Metricsrename) and auto-mergedbbr3/mod.rs. Its Startup-fill test needed the update under Impact.bw_probe_fill, as main's spurious-loss undo already does throughstart_probe_bw_refill. It fires only after a probe hit loss, so the extra fill stays bounded.Recoverybenchmark mode: only its first ACK differed fromSteady(review round 1).Checks
On
af9218d6, Linux, insidenix develop:quest gate nix develop -c just ci origin/main: passed (exit 0). 6526 tests run, 6526 passed, 110 skipped; Rust, JS, workers, Markdown, gh, drill, quest, shell, large-files, toml, nix, and justfile checks all passed.quest check --base origin/main --branch quest/m1/vendor-sync/quinn: 616 documents ok.cargo nextest run -p moq-congestion -p moq-quic: 812 passed, 16 skipped.spurious_loss_keeps_the_precautionary_refillfails without the undo restore and passes with it.Review
Reviewer: Claude Code (
quest review --harness claude, other vendor to the Codex author), model Claude Opus 5.5 (claude-opus-5-5), medium effort, session2255062e, againstorigin/main.Reviewed head:
af9218d6, round 4: no findings.3c02c70f, the merge of main): three findings, all fixed in26263090.on_spurious_lossforcedprev_probe_precautionaryfalse). It is now snapshotted and restored while ProbeBW_DOWN's feedback round is still running, and cleared when that round ends. Regression test added.Recoverymode repeatedSteady;bench.rsis back to main's.quinn.mdlost its sync hints; they now live in the moq-quic README.e6261bc0, then26263090aftercargo fmt): no findings.af9218d6): no findings on the moq-dev/moq#7429 test update, which followed a local CI failure verified against main'srate.rs. That was the fourth round: no findings remained, so the approach stands.Follow-ups
No upstream posts were made.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code