Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quest/m0/ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,5 +167,6 @@ The historical samples locate candidates; they are not controlled benchmarks.
- [The queue host keeps the queue's disk](/quest/m0/ci/queue-host-disk.md) - agent sessions can't starve the queue runner of disk, and a crashed runner restarts
- [The next test-CPU cuts](/quest/m0/ci/test-cost-followups.md) - the slow-test leftovers from #6987, cut at their source
- [Biome checks every file it can parse](/quest/m0/ci/biome-whole-repo.md) - Biome runs over the whole repository and main is clean under it
- [Dispatcher tool changes run the dispatcher tests](/quest/m0/ci/dispatch-selection-gaps.md) - a tool-list change runs `sh/dispatch-query.test.py` in CI, and `sh/rs/uring.test.py` stops printing jq errors
- [dispatch.sh's tests pass without KVM](/quest/m0/ci/dispatch-test-kvm.md) - `sh/dispatch-query.test.py` fakes the KVM probe instead of failing 20 tests on hosts without `/dev/kvm`
- [mbx launches Cargo with any argument length](/quest/m0/ci/mbx-arg-max.md) - no "Argument list too long" in `sh/rs/select.test.py`'s recipe test
36 changes: 36 additions & 0 deletions quest/m0/ci/dispatch-selection-gaps.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# [S] Dispatcher tool changes run the dispatcher tests

## Goal

A change to the dispatcher's tool lists (`sh/dispatch.sh` and the files it
reads them from) runs `sh/dispatch-query.test.py` in CI, so a tool added to a
module can't break that suite on `main` unnoticed. `sh/rs/uring.test.py`
runs without the repeated `jq: error ... null (null) cannot be matched`
lines.

## Plan

Decided 2026-10-31 (maintainer, the /quest-complete requeue session), from
[moq-dev/moq#7432](https://github.com/moq-dev/moq/pull/7432).

- **Selection.** [6633d2f2e2](https://github.com/moq-dev/moq/commit/6633d2f2e2)
added `zizmor` to the `gh` module's tools in `sh/dispatch.sh`, and every
`CI_STRICT` case of `sh/dispatch-query.test.py` then failed with "these
tools are missing: zizmor" on `main`; #7432 fixes the stub. `run_lane` in
`sh/dispatch.sh` says gh's tests run on every `check` diff, and a change to
`sh/dispatch.sh` selects everything, so find why the commit's CI didn't run
or didn't fail on the suite (`.github/justfile` `test`, the CI lane that
runs it, the land gate) and fix that gap rather than adding a path rule.
- **jq noise.** `python3 sh/rs/uring.test.py` passes but prints
`jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a
string` four times. Its cargo-metadata fixture has no `workspace_root` or
`targets`, which the seed filter in `sh/rs/select.sh` (around line 66)
reads. Make the fixture complete, or make the filter tolerate their
absence, whichever matches real `cargo metadata` output.

Public API: none. Wire: none.

## Related

- [workspace.test.py ignores the caller's gate filter](https://github.com/moq-dev/moq/pull/7432) - #7432's quest, the same dispatcher test environment
- [moq-dev/moq#7440](https://github.com/moq-dev/moq/pull/7440) - plans `quest/m0/ci/check-selection.md`, which makes a jq error in Rust selection fail the run; that turns this jq noise into a failure, so land the fixture fix first or together. It does not cover the tool-list selection gap
1 change: 1 addition & 0 deletions quest/m0/test-flakes-2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,4 @@ Public API: none. Wire: none.
- [IETF22 fallback](/quest/m0/test-flakes-2/ietf22-fallback.md) - an IETF22 browser viewer follows a fallback within the media lane's bound, keeping its session and its audio
- [moq-relay's auth-trust test survives load](/quest/m0/test-flakes-2/relay-auth-trust.md) - it stops timing out on a busy host
- [Draft-22 interop with a native publisher](/quest/m0/test-flakes-2/draft22-interop.md) - no "invalid fetch range" or audio gap with a Rust or C++ publisher
- [A Kotlin cancel test and a JS late-publisher test hold up](/quest/m0/test-flakes-2/kotlin-js-flakes.md) - the Kotlin flow-cancel test stops failing `unroutable` and the IETF blind-handle test passes under load
29 changes: 29 additions & 0 deletions quest/m0/test-flakes-2/kotlin-js-flakes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# [S] A Kotlin cancel test and a JS late-publisher test hold up

## Goal

Two intermittent failures are fixed at their cause: the Kotlin test
"cancelling a flow collection cancels its native handle" no longer fails
with `unroutable`, and the JS integration test "ietf blind handle picks up a
publisher that arrives late" passes under a heavily loaded `just check`.

## Plan

Decided 2026-10-31 (maintainer, the /quest-complete requeue session):
root-cause both in one quest, since each is small and they surfaced
together in that session's merge runs.

- **Kotlin.** `kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt:579`.
An `unroutable` answer means no route served the path when the request
resolved. A request made before the publisher's route reached the origin
returns it, and so does one made after that route was withdrawn or the
broadcast closed. Check both a wait on announcement that the test skips
and a route withdrawal or close during the collection it cancels.
- **JS.** `js/net/src/integration.test.ts:1994`, the moq-transport variant
of the lite test at `:1929`. Under load the late publisher's arrival and
the blind handle's wait race some deadline; find which, and replace the
wall-time dependency with an event or a controlled clock.

Follow the epic's rules: no raised timeout and no retry.

Public API: none. Wire: none.
3 changes: 3 additions & 0 deletions quest/m1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ per-frame CPU growth since #5926.
- [Address groups by timestamp](/quest/m1/time-addressing/README.md) - group start timestamps replace sequence numbers in the moq-net API and lite-07 wire, while old subscribers, old publishers, and published JS clients keep working
- [Pre-cut audit findings](/quest/m1/cut-audit/README.md) - fix the crashes, hostile-input costs, and correctness bugs the 2026-10-24 audit of main found
- [Vendored code has every upstream fix it needs](/quest/m1/vendor-sync/README.md) - quinn, libv4l-rs, nvidia-video-codec-sdk, rust-media-libs, cros-codecs, and UniFFI generator fixes are ported or planned, once per release cycle
- [fMP4 refusals keep framing](/quest/m1/fmp4-refusal-framing.md) - a box refused at its header stops dropping the rest of its call's input, and the interleaved import benchmark is re-measured
- [MKV leaf element limits](/quest/m1/mkv-leaf-limits.md) - `CodecID`, `DocType`, and `CodecPrivate` are refused past per-element size limits instead of read whole
- [Delete the tests that don't earn their cost](/quest/m1/prune-tests.md) - an off-cycle test cost sweep deletes tests whose cost outweighs their signal and makes the rest cheaper
- [Remove the dependencies that don't earn their weight](/quest/m1/prune-deps.md) - Rust, JS, and vendored dependencies that are trivial, duplicated, or serve features not worth keeping are removed
- [Remove what dominates build time](/quest/m1/prune-build-time.md) - the crates, features, and code that cost the most build time are removed or made cheaper
Expand Down Expand Up @@ -177,6 +179,7 @@ per-frame CPU growth since #5926.
- [Interop coverage](/quest/m1/interop-coverage/README.md) - the riskiest moq-transport features moq-net exposes get cross-implementation tests over drafts 18 and 22
- [Calibrate the paired nightly benchmarks](/quest/m1/bench-ci.md) - A/A and deliberately slowed Nightly runs set the paired comparison's threshold, so its regression alerts can be trusted
- [The shared pacer holds its rate under 2 Mbit/s](/quest/m1/pacer-low-rate.md) - a rate-paced controller stops sending up to twice its pacing rate at low rates, landed with a BBR3 retune that keeps the probe budgets
- [A reconfigure keeps the published jitter and delay floor](/quest/m1/catalog-jitter-floor.md) - `Rendition::set` floors unsupplied jitter and delay at the catalog's values, so a same-codec reconfigure after a jitter rise no longer aborts TS import
- [HLS and DASH segment conformance](/quest/m1/hls-conformance.md) - nightly ffprobe checks that advertised timing, sync flags, and bytes match the media served
- [Unbounded groups](/quest/m1/unbounded-groups/README.md) - groups and frames lose their size caps; a group keeps a 32 MB tail, and readers behind it replay through paced flights or refresh
- [Legacy lite close drain](/quest/m1/lite-legacy-close-drain.md) - a lite-01..06 graceful close never cuts a final group the subscriber has not read
Expand Down
22 changes: 22 additions & 0 deletions quest/m1/announce-takeover.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,28 @@ Remove the cold-start warm-up reads (`claimed` in
assert that the first subscription succeeds. Keep them for moq-transport.
Run `just check`, `just test interop --all` and `just drafts check`.

### Once identity replaces ANNOUNCE_TAKEOVER

Decided 2026-10-31 (maintainer, the /quest-complete requeue session). Kept
separate from the identity rewrite of this Plan, which landed with
[moq-dev/moq#7420](https://github.com/moq-dev/moq/pull/7420).
"We're replacing EPOCH with IDENTITY soon" (maintainer, 2026-10-31).

- Reword "takeover" as an event or operation, in terms of identity
continuity, in [moq-bench pins the instances it measures](/quest/m2/bench-epoch-pin.md)
(Goal and Plan), [the HLS server follows each path once](/quest/m2/hls-follow-once.md)
(Goal and Tests), and [routes and announces](/quest/m1/cluster-routing/routes.md)
(around line 37, "the separately proven Takeover operation").
- Rewrite the EPOCH references in `drafts/draft-lcurley-moq-cluster.md` and
`drafts/draft-lcurley-moq-epoch.md` in terms of IDENTITY.
- Add a regression test where a publisher restart's new announcement
arrives before the old one's reset, on `solicit = false` moq-transport
sessions. [moq-dev/moq#7239](https://github.com/moq-dev/moq/pull/7239)
found that the subscriber (`rs/moq-net/src/ietf/subscriber.rs`, `attach`)
folds such a PUBLISH_NAMESPACE into the same epochless route as an update
instead of End then Start; per-announcement identities resolve it, and
the test proves they do.

Public API: breaking; removes `Takeover` and the predecessor fields in every
language. Wire: removes lite-07's ANNOUNCE_TAKEOVER (0x5), adding nothing
beyond [Identity and epoch](/quest/m1/api-audit/route/identity.md)'s fields.
Expand Down
44 changes: 44 additions & 0 deletions quest/m1/catalog-jitter-floor.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# [S] A reconfigure keeps the published jitter and delay floor

## Goal

Re-setting an already-published rendition, such as an H.264 or H.265
same-codec resolution change, never lowers the jitter or delay its catalog
already advertises for a field the new config leaves unset. The reconfigure
publishes with the higher of the two, as a measurement does, instead of
failing with `JitterDecreased` and aborting the TS import.

## Plan

Decided 2026-10-31 (maintainer, the /quest-complete requeue session), found
by the sessions of [moq-dev/moq#7436](https://github.com/moq-dev/moq/pull/7436)
and [moq-dev/moq#7387](https://github.com/moq-dev/moq/pull/7387). Planned
here in m1 as its own [S] rather than fixed inside #7436 (no test there needs
it) or dropped: it blocks the conformance test in #7387 once that fixture is
repaired.

`Rendition::set` (`rs/moq-mux/src/catalog/tracks.rs:655`) resolves the new
config from what it supplies plus the last measurement (`Self::resolved`),
then `check_decrease` refuses anything below the catalog's current jitter or
delay. `Rendition::estimate` (`:711`) already floors its result at the
published values (`resolved.jitter.max(published.jitter)`, `:725-726`).
After a measurement raises jitter mid-run, a reconfigure that supplies no
jitter resolves to the lower detected value and fails. Floor the unsupplied
jitter and delay in `set` at the catalog's published values the same way, so
`check_decrease` still refuses only a value the caller explicitly lowers.

`published_text_jitter_never_decreases` (`:1078`) expects a `None` re-set
after a supplied 100 ms to fail; with the floor it publishes 100 ms. Keep
the explicit-lower case failing and update the `None` case to the floor.
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved

Regression test: a unit test in `tracks.rs` that publishes a video config,
raises its jitter with `estimate`, then `set`s a config with new dimensions
and no jitter, and asserts it succeeds with the raised jitter still
published.

Public API: none. Wire: none.

## Related

- [HLS and DASH segment conformance](/quest/m1/hls-conformance.md) - the conformance test this unblocks
- [HLS export follows a resolution change](/quest/m1/hls-reinit-same-codec.md) - the same-codec reconfigure that hits it
43 changes: 43 additions & 0 deletions quest/m1/fmp4-refusal-framing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# [S] fMP4 refusals keep framing

## Goal

A box the fMP4 importer refuses at its header no longer leaves a caller
feeding arbitrary chunks out of frame. Either the importer reads the rest of
that decode call's input past the refused box, so later calls stay
correctly framed whatever chunk boundaries the caller picks, or the refusal
is terminal and every later call fails, so no input is silently dropped
mid-stream. The 4-track
interleaved import benchmark is no slower than before the streaming change,
or the cost is measured and accepted.

## Plan

Decided 2026-10-31 (maintainer, the /quest-complete requeue session), from
the follow-ups of [moq-dev/moq#7232](https://github.com/moq-dev/moq/pull/7232)
(fMP4 streams mdat) and [moq-dev/moq#7234](https://github.com/moq-dev/moq/pull/7234)
(MKV streams blocks). Both have landed. #7234 landed first, so #7232 already
streams the importer's samples through `Producer::open`/`commit`; the
original open/commit bullet is done, and this quest keeps the other two
([noted on moq-dev/moq#7468](https://github.com/moq-dev/moq/pull/7468#issuecomment-6554670247)).

- **A refused box.** `Import::decode` (`rs/moq-mux/src/container/fmp4/import.rs`)
documents it: a refused box or fragment discards the rest of its body, and
the rest of the refusing call's input is not read. That suits box-aligned
callers (HLS ingest feeds one segment per call) but loses framing for
arbitrary chunking. Either continue past the refused box, or make a
refusal terminal for the importer as the MKV importer's is. Choose during
implementation the option that keeps the importer's state simpler while
meeting HLS ingest's needs, and record the choice in the PR.
- **Benchmark.** #7232 measured a possible ~25% slowdown in the 4-track
16-run whole-input `cmaf-interleaved-import` case, in a noisy run where the
4-track cases swung ±40% between runs of one source. Re-measure it with the
paired comparison on a quiet host, against the commit before #7232, and
fix it or record why it is accepted.

Public API: none expected. Wire: none.

## Related

- [MKV leaf element limits](/quest/m1/mkv-leaf-limits.md) - the other leftover of the importer streaming work
- [Media fuzz](/quest/m2/media-fuzz.md) - would catch a dropped-input bug like the refused-box one
6 changes: 6 additions & 0 deletions quest/m1/hls-conformance.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,15 @@ Decided 2026-10-30 (maintainer): fix first. The two bugs the test found
are their own quests, required below, and the test lands once it passes
with both checks intact.

Added 2026-10-31 (maintainer, the /quest-complete requeue session): once
the fixture is repaired, the test's TS import hits a third bug, a
reconfigure failing `JitterDecreased` after a mid-run jitter rise, also its
own quest below.

## Required

- [HLS export follows a resolution change](/quest/m1/hls-reinit-same-codec.md) - the conformance test's same-codec switch fails until it lands
- [A reconfigure keeps the published jitter and delay floor](/quest/m1/catalog-jitter-floor.md) - the conformance test's TS import aborts with `JitterDecreased` at its reconfigure until it lands

## Related

Expand Down
35 changes: 35 additions & 0 deletions quest/m1/mkv-leaf-limits.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# [XS] MKV leaf element limits

## Goal

The MKV importer refuses a `CodecID`, `DocType`, or `CodecPrivate` element
whose declared size is past a limit specific to that element, so a header
declaring a huge one cannot pin importer memory.

## Plan

Decided 2026-10-31 (maintainer, the /quest-complete requeue session), a
follow-up of [moq-dev/moq#7234](https://github.com/moq-dev/moq/pull/7234),
which streams blocks and discards ignored elements but still reads these
three leaf elements whole (`rs/moq-mux/src/container/mkv/import.rs`, where
the track entry collects `CodecID` and `CodecPrivate`). #7234 has landed.

The maintainer earlier ruled out a blanket tag-size cap (it would refuse
large Segments and Clusters). These limits are per element
and bound only what the importer must hold whole: a `CodecID` and `DocType`
are short ASCII strings, and `CodecPrivate` is the decoder config of a
codec the importer supports: avcC (`V_MPEG4/ISO/AVC`), hvcC
(`V_MPEGH/ISO/HEVC`), av1C (`V_AV1`), an OpusHead (`A_OPUS`), an AAC
AudioSpecificConfig (`A_AAC`), or a FLAC header (`A_FLAC`). The FLAC header
carries every metadata block, so it can hold embedded cover art; size its
limit for that or refuse such art explicitly. Pick each limit from its spec
and the largest real decoder config, check them against the MKV fixtures
for each codec, and return the
importer's existing error for a refused element. Test each element declared
past its limit, fed in small chunks.

Public API: none. Wire: none.

## Related

- [fMP4 refusals keep framing](/quest/m1/fmp4-refusal-framing.md) - the fMP4 leftover of the same streaming work
Loading