Repository navigation
quest: plan follow-ups from the 2026-10-31 /quest-complete requeue session #7468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ba3f8fb
quest: plan follow-ups from the 2026-10-31 /quest-complete requeue se…
kixelated 909cae8
quest: narrow clock expectations before dropping the env-write text c…
kixelated 5cefe06
Merge branch 'base' into pr-7468
de0f07c
docs(quest): restore plan section and completed quest reference
8458828
quest land: merge tested base
e2e3160
Merge remote-tracking branch 'origin/main' into quest-plan/2026-10-31…
kixelated fb7bd24
quest: align follow-ups with main and address review threads
kixelated f5eccf5
quest: settle refusal framing goal and e2ee inflated-size header
kixelated 9370014
quest land: merge tested base
7c6eda5
Merge remote-tracking branch 'origin/main' into quest-plan/2026-10-31…
kixelated df6c9f2
quest: bound e2ee relay properties, clarify fMP4 refusal wording
kixelated 6db7ce2
Merge remote-tracking branch 'origin/main' into quest-plan/2026-10-31…
kixelated 68db1ec
quest land: merge tested base
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # [S] Dispatcher tool changes run the dispatcher tests | ||
|
|
||
| ## Goal | ||
|
|
||
| A change to the dispatcher's tool lists (`sh/dispatch.sh` and the files it | ||
| reads them from) runs `sh/dispatch-query.test.py` in CI, so a tool added to a | ||
| module can't break that suite on `main` unnoticed. `sh/rs/uring.test.py` | ||
| runs without the repeated `jq: error ... null (null) cannot be matched` | ||
| lines. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-31 (maintainer, the /quest-complete requeue session), from | ||
| [moq-dev/moq#7432](https://github.com/moq-dev/moq/pull/7432). | ||
|
|
||
| - **Selection.** [6633d2f2e2](https://github.com/moq-dev/moq/commit/6633d2f2e2) | ||
| added `zizmor` to the `gh` module's tools in `sh/dispatch.sh`, and every | ||
| `CI_STRICT` case of `sh/dispatch-query.test.py` then failed with "these | ||
| tools are missing: zizmor" on `main`; #7432 fixes the stub. `run_lane` in | ||
| `sh/dispatch.sh` says gh's tests run on every `check` diff, and a change to | ||
| `sh/dispatch.sh` selects everything, so find why the commit's CI didn't run | ||
| or didn't fail on the suite (`.github/justfile` `test`, the CI lane that | ||
| runs it, the land gate) and fix that gap rather than adding a path rule. | ||
| - **jq noise.** `python3 sh/rs/uring.test.py` passes but prints | ||
| `jq: error (at <stdin>:36): null (null) cannot be matched, as it is not a | ||
| string` four times. Its cargo-metadata fixture has no `workspace_root` or | ||
| `targets`, which the seed filter in `sh/rs/select.sh` (around line 66) | ||
| reads. Make the fixture complete, or make the filter tolerate their | ||
| absence, whichever matches real `cargo metadata` output. | ||
|
|
||
| Public API: none. Wire: none. | ||
|
|
||
| ## Related | ||
|
|
||
| - [workspace.test.py ignores the caller's gate filter](https://github.com/moq-dev/moq/pull/7432) - #7432's quest, the same dispatcher test environment | ||
| - [moq-dev/moq#7440](https://github.com/moq-dev/moq/pull/7440) - plans `quest/m0/ci/check-selection.md`, which makes a jq error in Rust selection fail the run; that turns this jq noise into a failure, so land the fixture fix first or together. It does not cover the tool-list selection gap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # [S] A Kotlin cancel test and a JS late-publisher test hold up | ||
|
|
||
| ## Goal | ||
|
|
||
| Two intermittent failures are fixed at their cause: the Kotlin test | ||
| "cancelling a flow collection cancels its native handle" no longer fails | ||
| with `unroutable`, and the JS integration test "ietf blind handle picks up a | ||
| publisher that arrives late" passes under a heavily loaded `just check`. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-31 (maintainer, the /quest-complete requeue session): | ||
| root-cause both in one quest, since each is small and they surfaced | ||
| together in that session's merge runs. | ||
|
|
||
| - **Kotlin.** `kt/moq/src/jvmAndAndroidTest/kotlin/dev/moq/SmokeTest.kt:579`. | ||
| An `unroutable` answer means no route served the path when the request | ||
| resolved. A request made before the publisher's route reached the origin | ||
| returns it, and so does one made after that route was withdrawn or the | ||
| broadcast closed. Check both a wait on announcement that the test skips | ||
| and a route withdrawal or close during the collection it cancels. | ||
| - **JS.** `js/net/src/integration.test.ts:1994`, the moq-transport variant | ||
| of the lite test at `:1929`. Under load the late publisher's arrival and | ||
| the blind handle's wait race some deadline; find which, and replace the | ||
| wall-time dependency with an event or a controlled clock. | ||
|
|
||
| Follow the epic's rules: no raised timeout and no retry. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # [S] A reconfigure keeps the published jitter and delay floor | ||
|
|
||
| ## Goal | ||
|
|
||
| Re-setting an already-published rendition, such as an H.264 or H.265 | ||
| same-codec resolution change, never lowers the jitter or delay its catalog | ||
| already advertises for a field the new config leaves unset. The reconfigure | ||
| publishes with the higher of the two, as a measurement does, instead of | ||
| failing with `JitterDecreased` and aborting the TS import. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-31 (maintainer, the /quest-complete requeue session), found | ||
| by the sessions of [moq-dev/moq#7436](https://github.com/moq-dev/moq/pull/7436) | ||
| and [moq-dev/moq#7387](https://github.com/moq-dev/moq/pull/7387). Planned | ||
| here in m1 as its own [S] rather than fixed inside #7436 (no test there needs | ||
| it) or dropped: it blocks the conformance test in #7387 once that fixture is | ||
| repaired. | ||
|
|
||
| `Rendition::set` (`rs/moq-mux/src/catalog/tracks.rs:655`) resolves the new | ||
| config from what it supplies plus the last measurement (`Self::resolved`), | ||
| then `check_decrease` refuses anything below the catalog's current jitter or | ||
| delay. `Rendition::estimate` (`:711`) already floors its result at the | ||
| published values (`resolved.jitter.max(published.jitter)`, `:725-726`). | ||
| After a measurement raises jitter mid-run, a reconfigure that supplies no | ||
| jitter resolves to the lower detected value and fails. Floor the unsupplied | ||
| jitter and delay in `set` at the catalog's published values the same way, so | ||
| `check_decrease` still refuses only a value the caller explicitly lowers. | ||
|
|
||
| `published_text_jitter_never_decreases` (`:1078`) expects a `None` re-set | ||
| after a supplied 100 ms to fail; with the floor it publishes 100 ms. Keep | ||
| the explicit-lower case failing and update the `None` case to the floor. | ||
|
|
||
| Regression test: a unit test in `tracks.rs` that publishes a video config, | ||
| raises its jitter with `estimate`, then `set`s a config with new dimensions | ||
| and no jitter, and asserts it succeeds with the raised jitter still | ||
| published. | ||
|
|
||
| Public API: none. Wire: none. | ||
|
|
||
| ## Related | ||
|
|
||
| - [HLS and DASH segment conformance](/quest/m1/hls-conformance.md) - the conformance test this unblocks | ||
| - [HLS export follows a resolution change](/quest/m1/hls-reinit-same-codec.md) - the same-codec reconfigure that hits it | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # [S] fMP4 refusals keep framing | ||
|
|
||
| ## Goal | ||
|
|
||
| A box the fMP4 importer refuses at its header no longer leaves a caller | ||
| feeding arbitrary chunks out of frame. Either the importer reads the rest of | ||
| that decode call's input past the refused box, so later calls stay | ||
| correctly framed whatever chunk boundaries the caller picks, or the refusal | ||
| is terminal and every later call fails, so no input is silently dropped | ||
| mid-stream. The 4-track | ||
| interleaved import benchmark is no slower than before the streaming change, | ||
| or the cost is measured and accepted. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-31 (maintainer, the /quest-complete requeue session), from | ||
| the follow-ups of [moq-dev/moq#7232](https://github.com/moq-dev/moq/pull/7232) | ||
| (fMP4 streams mdat) and [moq-dev/moq#7234](https://github.com/moq-dev/moq/pull/7234) | ||
| (MKV streams blocks). Both have landed. #7234 landed first, so #7232 already | ||
| streams the importer's samples through `Producer::open`/`commit`; the | ||
| original open/commit bullet is done, and this quest keeps the other two | ||
| ([noted on moq-dev/moq#7468](https://github.com/moq-dev/moq/pull/7468#issuecomment-6554670247)). | ||
|
|
||
| - **A refused box.** `Import::decode` (`rs/moq-mux/src/container/fmp4/import.rs`) | ||
| documents it: a refused box or fragment discards the rest of its body, and | ||
| the rest of the refusing call's input is not read. That suits box-aligned | ||
| callers (HLS ingest feeds one segment per call) but loses framing for | ||
| arbitrary chunking. Either continue past the refused box, or make a | ||
| refusal terminal for the importer as the MKV importer's is. Choose during | ||
| implementation the option that keeps the importer's state simpler while | ||
| meeting HLS ingest's needs, and record the choice in the PR. | ||
| - **Benchmark.** #7232 measured a possible ~25% slowdown in the 4-track | ||
| 16-run whole-input `cmaf-interleaved-import` case, in a noisy run where the | ||
| 4-track cases swung ±40% between runs of one source. Re-measure it with the | ||
| paired comparison on a quiet host, against the commit before #7232, and | ||
| fix it or record why it is accepted. | ||
|
|
||
| Public API: none expected. Wire: none. | ||
|
|
||
| ## Related | ||
|
|
||
| - [MKV leaf element limits](/quest/m1/mkv-leaf-limits.md) - the other leftover of the importer streaming work | ||
| - [Media fuzz](/quest/m2/media-fuzz.md) - would catch a dropped-input bug like the refused-box one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # [XS] MKV leaf element limits | ||
|
|
||
| ## Goal | ||
|
|
||
| The MKV importer refuses a `CodecID`, `DocType`, or `CodecPrivate` element | ||
| whose declared size is past a limit specific to that element, so a header | ||
| declaring a huge one cannot pin importer memory. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-10-31 (maintainer, the /quest-complete requeue session), a | ||
| follow-up of [moq-dev/moq#7234](https://github.com/moq-dev/moq/pull/7234), | ||
| which streams blocks and discards ignored elements but still reads these | ||
| three leaf elements whole (`rs/moq-mux/src/container/mkv/import.rs`, where | ||
| the track entry collects `CodecID` and `CodecPrivate`). #7234 has landed. | ||
|
|
||
| The maintainer earlier ruled out a blanket tag-size cap (it would refuse | ||
| large Segments and Clusters). These limits are per element | ||
| and bound only what the importer must hold whole: a `CodecID` and `DocType` | ||
| are short ASCII strings, and `CodecPrivate` is the decoder config of a | ||
| codec the importer supports: avcC (`V_MPEG4/ISO/AVC`), hvcC | ||
| (`V_MPEGH/ISO/HEVC`), av1C (`V_AV1`), an OpusHead (`A_OPUS`), an AAC | ||
| AudioSpecificConfig (`A_AAC`), or a FLAC header (`A_FLAC`). The FLAC header | ||
| carries every metadata block, so it can hold embedded cover art; size its | ||
| limit for that or refuse such art explicitly. Pick each limit from its spec | ||
| and the largest real decoder config, check them against the MKV fixtures | ||
| for each codec, and return the | ||
| importer's existing error for a refused element. Test each element declared | ||
| past its limit, fed in small chunks. | ||
|
|
||
| Public API: none. Wire: none. | ||
|
|
||
| ## Related | ||
|
|
||
| - [fMP4 refusals keep framing](/quest/m1/fmp4-refusal-framing.md) - the fMP4 leftover of the same streaming work |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.